Suggested backports of JDK 7 langtools fixes to OpenJDK 6

[Joseph D. Darcy]

Andrew John Hughes wrote:
> On 3 March 2010 17:24, Joseph D. Darcy <Joe.Darcy at sun.com> wrote:
>   
>> Jonathan Gibbons wrote:
>>     
>>> Martin Buchholz wrote:
>>>       
>>>> On Wed, Mar 3, 2010 at 08:29, Andrew John Hughes
>>>> <gnu_andrew at member.fsf.org> wrote:
>>>>
>>>>         
>>>>> On 3 March 2010 00:26, Joseph D. Darcy <Joe.Darcy at sun.com> wrote:
>>>>>
>>>>>           
>>>>         
>>>>>               -es -esa \
>>>>>
>>>>>           
>>>> I think
>>>> -vmoption:-es -vmoption:-esa
>>>> was meant.
>>>>
>>>>         
>>> Whoops,
>>>
>>> I think
>>>    -ea -esa
>>> was meant.
>>>
>>>       
>> Yes, sorry for the typo!  The options I meant are "-ea" and "-esa" to enable
>> assertions and enable system assertions, respectively.
>>
>> -Joe
>>
>>     
>
> With the right options, two tests fail:
>
> FAILED: tools/javac/processing/environment/TestSourceVersion.java:
> javac: invalid source release: 1.7
> FAILED: tools/javac/unicode/Unmappable.java: Unmappable.java:37:
> warning: unmappable character for encoding ascii String s =
> "z\ufffdhler";
>   

How are you running these tests to elicit the failures?

When I run the tests on OpenJDK 6 langtools tip with -ea -esa, I only 
see the one expected failure for the EarlyAssert merge issue.

The current OpenJDK 6 version of TestSourceVersion.java doesn't refer to 
1.7; checking your webrev... ah -- the patch should *not* add these 
options to OpenJDK 6.
> The first seems a correct failure; javac on OpenJDK6 should not support 1.7.
> I see different failures on 7:
>
> FAILED: tools/apt/Basics/print.sh: java.lang.AssertionError at
> com.sun.mirror.util.SourceOrderDeclScanner$SourceOrderComparator.compareEqualPosition(SourceOrderDeclScanner.java:104)
> FAILED: tools/apt/Scanners/scanner.sh: java.lang.AssertionError at
> com.sun.mirror.util.SourceOrderDeclScanner$SourceOrderComparator.compareEqualPosition(SourceOrderDeclScanner.java:104)
>   

Strange; those are the problems corrected by 6926703: apt tests should 
run with assertions enabled.

-Joe