Please review change in globalDefinitions.hpp header

[Andrew John Hughes]

On 10 March 2010 21:09, Kelly O'Hair <Kelly.Ohair at sun.com> wrote:
>
> On Mar 10, 2010, at 12:37 PM, Pavel Tisnovsky wrote:
>
>> ----- Kelly O'Hair <Kelly.Ohair at Sun.COM> wrote:
>>>
>>> Looks correct to me.
>>
>> Thanks Kelly.
>>
>> Can you please assign bug id to this change? Incidentally, I'll have more
>> patches due to changes in GCC 4.5.
>> May the same bug identifier be assigned to more changes?
>
> Yes one bug is fine.
>

jcheck will stop this on JDK7 (we turned it off for 6).
Does these apply to 7 as well?  We don't want a pile of patches local
to OpenJDK6.

> 6933846: GCC 4.5 warning removals
>
>
> -kto
>
>>
>> Pavel
>>
>>>
>>> -kto
>>>
>>> On Mar 10, 2010, at 2:50 AM, Pavel Tisnovsky wrote:
>>>
>>>> Hi,
>>>>
>>>> please review change in globalDefinitions.hpp header, which is
>>>> available at:
>>>> http://cr.openjdk.java.net/~ptisnovs/Gcc4.5Errors1/
>>>>
>>>> This simple patch fixes compile failure when -Wall -Werror flags are
>>>> used under gcc 4.5.
>>>>
>>>> Thanks in advance
>>>> Pavel Tisnovsky
>>>
>>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8