Fwd: [OpenJDK 2D-Dev] Request for review/OpenJDK6: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

[Andrew John Hughes]

Should be on jdk6-dev:


---------- Forwarded message ----------
From: Andrew John Hughes <ahughes at redhat.com>
Date: 4 May 2010 11:29
Subject: Re: [OpenJDK 2D-Dev] Request for review/OpenJDK6: 6892485:
Deadlock in SunGraphicsEnvironment / FontManager
To: Roman Kennke <Roman.Kennke at sun.com>
Cc: 2d-dev at openjdk.java.net


On 3 March 2010 16:01, Roman Kennke <Roman.Kennke at sun.com> wrote:
> This is the fix for the deadlock problem in
> SunGraphicsEnvironment/FontManager backported to OpenJDK6. It is
> slightly different from the OpenJDK7 version due to the restructured
> font manager, but the basic idea is the same: instead of sync'ing on 2
> different lock objects (with the potential of entering the monitors in
> the wrong order) we only sync on one (the FontManager class in this
> case, was the FontManager instance in JDK7).
>
> http://cr.openjdk.java.net/~rkennke/6892485/webrev.02/
>
> Ok to push?
>
> Also, is there any additional stuff that needs to be done for pushing to
> OpenJDK6, I never did that and I see that there are not team
> repositories. When I have 2 ok's, should I push directly to the
> jdk6/jdk6-gate/jdk repository?
>

Fixes for OpenJDK6 need to be approved by Joe Darcy.  New patches
(rather than backports) sometimes also need additional review from
people working in the appropriate area.

> Thanks, Roman
>
>



--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8