[Fwd: Request for change in JDK6 - proper ISO-8859-15 charset handling]

[Andrew John Hughes]

On 30 April 2010 18:06, Joe Darcy <joe.darcy at oracle.com> wrote:
> Pavel Tisnovsky wrote:
>>
>> Hi Xueming,
>>
>> may I use bug #6798572 to push changes to OpenJDK6? Only JDK7 is mentioned
>> in this bug...
>
> Per the OpenJDK 6 processes (http://openjdk.java.net/projects/jdk6/), the
> approval of the release manager (currently me) is also needed for all
> changes before they go back.
>
> Given that Sherman has reviewed the technical contents of the change, I also
> approve it going back as long as the now-failing regression test
>   java/nio/charset/Charset/Contains.java
> is updated to include 6798572 in its @bug line.
>

It seems this change went back but without this addition.  Do we still
want to add it?

>>
>> Pavel
>>
>> Xueming Shen wrote:
>>>
>>> Hi Pavel,
>>>
>>> The change itself looks fine.
>>>
>>> This remind me that we have not brought in the test/java/nio/charset in
>>> openjdk6 repo yet.
>
> Actually Andrew John Hughes ported the tests from JDK 7 to OpenJDK 6 in b19:
> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/83980d94b138
>
> Cheers,
>
> -Joe
>
>>> Thanks,
>>> Sherman
>>>
>>>>
>>>>
>>>> -------- Original Message --------
>>>> Subject:     Request for change in JDK6 - proper ISO-8859-15 charset
>>>> handling
>>>> Date:     Fri, 30 Apr 2010 15:07:13 +0200
>>>> From:     Pavel Tisnovsky <ptisnovs at redhat.com>
>>>> To:     jdk6-dev <jdk6-dev at openjdk.java.net>
>>>>
>>>>
>>>>
>>>> Hi,
>>>>
>>>> please review change in JDK6 which provides correct relationship between
>>>> ISO-8859-1 and ISO-8859-15 charsets. The webrew is available at:
>>>> http://cr.openjdk.java.net/~ptisnovs/ISO-8859-15/
>>>>
>>>> This bug was closed and verified in JDK7
>>>> (http://bugs.sun.com/view_bug.do?bug_id=6798572) but not in JDK6, where the
>>>> sources are a bit different.
>>>>
>>>> The correct/incorrect behaviour of charset relationship handling can be
>>>> tested by regression test java/nio/charset/Charset/Contains.java
>>>>
>>>> Cheers
>>>> Pavel Tisnovsky
>>>>
>>>
>>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8