[Fwd: Re: code review for 6949515 (round 0)]

[Andrew John Hughes]

On 18 May 2010 19:24, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> I resynced after the OpenJDK6 update to HSX-17 and pushed the
>
> changeset. A couple of things: there are some other changesets
> in HSX-17 after Andrew grabbed his copy.

As noted in the merge discussion:
http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-May/001565.html
the current sync is to (what was) the last tag hs17-b13.

With Joe's permission, I'll drag in the additional two changesets for
hs17-b14 now the tag is present as per Erik's suggestion:
http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-May/001585.html

 Second, for some reason,
> I think changeset notification for OpenJDK6 and maybe OpenJDK7
> is broken...

I'm seeing that too... no notification for my 400 changeset push yesterday.

>
> Dan
>
>
>
> On 5/17/2010 11:18 AM, Daniel D. Daugherty wrote:
>> I'm also targeting the fix for HSX-17-B15 so it might already be there
>> by the time Andrew is done...
>>
>> Dan
>>
>> On 5/17/2010 10:55 AM, Joe Darcy wrote:
>>> Hi Dan.
>>>
>>> Thanks for the fix. I think this would be a fine change for OpenJDK
>>> 6; in terms of sequencing, I think it should go back after Andrew's
>>> HS17 merge into OpenJDK 6.
>>>
>>> -Joe
>>>
>>> Daniel D. Daugherty wrote:
>>>> Joe,
>>>>
>>>> This is a crasher that came in with the HSX-16 update. I think you
>>>> probably want this fix.
>>>>
>>>> Here is the OpenJDK webrev:
>>>>
>>>> http://cr.openjdk.java.net/~dcubed/6949515-webrev/0/
>>>>
>>>> I don't know why the bugs.sun.com link doesn't show anything yet...
>>>>
>>>> I've had three internal reviewers.
>>>>
>>>> Dan
>>>>
>>>>
>>>>
>>>>
>>>> On 5/12/2010 10:29 AM, daniel.daugherty at oracle.com wrote:
>>>>> Greetings,
>>>>>
>>>>> The jmethodID performance fix that we did back in August 2009 has
>>>>> a small problem with GC'ed jmethodIDs. Tomas Hurka reported the
>>>>> crash and was kind enough to test my proposed fix. Strangely
>>>>> enough, we don't have an existing test that runs into this problem.
>>>>>
>>>>> Here is the webrev URL:
>>>>>
>>>>> http://javaweb.sfbay/~dcubed/6949515-webrev/0/
>>>>>
>>>>> Here is the webrev URL for the original jmethodID performance fix:
>>>>>
>>>>> http://javaweb.sfbay/~dcubed/6862945-webrev/1/
>>>>>
>>>>> I'm planning to push this fix to OpenJDK6 (HSX-16) and OpenJDK7
>>>>> (HSX-18).
>>>>>
>>>>> Thanks, in advance, for any comments.
>>>>>
>>>>> Dan
>>>>>
>>>
>>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8