6-open putback request: 6948909 and 6948803

[Joe Darcy]

Hello.

Weijun Wang wrote:
> Hi Joe
>
> webrev updated:
>
> http://cr.openjdk.java.net/~weijun/6948803/6-open/webrev.01/
> http://cr.openjdk.java.net/~weijun/6948909/6-open/webrev.01/
>
> On May 22, 2010, at 5:22 AM, Joe Darcy wrote:
>
>   
>> For test/sun/security/validator/CertReplace.java, I recommend using a different kind of InputStream to pass the certificate rather than a FileInputStream.  For example, a ByteInputStream would allow a byte array to hold the (now binary) contents of the certificate file test/sun/security/validator/certreplace.jks.
>>     
>
> I've put all data in test/sun/security/validator/CertReplace.java. The binary one now a byte[], and ASCII one a string.
>   

Good.

>   
>> For test/sun/security/tools/jarsigner/diffend.sh, I strongly encourage this to be rewritten as a Java program.
>>     
>
> The test calls zip, unzip and jarsigner commands. It might be possible to convert all calls into Java methods but the result will be quite complicated and not easy to read. Almost all security tools tests are written as shell scripts.
>   

In langtools, we've taken to writing such code in Java using 
Runtime.exec; I recommend considering this approach for other shell 
tests too.

>   
>> For both webrevs, please manually make sure the copyright dates are correct.
>>     
>
> Updated.
>
> And yes, both bugs have already been fixed in openjdk-7, changesets pushed into the TL forest.
>
>   

Is

6954621: small error in 6948909

also needed in OpenJDK 6?  If so, I approve all three bugs going back.

Thanks,

-Joe