6-open putback request: 6948909 and 6948803

[Joe Darcy]

On 05/24/10 03:58 PM, Weijun Wang wrote:
>>>  
>>>       
>>>> For test/sun/security/tools/jarsigner/diffend.sh, I strongly encourage this to be rewritten as a Java program.
>>>>    
>>>>         
>>> The test calls zip, unzip and jarsigner commands. It might be possible to convert all calls into Java methods but the result will be quite complicated and not easy to read. Almost all security tools tests are written as shell scripts.
>>>  
>>>       
>> In langtools, we've taken to writing such code in Java using Runtime.exec; I recommend considering this approach for other shell tests too.
>>     
>
> I'll consider it later.
>
>   
>> Is
>>
>> 6954621: small error in 6948909
>>
>> also needed in OpenJDK 6?  If so, I approve all three bugs going back.
>>     
>
> I've merged the code change in 6954621 into 6948909 for both 6u21 and 6-open. 6948909 is the main bug id anyway.
>   

Okay; but for bug tracking it is often easier if the bugs in question 
have a sub CR (release specific entry) for each release it is going 
into.  In particular, it would ease future bug archeology efforts if 
6954621 had a sub CR for OpenJDK 6.

I approve the current versions of your changes going back OpenJDK 6 has 
sub CRs for all three bugs.

Thanks,

-Joe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20100524/4670594c/attachment.html