Need reviewer: More rebranding changes, sorry
Joe Darcy
joe.darcy at oracle.com
Wed May 26 19:18:21 PDT 2010
Jonathan Gibbons wrote:
> On 05/26/2010 06:21 PM, Kelly O'Hair wrote:
>>
>> Missed a few files on the first pass....
>>
>> 6956202: Fix a few missed rebranding issues, please contact lines etc.
>>
>> http://cr.openjdk.java.net/~ohair/openjdk6/rebranding.6910/openjdk6/jdk6-master/
>>
>>
>> -kto
>>
>
> langtools, corba look OK.
I second Jon's approval of those repos (email client locked up before I
could send my message earlier).
>
> jdk is not.
>
> src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
>
> By deleting lines you've left a dangling phrase in front, referring to
> a non-existent following copyright.
Agreed.
>
>
> Also, FYI, you've added newlines at the end of files where there were
> none previously. That's not wrong and it looks OK in all cases, but it
> was my understanding you were trying to retain this property of files.
I approve the newlines being added to the *.sh files as long as the
tests still pass.
-Joe
More information about the jdk6-dev
mailing list