Need reviewer: More rebranding changes, sorry

Kelly O'Hair kelly.ohair at oracle.com
Wed May 26 20:10:16 PDT 2010


On May 26, 2010, at 6:41 PM, Jonathan Gibbons wrote:

> On 05/26/2010 06:21 PM, Kelly O'Hair wrote:
>>
>> Missed a few files on the first pass....
>>
>> 6956202: Fix a few missed rebranding issues, please contact lines  
>> etc.
>>
>> http://cr.openjdk.java.net/~ohair/openjdk6/rebranding.6910/openjdk6/jdk6-master/
>>
>> -kto
>>
>
> langtools, corba look OK.
>
> jdk is not.
>
> src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
>
> By deleting lines you've left a dangling phrase in front, referring  
> to a non-existent following copyright.

Thanks for catching this, I thought I un-did this change. I'll not be  
changing this file at all.

>
>
> Also, FYI, you've added newlines at the end of files where there  
> were none previously. That's not wrong and it looks OK in all cases,  
> but it was my understanding you were trying to retain this property  
> of files.

I only added newlines where I thought it was an oversight that they  
did not have them, and completely harmless.
I did this by hand.
My rebranding script won't work on files that do not have a newline at  
the end.

-kto

>
> -- Jon
>
>



More information about the jdk6-dev mailing list