Need reviewer: fixing some rebranding issues during the build

[Kelly O'Hair]

On May 27, 2010, at 11:10 PM, Erik Trimble wrote:

> On 5/27/2010 11:05 PM, Joe Darcy wrote:
>> Kelly O'Hair wrote:
>>>
>>> Need reviewer: fixing some rebranding issues during the build
>>>
>>> 6949590: exes(java.exe, javaws.exe) show Copyright Year as 2004,  
>>> COMPANY as Sun
>>> 6955707: Correct addNotices.sh logic in Makefiles
>>>
>>> http://cr.openjdk.java.net/~ohair/openjdk6/rebranding-gensrc/webrev/
>>>
>>> -kto
>>>
>>
>> What effect does setting, or not setting, OS_VENDOR have?
>>
>> -Joe
>
> I've got a couple of those in Hotspot, also, where we've set the  
> value of something (variable/constant) to "Sun Microsystems".  I  
> didn't want to change those until I got a better feeling from  
> development as to what changing them would mean...

Yes, be very careful with the ones in Hotspot, those actually impact  
the java property values, and we are not ready to
change that. Hotspot in particular needs to be careful, because in  
jdk6 we explicitly are NOT changing these java
property values, and hotspot sources get delivered into multiple  
places. There is a separate bug on this one.

The OS_VENDOR make variable was never used, might have been used a  
long time ago in the sanity checks
or summary messages, but it was never a reliable indication of what OS  
was being used, it was supposed to
document the required OS vendor for jdk builds, which we kind of  
abandoned that with OpenJDK.
We still have a required OS for RE builds, but no vendor name is ever  
really needed or used now.
This had nothing to do with the java vendor property values.

-kto

>
> -- 
> Erik Trimble
> Java System Support
> Mailstop:  usca22-123
> Phone:  x17195
> Santa Clara, CA
>