hs19 import

[Andrew Haley]

On 11/09/2010 10:15 AM, Mark Wielaard wrote:
> On Tue, 2010-11-09 at 10:50 +0100, Mark Wielaard wrote:
>> On Wed, 2010-11-03 at 17:41 +0000, Dr Andrew John Hughes wrote:
>>> On 14:04 Tue 02 Nov     , Erik Trimble wrote:
>>>> On 11/2/2010 1:02 PM, Mark Wielaard wrote:
>>>>> Do you think the changes between b06 and b09 should go into the openjdk6
>>>>> hotspot (for openjdk6-b21) or would it be better not to for now?
>>>>>
>>>> I'll re-check, but I think it may have been a simple oversight on my 
>>>
>>> With both the master and baseline versions of hs19, we are hitting this bug:
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=647737
>>>
>>> This really needs to be fixed before we can release OpenJDK6 b21 with HotSpot 19.
>>
>> So for those not having tracked that bug report, it turned out to have
>> been caused by compressed oops being on by default now. The easiest
>> workaround is something like this patch:
>>
>> --- openjdk/hotspot/src/share/vm/runtime/arguments.cpp.sav    2010-11-08 23:50:59.000000000 -0500
>> +++ openjdk/hotspot/src/share/vm/runtime/arguments.cpp        2010-11-08 23:52:53.000000000 -0500
>> @@ -1301,7 +1301,8 @@ void Arguments::set_ergonomics_flags() {
>>    if (MaxHeapSize <= max_heap_for_compressed_oops()) {
>>  #ifndef COMPILER1
>>      if (FLAG_IS_DEFAULT(UseCompressedOops) && !UseG1GC) {
>> -      FLAG_SET_ERGO(bool, UseCompressedOops, true);
>> +      // Temporarily fix rhbz#647737 -- disable compressed oops by default
>> +      //FLAG_SET_ERGO(bool, UseCompressedOops, true);
> 
> Ismael Juma pointed out on irc that the way it was disabled for hsx17
> was with the following commit:
> http://hg.openjdk.java.net/hsx/hsx17/master/rev/8e02b8f703b2
> 

That looks better.

Andrew.