Request to backport 6979979: Rounding error in font sizes selected by the GTK Look and Feel

[Phil Race]

  That's an inconsequential difference, so I can't think of any reason 
why not .. the change looks fine to me

-phil.

On 10/20/2010 11:24 AM, Omair Majid wrote:
> On 10/19/2010 03:18 PM, Joe Darcy wrote:
>> Omair Majid wrote:
>>> On 10/19/2010 01:38 PM, Dr Andrew John Hughes wrote:
>>>> On 13:11 Tue 19 Oct , Omair Majid wrote:
>>>>> Hi,
>>>>>
>>>>> I would like to backport the following changeset to openjdk6:
>>>>>
>>>>> changeset: 2720:bb733c150f94
>>>>> user: omajid
>>>>> date: Tue Sep 14 10:45:38 2010 -0400
>>>>> summary: 6979979: Rounding error in font sizes selected by the GTK
>>>>> Look and Feel
>>>>>
>>>>> It selects a better font size the when Swing is using the
>>>>> GTKLookAndFeel.
>>>>>
>>>>> Thanks,
>>>>> Omair
>>>>
>>>> Is this backported in IcedTea6?
>>>
>>> As far as I am aware, no. I am going to add this to IcedTea6 if the
>>> openjdk6 devs are ok with adding it to openjdk6.
>>>
>>> Cheers,
>>> Omair
>>
>> Hello Omair.
>>
>> Approved to be backported to OpenJDK 6 b21 (the current build).
>>
>> Thanks,
>>
>> -Joe
>
> Thanks for the approval. Unfortunately, the patch does not apply 
> straight-away. There was some refactoring in FontManager and 
> FontUtilies - the patch requires changing the class from FontUtilites 
> to FontManager.
>
> The webrev:
> http://cr.openjdk.java.net/~omajid/webrevs/gtk-floating-point-font-size-support-jdk6/webrev.00/ 
>
> is identical to the original webrev for the fix:
> http://cr.openjdk.java.net/~omajid/webrevs/gtk-floating-point-font-size-support/webrev.01/ 
>
> with the exception of the FontUtilties -> FontManager rename.
>
> Can I still go ahead and backport?
>
> Thanks,
> Omair