Please review change in regression test javax/swing/plaf/synth/Test6933784.java

Joe Darcy joe.darcy at oracle.com
Sun Sep 19 15:28:54 PDT 2010


Pavel Tisnovsky wrote:
> Joe Darcy wrote:
>   
>> Pavel Tisnovsky wrote:
>>     
>>> Hi,
>>>
>>> can anybody please review change in regression test
>>> javax/swing/plaf/synth/Test6933784.java? Webrev is available here:
>>>
>>> http://cr.openjdk.java.net/~ptisnovs/Test6933784/
>>>
>>> I changed just the code which tries to initialize Nimbus look and feel.
>>>
>>> Original code works in OpenJDK7 but not in OpenJDK6 because the location
>>> of the Nimbus package changed between the 6u10 and JDK7 releases
>>> (additionally I think it is not recommended to set Nimbus look and feel
>>> explicitly).
>>>
>>> Cheers
>>> Pavel T.
>>>   
>>>       
>> Hello.
>>
>> Approved to go back into OpenJDK 6 on the assumption of successfully
>> running!
>>     
> Thank you. I've successfully ran it on RHEL5 and F13.
>   
>> Do you need a bug id to push this?
>>     
> Yes please. 

Please use

6985992 Fix test/javax/swing/plaf/synth/Test6933784.java for OpenJDK 6

> Should I wait for approval from another Oracle developer?
>   

In this case, my review is sufficient.

Thanks,

-Joe


More information about the jdk6-dev mailing list