From philip.race at oracle.com Mon Jan 3 09:31:46 2011 From: philip.race at oracle.com (Phil Race) Date: Mon, 03 Jan 2011 09:31:46 -0800 Subject: OpenJDK 6 may stop builds on CP936 Mac & Linux In-Reply-To: <4D1E1DF6.2060401@gmail.com> References: <4D1E1DF6.2060401@gmail.com> Message-ID: <4D220802.7090601@oracle.com> Whilst I don't know the specifics of this issue the Openjdk builds require that you use the 'C' psuedo-locale for builds and that the sanity check will complain and point out that build failures are possible for other locales. So this would be "not a bug", or a bug in the 'date' program if its ignoring your locale setting of 'C'. -phil. On 12/31/2010 10:16 AM, Johnson Lau wrote: > Hi, > > I've just found that OpenJDK 6 may stop builds on CP936 Mac & Linux. > Checked the latest repo and confirmed that the bug still exists. > http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/3a8a8b5f1612/make/common/shared/Defs.gmk > > Line #275 > > Currently, FULL_VERSION uses a format with local abbreviated month > name (%b). > On these platforms, date will produce a string in local language with > space > (i.e. [_1?] which indicates January), > which breaks the builds. > > This is fixed in OpenJDK 7 already so I brought the patch into JDK 6. > Hope someone can merge this. > > Thanks, > Johnson Lau From kelly.ohair at oracle.com Mon Jan 3 10:03:14 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 3 Jan 2011 10:03:14 -0800 Subject: OpenJDK 6 may stop builds on CP936 Mac & Linux In-Reply-To: <4D220802.7090601@oracle.com> References: <4D1E1DF6.2060401@gmail.com> <4D220802.7090601@oracle.com> Message-ID: <89BE5DE5-C126-49AB-B4F8-107D59B267BF@oracle.com> Phil has a point, I'm not sure how valid a jdk build is with a non-C locale. Using LANG=C is advised. However, I have no objection to this change being made by someone. The %b is a locale specific value and really should be avoided. -kto On Jan 3, 2011, at 9:31 AM, Phil Race wrote: > Whilst I don't know the specifics of this issue the Openjdk builds > require > that you use the 'C' psuedo-locale for builds and that the sanity > check > will complain and point out that build failures are possible for > other locales. > So this would be "not a bug", or a bug in the 'date' program if its > ignoring > your locale setting of 'C'. > > -phil. > > On 12/31/2010 10:16 AM, Johnson Lau wrote: >> Hi, >> >> I've just found that OpenJDK 6 may stop builds on CP936 Mac & Linux. >> Checked the latest repo and confirmed that the bug still exists. >> http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/3a8a8b5f1612/make/common/shared/Defs.gmk >> Line #275 >> >> Currently, FULL_VERSION uses a format with local abbreviated month >> name (%b). >> On these platforms, date will produce a string in local language >> with space >> (i.e. [_1?] which indicates January), >> which breaks the builds. >> >> This is fixed in OpenJDK 7 already so I brought the patch into JDK 6. >> Hope someone can merge this. >> >> Thanks, >> Johnson Lau > From jim.holmlund at sun.com Mon Jan 3 11:02:32 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Mon, 03 Jan 2011 19:02:32 +0000 Subject: hg: jdk6/jdk6/langtools: 7008433: Minor copyright changes Message-ID: <20110103190234.65AB44793B@hg.openjdk.java.net> Changeset: a9479f61cd7e Author: jjh Date: 2011-01-03 10:38 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/a9479f61cd7e 7008433: Minor copyright changes Summary: Changed Sun to Oracle, etc. Reviewed-by: ohair ! make/netbeans/langtools/build.xml ! make/netbeans/langtools/nbproject/project.xml ! make/netbeans/langtools/nbproject/standard-context-menu-items.ent ! make/netbeans/langtools/nbproject/standard-ide-actions.ent ! make/tools/SelectTool/SelectToolTask.java ! test/tools/javac/6889255/T6889255.java ! test/tools/javac/T6595666.java ! test/tools/javac/policy/test3/Test.java From ptisnovs at redhat.com Tue Jan 4 05:17:35 2011 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Tue, 04 Jan 2011 14:17:35 +0100 Subject: Reviewer needed: backport of regression tests sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/* In-Reply-To: <4D19163B.9030301@oracle.com> References: <4CFE27BA.1010504@redhat.com> <4D19163B.9030301@oracle.com> Message-ID: <4D231DEF.5040409@redhat.com> Hi Joe, thank you for your answer. Do I need a new bug id(s) for this backport or is it possible to use 6941936 and 6943219 for two separate pushes? Cheers, Paver Joe Darcy wrote: > Hi Pavel. > > Sorry for the belated reply. Backporting these bug fixes is appropriate > for OpenJDK 6. It would be preferable if there were separate changesets > for each bug, but combining them into one is acceptable -- approved to > go back. > > Cheers, > > -Joe > > On 12/7/2010 4:25 AM, Pavel Tisnovsky wrote: >> Hi all, >> >> can anyone please review backport of regression tests >> sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/*? >> >> Webrev containing the backport is available at: >> http://cr.openjdk.java.net/~ptisnovs/HttpsURLConnection-test-backports/ >> >> This backport is based on two fixes in OpenJDK7: >> >> 6941936: Broken pipe error of test case DNSIdentities.java >> Reviewed-by: chegar >> >> 6943219: >> test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java >> >> fail in linux >> Reviewed-by: andrew >> >> >> Best regards, >> Pavel > From joe.darcy at oracle.com Tue Jan 4 06:57:10 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 04 Jan 2011 06:57:10 -0800 Subject: Reviewer needed: backport of regression tests sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/* In-Reply-To: <4D231DEF.5040409@redhat.com> References: <4CFE27BA.1010504@redhat.com> <4D19163B.9030301@oracle.com> <4D231DEF.5040409@redhat.com> Message-ID: <4D233546.8040005@oracle.com> Hello Pavel. For any way these bugs go back, the existing two ids should be used. This can be done either by 1) Doing two pushes, one for each bug. 2) In a single push, list both bug ids in the comment, one bug id on the first line, the second id on the second line. Regards, -Joe Pavel Tisnovsky wrote: > Hi Joe, > > thank you for your answer. Do I need a new bug id(s) for this backport > or is it possible to use 6941936 and 6943219 for two separate pushes? > > Cheers, > Paver > > Joe Darcy wrote: > >> Hi Pavel. >> >> Sorry for the belated reply. Backporting these bug fixes is appropriate >> for OpenJDK 6. It would be preferable if there were separate changesets >> for each bug, but combining them into one is acceptable -- approved to >> go back. >> >> Cheers, >> >> -Joe >> >> On 12/7/2010 4:25 AM, Pavel Tisnovsky wrote: >> >>> Hi all, >>> >>> can anyone please review backport of regression tests >>> sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/*? >>> >>> Webrev containing the backport is available at: >>> http://cr.openjdk.java.net/~ptisnovs/HttpsURLConnection-test-backports/ >>> >>> This backport is based on two fixes in OpenJDK7: >>> >>> 6941936: Broken pipe error of test case DNSIdentities.java >>> Reviewed-by: chegar >>> >>> 6943219: >>> test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java >>> >>> fail in linux >>> Reviewed-by: andrew >>> >>> >>> Best regards, >>> Pavel >>> > > From ptisnovs at redhat.com Tue Jan 4 08:36:28 2011 From: ptisnovs at redhat.com (ptisnovs at redhat.com) Date: Tue, 04 Jan 2011 16:36:28 +0000 Subject: hg: jdk6/jdk6/jdk: 6941936: Broken pipe error of test case DNSIdentities.java; ... Message-ID: <20110104163644.B57194796B@hg.openjdk.java.net> Changeset: 8d5a2f11d6c6 Author: ptisnovs Date: 2011-01-04 17:38 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/8d5a2f11d6c6 6941936: Broken pipe error of test case DNSIdentities.java 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux Summary: Testcase correction. Reviewed-by: chegar, andrew, darcy ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsPost.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressDNSIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Identities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Redirect.java From ptisnovs at redhat.com Tue Jan 4 09:00:06 2011 From: ptisnovs at redhat.com (ptisnovs at redhat.com) Date: Tue, 04 Jan 2011 17:00:06 +0000 Subject: hg: jdk6/jdk6/jdk: 6560348: PIT : java/awt/xembed/server/RunTestXEmbed.java fails Message-ID: <20110104170014.C425E4796E@hg.openjdk.java.net> Changeset: 884dab2cfd50 Author: ptisnovs Date: 2011-01-04 18:03 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/884dab2cfd50 6560348: PIT : java/awt/xembed/server/RunTestXEmbed.java fails Summary: Testcase correction. Reviewed-by: anthony ! test/java/awt/xembed/server/TestXEmbedServer.java From ahughes at redhat.com Fri Jan 7 09:11:45 2011 From: ahughes at redhat.com (ahughes at redhat.com) Date: Fri, 07 Jan 2011 17:11:45 +0000 Subject: hg: jdk6/jdk6/jdk: 6668231: Presence of a critical subjectAltName causes JSSE's SunX509 to fail trusted checks Message-ID: <20110107171153.A413547A68@hg.openjdk.java.net> Changeset: acda21e83215 Author: xuelei Date: 2010-10-26 18:13 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/acda21e83215 6668231: Presence of a critical subjectAltName causes JSSE's SunX509 to fail trusted checks Summary: make the critical extension known to end entity checker. Reviewed-by: wetmore, mullan ! src/share/classes/sun/security/validator/EndEntityChecker.java + test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java From ahughes at redhat.com Fri Jan 7 09:36:59 2011 From: ahughes at redhat.com (ahughes at redhat.com) Date: Fri, 07 Jan 2011 17:36:59 +0000 Subject: hg: jdk6/jdk6/jdk: 6963870: NPE in CompoundBorder.getInsets() Message-ID: <20110107173707.4B84547A6B@hg.openjdk.java.net> Changeset: bc63cfb452f7 Author: peterz Date: 2010-06-29 14:42 +0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/bc63cfb452f7 6963870: NPE in CompoundBorder.getInsets() Reviewed-by: alexp Contributed-by: jon.vanalten at redhat.com ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java + test/com/sun/java/swing/plaf/gtk/Test6963870.java From ahughes at redhat.com Fri Jan 7 12:38:45 2011 From: ahughes at redhat.com (ahughes at redhat.com) Date: Fri, 07 Jan 2011 20:38:45 +0000 Subject: hg: jdk6/jdk6/hotspot: 6994130: Zero PowerPC fix Message-ID: <20110107203847.45D4247A74@hg.openjdk.java.net> Changeset: fbc0d1be89ed Author: twisti Date: 2010-10-22 03:34 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/fbc0d1be89ed 6994130: Zero PowerPC fix Summary: 6953477 broke Zero. Reviewed-by: twisti Contributed-by: Gary Benson ! src/share/vm/runtime/frame.cpp From ahughes at redhat.com Fri Jan 7 12:46:48 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Fri, 7 Jan 2011 20:46:48 +0000 Subject: [PING] Re: About time for b21? In-Reply-To: <4D192CF4.8020002@oracle.com> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> Message-ID: <20110107204648.GC17639@rivendell.middle-earth.co.uk> On 16:19 Mon 27 Dec , Joe Darcy wrote: > Hello. > > Sorry for the tardy responses on OpenJDK 6 matters of late; I've been > caught up working on a flurry of Project Coin activities. > Guessed it was something like that :-) Any idea when 7 will move into testing mode and 8 will become the main development arm? I recall something about February? > On 12/3/2010 5:59 AM, Dr Andrew John Hughes wrote: > > On 13:31 Tue 23 Nov , Dr Andrew John Hughes wrote: > >>>>> Building HS19 with Zero on PowerPC requires a fix (6994130). > >>>>> There's a webrev (for JDK7, but it's the same) here: > >>>>> > >>>>> http://cr.openjdk.java.net/~gbenson/zero-ppc-fix/ > >>>>> > >>>>> Would it be possible to backport this? > >>>> Once 6994130 is approved and integrated into JDK 7, I approve it > >>>> being backported to OpenJDK 6. > >> It's now in b119 so presumably it can be backported? Without it, the PPC build is broken > >> which is a regression from b20. > > Yes, 6994130 has been in JDK 7 for a few builds so it can be backported > to OpenJDK 6. > Done: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/fbc0d1be89ed > >> We're still waiting on: > >> > >> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-October/002080.html > > > 6668231: Presence of a critical subjectAltName causes JSSE's SunX509 to fail trusted checks > > Summary: make the critical extension known to end entity checker. > > Reviewed-by: wetmore, mullan > > > > Ok for push? The binary keystores are copied as-is from OpenJDK7. > > > > The changes in 6668231 are approved for backporting. > Done: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/acda21e83215 > > >> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-September/002008.html > > For the javac changes, backporting 6638712 in and of itself would be > fine; however, backporting 6650759 would be problematic since it > implements a type-inference specification change in JDK 7. There are > differences between the type inference behavior of javac in OpenJDK 6 > and the propriety JDK this issue is one of them. The inference > algorithm in OpenJDK 6 could be reworked a bit, but I don't expect the > javac team to have cycles for that task in the near future. > Ok, we already have both fixes in IcedTea6. They are necessary to be able to build JBoss AIUI. > >> I'd also like to get: > >> > >> changeset: 2527:f1bafc4f249d > >> user: peterz > >> date: Tue Jun 29 14:42:30 2010 +0400 > >> summary: 6963870: NPE in CompoundBorder.getInsets() > >> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f1bafc4f249d > >> > >> in as mentioned in http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-August/001954.html > > 6963870 is approved for backporting. > Done: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/bc63cfb452f7 > >> As no solution for the hs19 bug has been forthcoming, I suggest we disable compressed oops > >> as we have in IcedTea6: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010877.html > >> > > The compressed oops issue has now been fixed: > > > > changeset: 1873:4da76e32c0be > > user: never > > date: Wed Dec 01 10:16:31 2010 -0800 > > summary: 7002666: eclipse CDT projects crash with compressed oops > > http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/4da76e32c0be > > > > Is there any movement on any of these patches being approved for OpenJDK6? > > > > Hmmm. Perhaps it is more prudent to disable compressed oops in OpenJDK > 6 b21 and then enable them in a subsequent build after a sync with hs20. > We've already backported this to IcedTea6 1.9 and it solves the issue with no further problems so far over the last month. I'll leave the decision for OpenJDK6 up to you, but we'll have compressed oops enabled in IcedTea6 unless something else comes up. Once we decide which fix to push (7002666 or a disable oops), can we finally get b21 out the door? > -Joe > Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Fri Jan 7 14:57:17 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 07 Jan 2011 14:57:17 -0800 Subject: OpenJDK 6 may stop builds on CP936 Mac & Linux In-Reply-To: <89BE5DE5-C126-49AB-B4F8-107D59B267BF@oracle.com> References: <4D1E1DF6.2060401@gmail.com> <4D220802.7090601@oracle.com> <89BE5DE5-C126-49AB-B4F8-107D59B267BF@oracle.com> Message-ID: <4D279A4D.2000105@oracle.com> If the JDK 7 bug id of the change is provided, I can take a look at that for back porting to OpenJDK 6. -Joe Kelly O'Hair wrote: > Phil has a point, I'm not sure how valid a jdk build is with a non-C > locale. > Using LANG=C is advised. > > However, I have no objection to this change being made by someone. > The %b is a locale specific value and really should be avoided. > > -kto > > On Jan 3, 2011, at 9:31 AM, Phil Race wrote: > >> Whilst I don't know the specifics of this issue the Openjdk builds >> require >> that you use the 'C' psuedo-locale for builds and that the sanity check >> will complain and point out that build failures are possible for >> other locales. >> So this would be "not a bug", or a bug in the 'date' program if its >> ignoring >> your locale setting of 'C'. >> >> -phil. >> >> On 12/31/2010 10:16 AM, Johnson Lau wrote: >>> Hi, >>> >>> I've just found that OpenJDK 6 may stop builds on CP936 Mac & Linux. >>> Checked the latest repo and confirmed that the bug still exists. >>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/3a8a8b5f1612/make/common/shared/Defs.gmk >>> >>> Line #275 >>> >>> Currently, FULL_VERSION uses a format with local abbreviated month >>> name (%b). >>> On these platforms, date will produce a string in local language >>> with space >>> (i.e. [_1?] which indicates January), >>> which breaks the builds. >>> >>> This is fixed in OpenJDK 7 already so I brought the patch into JDK 6. >>> Hope someone can merge this. >>> >>> Thanks, >>> Johnson Lau >> > From erik.trimble at oracle.com Fri Jan 7 20:34:37 2011 From: erik.trimble at oracle.com (Erik Trimble) Date: Fri, 07 Jan 2011 20:34:37 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <20110107204648.GC17639@rivendell.middle-earth.co.uk> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> Message-ID: <4D27E95D.1050508@oracle.com> On 1/7/2011 12:46 PM, Dr Andrew John Hughes wrote: > On 16:19 Mon 27 Dec , Joe Darcy wrote: >> Hello. >> >> Sorry for the tardy responses on OpenJDK 6 matters of late; I've been >> caught up working on a flurry of Project Coin activities. >> > Guessed it was something like that :-) > > Any idea when 7 will move into testing mode and 8 will become the main > development arm? I recall something about February? > I certainly can't speak officially on this topic, but that sounds like a reasonable timeframe. :-) Also, note that the "feature freeze" time may be slightly different for the VM vs the rest of the JDK. -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA Timezone: US/Pacific (GMT-0800) From joe.darcy at oracle.com Mon Jan 10 11:26:46 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 10 Jan 2011 11:26:46 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <20110107204648.GC17639@rivendell.middle-earth.co.uk> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> Message-ID: <4D2B5D76.70604@oracle.com> Dr Andrew John Hughes wrote: > On 16:19 Mon 27 Dec , Joe Darcy wrote: > >> Hello. >> >> Sorry for the tardy responses on OpenJDK 6 matters of late; I've been >> caught up working on a flurry of Project Coin activities. >> >> > > Guessed it was something like that :-) > > Any idea when 7 will move into testing mode and 8 will become the main > development arm? I recall something about February? > > >> On 12/3/2010 5:59 AM, Dr Andrew John Hughes wrote: >> >>> On 13:31 Tue 23 Nov , Dr Andrew John Hughes wrote: >>> >>>>>>> Building HS19 with Zero on PowerPC requires a fix (6994130). >>>>>>> There's a webrev (for JDK7, but it's the same) here: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~gbenson/zero-ppc-fix/ >>>>>>> >>>>>>> Would it be possible to backport this? >>>>>>> >>>>>> Once 6994130 is approved and integrated into JDK 7, I approve it >>>>>> being backported to OpenJDK 6. >>>>>> >>>> It's now in b119 so presumably it can be backported? Without it, the PPC build is broken >>>> which is a regression from b20. >>>> >> Yes, 6994130 has been in JDK 7 for a few builds so it can be backported >> to OpenJDK 6. >> >> > > Done: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/fbc0d1be89ed > > >>>> We're still waiting on: >>>> >>>> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-October/002080.html >>>> >>> 6668231: Presence of a critical subjectAltName causes JSSE's SunX509 to fail trusted checks >>> Summary: make the critical extension known to end entity checker. >>> Reviewed-by: wetmore, mullan >>> >>> Ok for push? The binary keystores are copied as-is from OpenJDK7. >>> >>> >> The changes in 6668231 are approved for backporting. >> >> > > Done: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/acda21e83215 > > >>>> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-September/002008.html >>>> >> For the javac changes, backporting 6638712 in and of itself would be >> fine; however, backporting 6650759 would be problematic since it >> implements a type-inference specification change in JDK 7. There are >> differences between the type inference behavior of javac in OpenJDK 6 >> and the propriety JDK this issue is one of them. The inference >> algorithm in OpenJDK 6 could be reworked a bit, but I don't expect the >> javac team to have cycles for that task in the near future. >> >> > > Ok, we already have both fixes in IcedTea6. They are necessary to be able > to build JBoss AIUI. > > >>>> I'd also like to get: >>>> >>>> changeset: 2527:f1bafc4f249d >>>> user: peterz >>>> date: Tue Jun 29 14:42:30 2010 +0400 >>>> summary: 6963870: NPE in CompoundBorder.getInsets() >>>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f1bafc4f249d >>>> >>>> in as mentioned in http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-August/001954.html >>>> >> 6963870 is approved for backporting. >> >> > > Done: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/bc63cfb452f7 > > >>>> As no solution for the hs19 bug has been forthcoming, I suggest we disable compressed oops >>>> as we have in IcedTea6: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010877.html >>>> >>>> >>> The compressed oops issue has now been fixed: >>> >>> changeset: 1873:4da76e32c0be >>> user: never >>> date: Wed Dec 01 10:16:31 2010 -0800 >>> summary: 7002666: eclipse CDT projects crash with compressed oops >>> http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/4da76e32c0be >>> >>> Is there any movement on any of these patches being approved for OpenJDK6? >>> >>> >> Hmmm. Perhaps it is more prudent to disable compressed oops in OpenJDK >> 6 b21 and then enable them in a subsequent build after a sync with hs20. >> >> > > We've already backported this to IcedTea6 1.9 and it solves the issue with > no further problems so far over the last month. I'll leave the decision for > OpenJDK6 up to you, but we'll have compressed oops enabled in IcedTea6 unless > something else comes up. > > Once we decide which fix to push (7002666 or a disable oops), can we finally get > b21 out the door? > > Hello. Since you haven't run into any issues with having 7002666 in IcedTea6 1.9, I'm satisfied to have it this build of OpenJDK 6, which should bring b21 to a close! -Joe From ahughes at redhat.com Mon Jan 10 12:09:06 2011 From: ahughes at redhat.com (ahughes at redhat.com) Date: Mon, 10 Jan 2011 20:09:06 +0000 Subject: hg: jdk6/jdk6/jdk: 2 new changesets Message-ID: <20110110200928.427A047B21@hg.openjdk.java.net> Changeset: 0e72e58a762d Author: bae Date: 2011-01-10 20:05 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d 6541476: PNG imageio plugin incorrectly handles iTXt chunk Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java + test/javax/imageio/plugins/png/ITXtTest.java Changeset: c267a33e76b0 Author: bae Date: 2011-01-10 20:08 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 6782079: PNG: reading metadata may cause OOM on truncated images. Reviewed-by: igor, prr Contributed-by: Martin von Gagern ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java + test/javax/imageio/plugins/png/ItxtUtf8Test.java From ahughes at redhat.com Mon Jan 10 12:14:01 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Mon, 10 Jan 2011 20:14:01 +0000 Subject: Request to backport changeset 3a9d06af8830 In-Reply-To: <20101223220710.GA9527@redhat.com> References: <20101223192809.GE6300@redhat.com> <4D13C173.9040609@oracle.com> <20101223220710.GA9527@redhat.com> Message-ID: <20110110201401.GG13053@rivendell.middle-earth.co.uk> On 17:07 Thu 23 Dec , Deepak Bhole wrote: > * Joe Darcy [2010-12-23 16:40]: > > On 12/23/2010 11:28 AM, Deepak Bhole wrote: > > >Hi, > > > > > >I'd like to request a backport of the following changeset: > > > > > >changeset: 770:3a9d06af8830 > > >user: bae > > >date: Sat Nov 01 20:42:18 2008 +0300 > > >summary: 6541476: PNG imageio plugin incorrectly handles iTXt chunk > > > > > >It addresses errors caused due to incorrect iTXt chunk handling (e.g. > > >when it contains non-ascii/UTF8 data). > > > > > >Thanks, > > >Deepak > > > > Hi Deepak. > > > > Looking over the files, it seems to me that > > > > 6782079: PNG: reading metadata may cause OOM on truncated images. > > > > should also be backported at the same time. I'd be open to both > > 6541476 and 6782079 being backported (along with a Sun -> Oracle > > copyright update). > > > > Hi Joe, > > I was just trying to keep the backports to the minimum thats all. I am > completely fine with porting 6782079 as well as it certainly seems like a > good-to-have fix! > > Cheers, > Deepak > > > -Joe I've committed these on Deepak's behalf as he does not yet have commit access: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From dbhole at redhat.com Mon Jan 10 12:16:15 2011 From: dbhole at redhat.com (Deepak Bhole) Date: Mon, 10 Jan 2011 15:16:15 -0500 Subject: Request to backport changeset 3a9d06af8830 In-Reply-To: <20110110201401.GG13053@rivendell.middle-earth.co.uk> References: <20101223192809.GE6300@redhat.com> <4D13C173.9040609@oracle.com> <20101223220710.GA9527@redhat.com> <20110110201401.GG13053@rivendell.middle-earth.co.uk> Message-ID: <20110110201614.GG13897@redhat.com> * Dr Andrew John Hughes [2011-01-10 15:14]: > On 17:07 Thu 23 Dec , Deepak Bhole wrote: > > * Joe Darcy [2010-12-23 16:40]: > > > On 12/23/2010 11:28 AM, Deepak Bhole wrote: > > > >Hi, > > > > > > > >I'd like to request a backport of the following changeset: > > > > > > > >changeset: 770:3a9d06af8830 > > > >user: bae > > > >date: Sat Nov 01 20:42:18 2008 +0300 > > > >summary: 6541476: PNG imageio plugin incorrectly handles iTXt chunk > > > > > > > >It addresses errors caused due to incorrect iTXt chunk handling (e.g. > > > >when it contains non-ascii/UTF8 data). > > > > > > > >Thanks, > > > >Deepak > > > > > > Hi Deepak. > > > > > > Looking over the files, it seems to me that > > > > > > 6782079: PNG: reading metadata may cause OOM on truncated images. > > > > > > should also be backported at the same time. I'd be open to both > > > 6541476 and 6782079 being backported (along with a Sun -> Oracle > > > copyright update). > > > > > > > Hi Joe, > > > > I was just trying to keep the backports to the minimum thats all. I am > > completely fine with porting 6782079 as well as it certainly seems like a > > good-to-have fix! > > > > Cheers, > > Deepak > > > > > -Joe > > I've committed these on Deepak's behalf as he does not yet have commit access: > Thanks Andrew! Cheers, Deepak > http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d > http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and IcedTea > http://www.gnu.org/software/classpath > http://icedtea.classpath.org > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Mon Jan 10 12:22:05 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 10 Jan 2011 12:22:05 -0800 Subject: Request to backport changeset 3a9d06af8830 In-Reply-To: <20110110201401.GG13053@rivendell.middle-earth.co.uk> References: <20101223192809.GE6300@redhat.com> <4D13C173.9040609@oracle.com> <20101223220710.GA9527@redhat.com> <20110110201401.GG13053@rivendell.middle-earth.co.uk> Message-ID: <4D2B6A6D.6000006@oracle.com> On 1/10/2011 12:14 PM, Dr Andrew John Hughes wrote: > On 17:07 Thu 23 Dec , Deepak Bhole wrote: >> * Joe Darcy [2010-12-23 16:40]: >>> On 12/23/2010 11:28 AM, Deepak Bhole wrote: >>>> Hi, >>>> >>>> I'd like to request a backport of the following changeset: >>>> >>>> changeset: 770:3a9d06af8830 >>>> user: bae >>>> date: Sat Nov 01 20:42:18 2008 +0300 >>>> summary: 6541476: PNG imageio plugin incorrectly handles iTXt chunk >>>> >>>> It addresses errors caused due to incorrect iTXt chunk handling (e.g. >>>> when it contains non-ascii/UTF8 data). >>>> >>>> Thanks, >>>> Deepak >>> Hi Deepak. >>> >>> Looking over the files, it seems to me that >>> >>> 6782079: PNG: reading metadata may cause OOM on truncated images. >>> >>> should also be backported at the same time. I'd be open to both >>> 6541476 and 6782079 being backported (along with a Sun -> Oracle >>> copyright update). >>> >> Hi Joe, >> >> I was just trying to keep the backports to the minimum thats all. I am >> completely fine with porting 6782079 as well as it certainly seems like a >> good-to-have fix! >> >> Cheers, >> Deepak >> >>> -Joe > I've committed these on Deepak's behalf as he does not yet have commit access: > > http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d > http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 Acknowledged; thanks, -Joe From ahughes at redhat.com Mon Jan 10 12:24:27 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Mon, 10 Jan 2011 20:24:27 +0000 Subject: [PING] Re: About time for b21? In-Reply-To: <4D2B5D76.70604@oracle.com> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> Message-ID: <20110110202427.GJ13053@rivendell.middle-earth.co.uk> On 11:26 Mon 10 Jan , Joe Darcy wrote: snip... > Hello. > > Since you haven't run into any issues with having 7002666 in IcedTea6 > 1.9, I'm satisfied to have it this build of OpenJDK 6, which should > bring b21 to a close! > > -Joe I've pushed 7002666: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee along with two PNG backports that were approved for Deepak Bhole some time ago but were never done: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 (copyright headers updated appropriately). Let's get b21 out the door! :-) -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Mon Jan 10 12:28:29 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 10 Jan 2011 12:28:29 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <20110110202427.GJ13053@rivendell.middle-earth.co.uk> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> Message-ID: <4D2B6BED.3080505@oracle.com> On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: > On 11:26 Mon 10 Jan , Joe Darcy wrote: > > snip... > >> Hello. >> >> Since you haven't run into any issues with having 7002666 in IcedTea6 >> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should >> bring b21 to a close! >> >> -Joe > I've pushed 7002666: > > http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee > > along with two PNG backports that were approved for Deepak Bhole some time > ago but were never done: > > http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d > http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 > > (copyright headers updated appropriately). > > Let's get b21 out the door! :-) Agreed! Later this week, I'll go through my pre-promotion build and test cycle. -Joe From ahughes at redhat.com Mon Jan 10 12:22:37 2011 From: ahughes at redhat.com (ahughes at redhat.com) Date: Mon, 10 Jan 2011 20:22:37 +0000 Subject: hg: jdk6/jdk6/hotspot: 7002666: eclipse CDT projects crash with compressed oops Message-ID: <20110110202240.5EA2247B23@hg.openjdk.java.net> Changeset: 499d2ae376ee Author: never Date: 2010-12-01 10:16 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee 7002666: eclipse CDT projects crash with compressed oops Reviewed-by: kvn, twisti ! src/share/vm/opto/memnode.cpp + test/compiler/7002666/Test7002666.java From johnsonlaucn at gmail.com Mon Jan 10 15:56:07 2011 From: johnsonlaucn at gmail.com (Johnson Lau) Date: Tue, 11 Jan 2011 07:56:07 +0800 Subject: OpenJDK 6 may stop builds on CP936 Mac & Linux In-Reply-To: <4D279A4D.2000105@oracle.com> References: <4D1E1DF6.2060401@gmail.com> <4D220802.7090601@oracle.com> <89BE5DE5-C126-49AB-B4F8-107D59B267BF@oracle.com> <4D279A4D.2000105@oracle.com> Message-ID: <4D2B9C97.2030308@gmail.com> Found the original bug id & changeset id. Bug ID: #6501543 Username can have non-alphanumeric characters http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6501543 Changeset: 425096dc0fc8. http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/425096dc0fc8 Thanks. -Johnson ? 11-1-8 ??6:57, Joe Darcy ??: > If the JDK 7 bug id of the change is provided, I can take a look at > that for back porting to OpenJDK 6. > > -Joe > > Kelly O'Hair wrote: >> Phil has a point, I'm not sure how valid a jdk build is with a non-C >> locale. >> Using LANG=C is advised. >> >> However, I have no objection to this change being made by someone. >> The %b is a locale specific value and really should be avoided. >> >> -kto >> >> On Jan 3, 2011, at 9:31 AM, Phil Race wrote: >> >>> Whilst I don't know the specifics of this issue the Openjdk builds >>> require >>> that you use the 'C' psuedo-locale for builds and that the sanity >>> check >>> will complain and point out that build failures are possible for >>> other locales. >>> So this would be "not a bug", or a bug in the 'date' program if its >>> ignoring >>> your locale setting of 'C'. >>> >>> -phil. >>> >>> On 12/31/2010 10:16 AM, Johnson Lau wrote: >>>> Hi, >>>> >>>> I've just found that OpenJDK 6 may stop builds on CP936 Mac & Linux. >>>> Checked the latest repo and confirmed that the bug still exists. >>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/3a8a8b5f1612/make/common/shared/Defs.gmk >>>> >>>> Line #275 >>>> >>>> Currently, FULL_VERSION uses a format with local abbreviated month >>>> name (%b). >>>> On these platforms, date will produce a string in local language >>>> with space >>>> (i.e. [_1?] which indicates January), >>>> which breaks the builds. >>>> >>>> This is fixed in OpenJDK 7 already so I brought the patch into JDK 6. >>>> Hope someone can merge this. >>>> >>>> Thanks, >>>> Johnson Lau >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110111/13e650cc/attachment-0001.html From joe.darcy at oracle.com Mon Jan 10 16:19:15 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 10 Jan 2011 16:19:15 -0800 Subject: OpenJDK 6 may stop builds on CP936 Mac & Linux In-Reply-To: <4D2B9C97.2030308@gmail.com> References: <4D1E1DF6.2060401@gmail.com> <4D220802.7090601@oracle.com> <89BE5DE5-C126-49AB-B4F8-107D59B267BF@oracle.com> <4D279A4D.2000105@oracle.com> <4D2B9C97.2030308@gmail.com> Message-ID: <4D2BA203.6050906@oracle.com> Hi Johnson. Thanks for the bug archeology. I approve 6501543 being backported to OpenJDK 6. -Joe Johnson Lau wrote: > Found the original bug id & changeset id. > > Bug ID: #6501543 Username can have non-alphanumeric characters > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6501543 > > Changeset: 425096dc0fc8. > http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/425096dc0fc8 > > Thanks. > > -Johnson > > ? 11-1-8 ??6:57, Joe Darcy ??: >> If the JDK 7 bug id of the change is provided, I can take a look at >> that for back porting to OpenJDK 6. >> >> -Joe >> >> Kelly O'Hair wrote: >>> Phil has a point, I'm not sure how valid a jdk build is with a non-C >>> locale. >>> Using LANG=C is advised. >>> >>> However, I have no objection to this change being made by someone. >>> The %b is a locale specific value and really should be avoided. >>> >>> -kto >>> >>> On Jan 3, 2011, at 9:31 AM, Phil Race wrote: >>> >>>> Whilst I don't know the specifics of this issue the Openjdk builds >>>> require >>>> that you use the 'C' psuedo-locale for builds and that the sanity >>>> check >>>> will complain and point out that build failures are possible for >>>> other locales. >>>> So this would be "not a bug", or a bug in the 'date' program if its >>>> ignoring >>>> your locale setting of 'C'. >>>> >>>> -phil. >>>> >>>> On 12/31/2010 10:16 AM, Johnson Lau wrote: >>>>> Hi, >>>>> >>>>> I've just found that OpenJDK 6 may stop builds on CP936 Mac & Linux. >>>>> Checked the latest repo and confirmed that the bug still exists. >>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/3a8a8b5f1612/make/common/shared/Defs.gmk >>>>> >>>>> Line #275 >>>>> >>>>> Currently, FULL_VERSION uses a format with local abbreviated month >>>>> name (%b). >>>>> On these platforms, date will produce a string in local language >>>>> with space >>>>> (i.e. [_1?] which indicates January), >>>>> which breaks the builds. >>>>> >>>>> This is fixed in OpenJDK 7 already so I brought the patch into JDK 6. >>>>> Hope someone can merge this. >>>>> >>>>> Thanks, >>>>> Johnson Lau >>>> >>> >> From t.dt.aanderson at gmail.com Tue Jan 11 02:29:42 2011 From: t.dt.aanderson at gmail.com (Thomas Anderson) Date: Tue, 11 Jan 2011 18:29:42 +0800 Subject: Error when compiling corba orb files Message-ID: I download openjdk 6 source from http://download.java.net/openjdk/jdk6/ and follow README-builds.html to build jdk from source. But the make result shows the error as below: # Running javac: /usr/lib/jvm/java-6-openjdk/bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/home/clin/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -jar /home/clin/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -XDignore.symbol.file=true -source 1.5 -target 5 -encoding ascii -classpath /usr/lib/jvm/java-6-openjdk/lib/tools.jar -sourcepath /home/clin/openjdk6/build/linux-i586/corba/gensrc:../../../../../../src/solaris/classes:../../../../../../src/share/classes -d /home/clin/openjdk6/build/linux-i586/corba/classes @/home/clin/openjdk6/build/linux-i586/corba/tmp/sun/com.sun.corba.se.impl.corespi/.classes.list ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java:449: cannot find symbol symbol : method compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) location: class com.sun.corba.se.impl.orbutil.ObjectUtility ObjectUtility.compactObjectToString(actions) + ")" ; ^ ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java:536: cannot find symbol symbol : method compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) location: class com.sun.corba.se.impl.orbutil.ObjectUtility ObjectUtility.compactObjectToString(op) + ")" ; ^ ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/ParserImplBase.java:128: cannot find symbol symbol : method compactObjectToString(java.lang.Object) location: class com.sun.corba.se.impl.orbutil.ObjectUtility ObjectUtility.compactObjectToString(value) ) ; ^ Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. The command used to build the source is exactly the same as described in README-builds.html#debian What might be the root cause or how to solve this problem? Environment: GNU Make 3.81, GNU/ Linux Debian (kernel 2.6.35.4), gcc (Debian 4.4.5-8) 4.4.5 Thanks. From johnsonlaucn at gmail.com Tue Jan 11 06:41:50 2011 From: johnsonlaucn at gmail.com (Johnson Lau) Date: Tue, 11 Jan 2011 22:41:50 +0800 Subject: Supports fonts with Apple Platform Name Tags Message-ID: <4D2C6C2E.3000001@gmail.com> Hi, Some fonts shipping with Mac, like STHeiti / Hiragino series, contains tags with only Mac Platform ID (=1), which causes them wrongly treated as invalid format by OpenJDK because OpenJDK recognizes name tags with Platform ID of MS_PLATFORM_ID (=3) ONLY currently. I added support for MAC_PLATFORM_ID and other possible values to make it work in both OpenJDK 6 & 7. Also, there is a patch backporting OpenType font support for OpenJDK 6. I post the patches here and hope someone can review them. Should I request RFEs in JDK bug database at first? Johnson -------------- next part -------------- A non-text attachment was scrubbed... Name: jdk6-apple-platform-ttf-and-opentype.tar.gz Type: application/x-gzip Size: 8105 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110111/4a500629/attachment-0002.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: jdk7-apple-platform-ttf.patch.tar.gz Type: application/x-gzip Size: 7170 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110111/4a500629/attachment-0003.bin From ahughes at redhat.com Tue Jan 11 06:54:48 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Tue, 11 Jan 2011 14:54:48 +0000 Subject: Supports fonts with Apple Platform Name Tags In-Reply-To: <4D2C6C2E.3000001@gmail.com> References: <4D2C6C2E.3000001@gmail.com> Message-ID: <20110111145448.GE28602@rivendell.middle-earth.co.uk> On 22:41 Tue 11 Jan , Johnson Lau wrote: > Hi, > > Some fonts shipping with Mac, like STHeiti / Hiragino series, contains > tags with only Mac Platform ID (=1), which causes them wrongly treated > as invalid format by OpenJDK because OpenJDK recognizes name tags with > Platform ID of MS_PLATFORM_ID (=3) ONLY currently. > > I added support for MAC_PLATFORM_ID and other possible values to make it > work in both OpenJDK 6 & 7. > > Also, there is a patch backporting OpenType font support for OpenJDK 6. > If you mean: changeset: 406:acb763ebef95 user: prr date: Thu May 27 08:53:45 2010 -0700 summary: 6954424: Support OpenType/CFF fonts in JDK 7 it's already in OpenJDK6. > I post the patches here and hope someone can review them. > Should I request RFEs in JDK bug database at first? > > Johnson -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From johnsonlaucn at gmail.com Tue Jan 11 07:18:28 2011 From: johnsonlaucn at gmail.com (Johnson Lau) Date: Tue, 11 Jan 2011 23:18:28 +0800 Subject: Supports fonts with Apple Platform Name Tags In-Reply-To: <20110111145448.GE28602@rivendell.middle-earth.co.uk> References: <4D2C6C2E.3000001@gmail.com> <20110111145448.GE28602@rivendell.middle-earth.co.uk> Message-ID: <4D2C74C4.3030003@gmail.com> ? 11-1-11 ??10:54, Dr Andrew John Hughes ??: > On 22:41 Tue 11 Jan , Johnson Lau wrote: >> Hi, >> >> Some fonts shipping with Mac, like STHeiti / Hiragino series, contains >> tags with only Mac Platform ID (=1), which causes them wrongly treated >> as invalid format by OpenJDK because OpenJDK recognizes name tags with >> Platform ID of MS_PLATFORM_ID (=3) ONLY currently. >> >> I added support for MAC_PLATFORM_ID and other possible values to make it >> work in both OpenJDK 6& 7. >> >> Also, there is a patch backporting OpenType font support for OpenJDK 6. >> > > If you mean: > > changeset: 406:acb763ebef95 > user: prr > date: Thu May 27 08:53:45 2010 -0700 > summary: 6954424: Support OpenType/CFF fonts in JDK 7 > > it's already in OpenJDK6. Sorry for the silly mistake. Just checked with my local copy. It seems that I worked on an out-dated b20 copy and the file has been changed since then. Updated patches attached. -Johnson -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jdk6-apple-platform-ttf.patch Url: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110111/0e7b2e26/attachment-0002.ksh -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jdk7-apple-platform-ttf.patch Url: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110111/0e7b2e26/attachment-0003.ksh From kelly.ohair at oracle.com Tue Jan 11 08:02:17 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 11 Jan 2011 08:02:17 -0800 Subject: Error when compiling corba orb files In-Reply-To: References: Message-ID: <4BCFC592-5821-42C6-AAA6-502FAD8CB1EE@oracle.com> Someone reported this a while back on Fedora 12, I think the recommendation was to try Fedora 14, but I don't know what the results were. -kto On Jan 11, 2011, at 2:29 AM, Thomas Anderson wrote: > I download openjdk 6 source from > http://download.java.net/openjdk/jdk6/ and follow README-builds.html > to build jdk from source. But the make result shows the error as > below: > > # Running javac: > /usr/lib/jvm/java-6-openjdk/bin/java -client -Xmx896m -Xms128m > -XX:PermSize=32m -XX:MaxPermSize=160m > -Xbootclasspath/p:/home/clin/openjdk6/build/linux-i586/langtools/ > dist/bootstrap/lib/javac.jar > -jar /home/clin/openjdk6/build/linux-i586/langtools/dist/bootstrap/ > lib/javac.jar > -XDignore.symbol.file=true -source 1.5 -target 5 -encoding ascii > -classpath /usr/lib/jvm/java-6-openjdk/lib/tools.jar -sourcepath > /home/clin/openjdk6/build/linux-i586/corba/gensrc:../../../../../../ > src/solaris/classes:../../../../../../src/share/classes > -d /home/clin/openjdk6/build/linux-i586/corba/classes > @/home/clin/openjdk6/build/linux-i586/corba/tmp/sun/ > com.sun.corba.se.impl.corespi/.classes.list > ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/ > OperationFactory.java:449: > cannot find symbol > symbol : method > compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) > location: class com.sun.corba.se.impl.orbutil.ObjectUtility > ObjectUtility.compactObjectToString(actions) + ")" ; > ^ > ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/ > OperationFactory.java:536: > cannot find symbol > symbol : method > compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) > location: class com.sun.corba.se.impl.orbutil.ObjectUtility > ObjectUtility.compactObjectToString(op) + ")" ; > ^ > ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/ > ParserImplBase.java:128: > cannot find symbol > symbol : method compactObjectToString(java.lang.Object) > location: class com.sun.corba.se.impl.orbutil.ObjectUtility > ObjectUtility.compactObjectToString(value) ) ; > ^ > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > The command used to build the source is exactly the same as described > in README-builds.html#debian > > What might be the root cause or how to solve this problem? > > Environment: GNU Make 3.81, GNU/ Linux Debian (kernel 2.6.35.4), gcc > (Debian 4.4.5-8) 4.4.5 > > Thanks. From joe.darcy at oracle.com Tue Jan 11 09:43:03 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 11 Jan 2011 09:43:03 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <4D2B6BED.3080505@oracle.com> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> Message-ID: <4D2C96A7.4090209@oracle.com> Joe Darcy wrote: > On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: >> On 11:26 Mon 10 Jan , Joe Darcy wrote: >> >> snip... >> >>> Hello. >>> >>> Since you haven't run into any issues with having 7002666 in IcedTea6 >>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should >>> bring b21 to a close! >>> >>> -Joe >> I've pushed 7002666: >> >> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee >> >> along with two PNG backports that were approved for Deepak Bhole some >> time >> ago but were never done: >> >> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d >> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 >> >> (copyright headers updated appropriately). >> >> Let's get b21 out the door! :-) > > Agreed! Later this week, I'll go through my pre-promotion build and > test cycle. > > -Joe When running the HotSpot regression tests, I see two failures: Compilation failed: Compilation failed * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is zero after GC which is incorrect Execution failed: exit code 127 * runtime/6929067/Test6929067.sh : Stack guard pages should be removed when thread is detached The first is due to a typo in the test case; I approve the backport of 6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo" http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 to fix this. The second test seems to make platform assumptions that aren't always true, but after some looking around I don't see an existing fix in the HotSpot repos. At least the first should be fixed before b21 promotes. -Joe From philip.race at oracle.com Tue Jan 11 10:11:28 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 11 Jan 2011 10:11:28 -0800 Subject: Supports fonts with Apple Platform Name Tags In-Reply-To: <4D2C74C4.3030003@gmail.com> References: <4D2C6C2E.3000001@gmail.com> <20110111145448.GE28602@rivendell.middle-earth.co.uk> <4D2C74C4.3030003@gmail.com> Message-ID: <4D2C9D50.2090001@oracle.com> Some comments : 1) I don't see your name as having signed the SCA. Patches cannot be accepted until you do. 2) Read the open jdk developers guide on how to submit patches. 3) Once you've done that, discuss this enhancement first on 2d-dev at openjdk.java.net jdk6-dev is a general alias to do with the jdk7-based backport to create openjdk6 New features should start in the appropriate technology group of the main line project For this specific proposal there may be other considerations 1) I'm a bit surprised how large this patch is. I have a version of the code that I modified for JavaFX which needs to run on Mac and accepts mac names. I don't remember it as needing more than an extremely minimal change and I was at some point going to pull this back into openjdk anyway. 2) There's a mac port project underway and it'll use some apple donated code. I'd want to look at both of those first. -phil. On 1/11/2011 7:18 AM, Johnson Lau wrote: > > ? 11-1-11 ??10:54, Dr Andrew John Hughes ??: >> On 22:41 Tue 11 Jan , Johnson Lau wrote: >>> Hi, >>> >>> Some fonts shipping with Mac, like STHeiti / Hiragino series, contains >>> tags with only Mac Platform ID (=1), which causes them wrongly treated >>> as invalid format by OpenJDK because OpenJDK recognizes name tags with >>> Platform ID of MS_PLATFORM_ID (=3) ONLY currently. >>> >>> I added support for MAC_PLATFORM_ID and other possible values to >>> make it >>> work in both OpenJDK 6& 7. >>> >>> Also, there is a patch backporting OpenType font support for OpenJDK 6. >>> >> >> If you mean: >> >> changeset: 406:acb763ebef95 >> user: prr >> date: Thu May 27 08:53:45 2010 -0700 >> summary: 6954424: Support OpenType/CFF fonts in JDK 7 >> >> it's already in OpenJDK6. > > Sorry for the silly mistake. > Just checked with my local copy. > It seems that I worked on an out-dated b20 copy and the file has been > changed since then. > Updated patches attached. > > -Johnson From ahughes at redhat.com Tue Jan 11 10:17:00 2011 From: ahughes at redhat.com (ahughes at redhat.com) Date: Tue, 11 Jan 2011 18:17:00 +0000 Subject: hg: jdk6/jdk6/hotspot: 6980392: TEST_BUG: gc/6581734/Test6581734.java has typo Message-ID: <20110111181703.993BF47B7B@hg.openjdk.java.net> Changeset: e760899a624f Author: kevinw Date: 2010-08-27 16:57 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/e760899a624f 6980392: TEST_BUG: gc/6581734/Test6581734.java has typo Summary: simple correction in testcase Reviewed-by: mchung ! test/gc/6581734/Test6581734.java From ahughes at redhat.com Tue Jan 11 10:19:00 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Tue, 11 Jan 2011 18:19:00 +0000 Subject: [PING] Re: About time for b21? In-Reply-To: <4D2C96A7.4090209@oracle.com> References: <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> Message-ID: <20110111181900.GK28602@rivendell.middle-earth.co.uk> On 09:43 Tue 11 Jan , Joe Darcy wrote: > Joe Darcy wrote: > > On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: > >> On 11:26 Mon 10 Jan , Joe Darcy wrote: > >> > >> snip... > >> > >>> Hello. > >>> > >>> Since you haven't run into any issues with having 7002666 in IcedTea6 > >>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should > >>> bring b21 to a close! > >>> > >>> -Joe > >> I've pushed 7002666: > >> > >> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee > >> > >> along with two PNG backports that were approved for Deepak Bhole some > >> time > >> ago but were never done: > >> > >> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d > >> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 > >> > >> (copyright headers updated appropriately). > >> > >> Let's get b21 out the door! :-) > > > > Agreed! Later this week, I'll go through my pre-promotion build and > > test cycle. > > > > -Joe > > When running the HotSpot regression tests, I see two failures: > > Compilation failed: Compilation failed > > * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is > zero after GC which is incorrect > > Execution failed: exit code 127 > > * runtime/6929067/Test6929067.sh : Stack guard pages should be > removed when thread is detached > > The first is due to a typo in the test case; I approve the backport of > 6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo" > http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 > to fix this. > > The second test seems to make platform assumptions that aren't always > true, but after some looking around I don't see an existing fix in the > HotSpot repos. > > At least the first should be fixed before b21 promotes. > Yes, both of these issues are fixed in IcedTea6, the first with the 6980392 that I've now pushed to OpenJDK6. I recall there was some discussion of a fix for the second with upstream, but I can't find it right now and Pavel (who found the bug and fixed it) is on vacation. > -Joe > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Tue Jan 11 11:36:01 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 11 Jan 2011 11:36:01 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <20110111181900.GK28602@rivendell.middle-earth.co.uk> References: <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> Message-ID: <4D2CB121.7030407@oracle.com> On 1/11/2011 10:19 AM, Dr Andrew John Hughes wrote: > On 09:43 Tue 11 Jan , Joe Darcy wrote: >> Joe Darcy wrote: >>> On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: >>>> On 11:26 Mon 10 Jan , Joe Darcy wrote: >>>> >>>> snip... >>>> >>>>> Hello. >>>>> >>>>> Since you haven't run into any issues with having 7002666 in IcedTea6 >>>>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should >>>>> bring b21 to a close! >>>>> >>>>> -Joe >>>> I've pushed 7002666: >>>> >>>> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee >>>> >>>> along with two PNG backports that were approved for Deepak Bhole some >>>> time >>>> ago but were never done: >>>> >>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d >>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 >>>> >>>> (copyright headers updated appropriately). >>>> >>>> Let's get b21 out the door! :-) >>> Agreed! Later this week, I'll go through my pre-promotion build and >>> test cycle. >>> >>> -Joe >> When running the HotSpot regression tests, I see two failures: >> >> Compilation failed: Compilation failed >> >> * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is >> zero after GC which is incorrect >> >> Execution failed: exit code 127 >> >> * runtime/6929067/Test6929067.sh : Stack guard pages should be >> removed when thread is detached >> >> The first is due to a typo in the test case; I approve the backport of >> 6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo" >> http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 >> to fix this. >> >> The second test seems to make platform assumptions that aren't always >> true, but after some looking around I don't see an existing fix in the >> HotSpot repos. >> >> At least the first should be fixed before b21 promotes. >> > Yes, both of these issues are fixed in IcedTea6, the first with the 6980392 > that I've now pushed to OpenJDK6. Thanks for doing the push. > I recall there was some discussion of a fix for the second with upstream, but > I can't find it right now and Pavel (who found the bug and fixed it) is on > vacation. > One Oracle bug for this test failure seems to be, 6945460 TEST_BUG: runtime/6929067/Test6929067.sh but it is not marked as fixed in any release. There was some discussion on IcedTea: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/011057.html and at least some on HotSpot: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010959.html http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-December/011329.html but I don't see a resolution. -Joe From ahughes at redhat.com Tue Jan 11 13:03:37 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Tue, 11 Jan 2011 21:03:37 +0000 Subject: [PING] Re: About time for b21? In-Reply-To: <4D2CB121.7030407@oracle.com> References: <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> Message-ID: <20110111210337.GR28602@rivendell.middle-earth.co.uk> On 11:36 Tue 11 Jan , Joe Darcy wrote: > On 1/11/2011 10:19 AM, Dr Andrew John Hughes wrote: > > On 09:43 Tue 11 Jan , Joe Darcy wrote: > >> Joe Darcy wrote: > >>> On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: > >>>> On 11:26 Mon 10 Jan , Joe Darcy wrote: > >>>> > >>>> snip... > >>>> > >>>>> Hello. > >>>>> > >>>>> Since you haven't run into any issues with having 7002666 in IcedTea6 > >>>>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should > >>>>> bring b21 to a close! > >>>>> > >>>>> -Joe > >>>> I've pushed 7002666: > >>>> > >>>> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee > >>>> > >>>> along with two PNG backports that were approved for Deepak Bhole some > >>>> time > >>>> ago but were never done: > >>>> > >>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d > >>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 > >>>> > >>>> (copyright headers updated appropriately). > >>>> > >>>> Let's get b21 out the door! :-) > >>> Agreed! Later this week, I'll go through my pre-promotion build and > >>> test cycle. > >>> > >>> -Joe > >> When running the HotSpot regression tests, I see two failures: > >> > >> Compilation failed: Compilation failed > >> > >> * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is > >> zero after GC which is incorrect > >> > >> Execution failed: exit code 127 > >> > >> * runtime/6929067/Test6929067.sh : Stack guard pages should be > >> removed when thread is detached > >> > >> The first is due to a typo in the test case; I approve the backport of > >> 6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo" > >> http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 > >> to fix this. > >> > >> The second test seems to make platform assumptions that aren't always > >> true, but after some looking around I don't see an existing fix in the > >> HotSpot repos. > >> > >> At least the first should be fixed before b21 promotes. > >> > > Yes, both of these issues are fixed in IcedTea6, the first with the 6980392 > > that I've now pushed to OpenJDK6. > > Thanks for doing the push. > > > I recall there was some discussion of a fix for the second with upstream, but > > I can't find it right now and Pavel (who found the bug and fixed it) is on > > vacation. > > > > One Oracle bug for this test failure seems to be, > > 6945460 TEST_BUG: runtime/6929067/Test6929067.sh > > but it is not marked as fixed in any release. > > There was some discussion on IcedTea: > > > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/011057.html > > and at least some on HotSpot: > > > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010959.html > > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-December/011329.html > > but I don't see a resolution. > Yes, these are all on the IcedTea mailing list. I recall some discussion on the HotSpot mailing lists but I can't find any. The patch is in IcedTea6 as patches/jtreg-6929067-fix.patch. As I said, Pavel will know more but isn't around to comment at the moment. > -Joe -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From t.dt.aanderson at gmail.com Wed Jan 12 02:24:28 2011 From: t.dt.aanderson at gmail.com (Thomas Anderson) Date: Wed, 12 Jan 2011 18:24:28 +0800 Subject: Error when compiling corba orb files In-Reply-To: <4BCFC592-5821-42C6-AAA6-502FAD8CB1EE@oracle.com> References: <4BCFC592-5821-42C6-AAA6-502FAD8CB1EE@oracle.com> Message-ID: I notice it seems because ObjectUtility.java is not yet compiled because `ls build/linux-i586/corba/classes/com/sun/corba/se/impl/orbutil/' only shows a folder existed. resources What is the right command to compile corba manually before calling to compile OperationFactory.java? Or any way to change the order of classes compilation? Thanks. On Wed, Jan 12, 2011 at 12:02 AM, Kelly O'Hair wrote: > Someone reported this a while back on Fedora 12, I think the recommendation > was > to try Fedora 14, but I don't know what the results were. > > -kto > > On Jan 11, 2011, at 2:29 AM, Thomas Anderson wrote: > >> I download openjdk 6 source from >> http://download.java.net/openjdk/jdk6/ and follow README-builds.html >> to build jdk from source. But the make result shows the error as >> below: >> >> # Running javac: >> /usr/lib/jvm/java-6-openjdk/bin/java -client -Xmx896m -Xms128m >> -XX:PermSize=32m -XX:MaxPermSize=160m >> >> -Xbootclasspath/p:/home/clin/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar >> -jar >> /home/clin/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar >> -XDignore.symbol.file=true -source 1.5 -target 5 -encoding ascii >> -classpath /usr/lib/jvm/java-6-openjdk/lib/tools.jar -sourcepath >> >> /home/clin/openjdk6/build/linux-i586/corba/gensrc:../../../../../../src/solaris/classes:../../../../../../src/share/classes >> -d /home/clin/openjdk6/build/linux-i586/corba/classes >> >> @/home/clin/openjdk6/build/linux-i586/corba/tmp/sun/com.sun.corba.se.impl.corespi/.classes.list >> >> ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java:449: >> cannot find symbol >> symbol ?: method >> compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) >> location: class com.sun.corba.se.impl.orbutil.ObjectUtility >> ? ? ? ? ? ? ? ObjectUtility.compactObjectToString(actions) + ")" ; >> ? ? ? ? ? ? ? ? ? ? ? ? ? ?^ >> >> ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java:536: >> cannot find symbol >> symbol ?: method >> compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) >> location: class com.sun.corba.se.impl.orbutil.ObjectUtility >> ? ? ? ? ? ? ? ObjectUtility.compactObjectToString(op) + ")" ; >> ? ? ? ? ? ? ? ? ? ? ? ? ? ?^ >> >> ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/ParserImplBase.java:128: >> cannot find symbol >> symbol ?: method compactObjectToString(java.lang.Object) >> location: class com.sun.corba.se.impl.orbutil.ObjectUtility >> ? ? ? ? ? ? ? ? ? ObjectUtility.compactObjectToString(value) ) ; >> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?^ >> Note: Some input files use unchecked or unsafe operations. >> Note: Recompile with -Xlint:unchecked for details. >> >> The command used to build the source is exactly the same as described >> in README-builds.html#debian >> >> What might be the root cause or how to solve this problem? >> >> Environment: GNU Make 3.81, GNU/ Linux Debian (kernel 2.6.35.4), gcc >> (Debian 4.4.5-8) 4.4.5 >> >> Thanks. > > From shea at shealevy.com Wed Jan 12 05:40:01 2011 From: shea at shealevy.com (Shea Levy) Date: Wed, 12 Jan 2011 08:40:01 -0500 Subject: Error when compiling corba orb files In-Reply-To: References: <4BCFC592-5821-42C6-AAA6-502FAD8CB1EE@oracle.com> Message-ID: <4D2DAF31.6000703@shealevy.com> I had the same error when I was compiling OpenJDK6 b20. I think the Oracle JDK 6 update 21 or 22 might have dropped the compactObjectToString method from the ObjectUtility class, since recompiling with JDK 6 update 20 as my bootstrap jdk solved this problem. Cheers, Shea On 1/12/11 5:24 AM, Thomas Anderson wrote: > I notice it seems because ObjectUtility.java is not yet compiled > because `ls build/linux-i586/corba/classes/com/sun/corba/se/impl/orbutil/' > only shows a folder existed. > > resources > > What is the right command to compile corba manually before calling to > compile OperationFactory.java? Or any way to change the order of > classes compilation? > > Thanks. > > On Wed, Jan 12, 2011 at 12:02 AM, Kelly O'Hair wrote: >> Someone reported this a while back on Fedora 12, I think the recommendation >> was >> to try Fedora 14, but I don't know what the results were. >> >> -kto >> >> On Jan 11, 2011, at 2:29 AM, Thomas Anderson wrote: >> >>> I download openjdk 6 source from >>> http://download.java.net/openjdk/jdk6/ and follow README-builds.html >>> to build jdk from source. But the make result shows the error as >>> below: >>> >>> # Running javac: >>> /usr/lib/jvm/java-6-openjdk/bin/java -client -Xmx896m -Xms128m >>> -XX:PermSize=32m -XX:MaxPermSize=160m >>> >>> -Xbootclasspath/p:/home/clin/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar >>> -jar >>> /home/clin/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar >>> -XDignore.symbol.file=true -source 1.5 -target 5 -encoding ascii >>> -classpath /usr/lib/jvm/java-6-openjdk/lib/tools.jar -sourcepath >>> >>> /home/clin/openjdk6/build/linux-i586/corba/gensrc:../../../../../../src/solaris/classes:../../../../../../src/share/classes >>> -d /home/clin/openjdk6/build/linux-i586/corba/classes >>> >>> @/home/clin/openjdk6/build/linux-i586/corba/tmp/sun/com.sun.corba.se.impl.corespi/.classes.list >>> >>> ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java:449: >>> cannot find symbol >>> symbol : method >>> compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) >>> location: class com.sun.corba.se.impl.orbutil.ObjectUtility >>> ObjectUtility.compactObjectToString(actions) + ")" ; >>> ^ >>> >>> ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java:536: >>> cannot find symbol >>> symbol : method >>> compactObjectToString(com.sun.corba.se.spi.orb.Operation[]) >>> location: class com.sun.corba.se.impl.orbutil.ObjectUtility >>> ObjectUtility.compactObjectToString(op) + ")" ; >>> ^ >>> >>> ../../../../../../src/share/classes/com/sun/corba/se/spi/orb/ParserImplBase.java:128: >>> cannot find symbol >>> symbol : method compactObjectToString(java.lang.Object) >>> location: class com.sun.corba.se.impl.orbutil.ObjectUtility >>> ObjectUtility.compactObjectToString(value) ) ; >>> ^ >>> Note: Some input files use unchecked or unsafe operations. >>> Note: Recompile with -Xlint:unchecked for details. >>> >>> The command used to build the source is exactly the same as described >>> in README-builds.html#debian >>> >>> What might be the root cause or how to solve this problem? >>> >>> Environment: GNU Make 3.81, GNU/ Linux Debian (kernel 2.6.35.4), gcc >>> (Debian 4.4.5-8) 4.4.5 >>> >>> Thanks. >> From joe.darcy at oracle.com Wed Jan 12 16:20:59 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 12 Jan 2011 16:20:59 -0800 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4CF47CF9.1020005@oracle.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> Message-ID: <4D2E456B.9080208@oracle.com> Joe Darcy wrote: > On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: >> Phil Race wrote: >>> Pavel, >>> >>> The font implementation and tests are 2D. Not AWT. Don't get thrown by >>> package names. >> Ah sorry, you are right, of course. >>> I was a bit curious about the real reason for this failure. >>> I wrote this test a couple of years ago and its never failed before. >>> I don't see it failing on any 6-open build. >>> I see it failing only in JDK 7 from b90. That seems to be due to >>> HS18b03 >>> fix >>> 6938627: Make temporary directory use property java.io.tmpdir when >>> specified >> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses >> some backports from OpenJDK 7 (from the log files I can only infer that >> this bug first appeared in IcedTea6 when the hs19 were set as default >> HotSpot on 2010-10-19). Is it still possible to push the test correction >> to OpenJDK 6 too, or only to OpenJDK 7? >> >> Also I'll need a bug id please. >> > > Sorry for the belated reply, please use > > 7003327 Correct test awt/FontClass/CreateFont/DeleteFont > > Approved for OpenJDK 6. > > -Joe Hello. If this can be pushed in the next day or two, I'm open to having this bug fix in b21. Thanks, -Joe From coleen.phillimore at oracle.com Wed Jan 12 16:55:51 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Wed, 12 Jan 2011 19:55:51 -0500 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4D2E456B.9080208@oracle.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> Message-ID: <4D2E4D97.9090101@oracle.com> I have to read this bug and reread this thread, but I just backed out the change for 6938627 which I believe was the cause of this bug too. Hotspot will not use java.io.tmpdir to get a temporary directory, it will use the system temporary directory. There was a JDK change in jdk 7 that also has to be refixed that Alan's going to do (bug 6950927: Testcase failure sun/management/jmxremote/bootstrap/JvmstatCountersTest.java) See bug 7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined Now, I've read your bug 7003327 - you can filter hsperfdata but it won't be there anymore. Coleen On 1/12/2011 7:20 PM, Joe Darcy wrote: > Joe Darcy wrote: >> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: >>> Phil Race wrote: >>>> Pavel, >>>> >>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by >>>> package names. >>> Ah sorry, you are right, of course. >>>> I was a bit curious about the real reason for this failure. >>>> I wrote this test a couple of years ago and its never failed before. >>>> I don't see it failing on any 6-open build. >>>> I see it failing only in JDK 7 from b90. That seems to be due to >>>> HS18b03 >>>> fix >>>> 6938627: Make temporary directory use property java.io.tmpdir when >>>> specified >>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses >>> some backports from OpenJDK 7 (from the log files I can only infer that >>> this bug first appeared in IcedTea6 when the hs19 were set as default >>> HotSpot on 2010-10-19). Is it still possible to push the test >>> correction >>> to OpenJDK 6 too, or only to OpenJDK 7? >>> >>> Also I'll need a bug id please. >>> >> >> Sorry for the belated reply, please use >> >> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont >> >> Approved for OpenJDK 6. >> >> -Joe > > Hello. > > If this can be pushed in the next day or two, I'm open to having this > bug fix in b21. > > Thanks, > > -Joe From joe.darcy at oracle.com Wed Jan 12 19:07:49 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 12 Jan 2011 19:07:49 -0800 Subject: hg: jdk6/jdk6/langtools: 7008433: Minor copyright changes In-Reply-To: <20110103190234.65AB44793B@hg.openjdk.java.net> References: <20110103190234.65AB44793B@hg.openjdk.java.net> Message-ID: <4D2E6C85.10006@oracle.com> jim.holmlund at sun.com wrote: > Changeset: a9479f61cd7e > Author: jjh > Date: 2011-01-03 10:38 -0800 > URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/a9479f61cd7e > > 7008433: Minor copyright changes > Summary: Changed Sun to Oracle, etc. > Reviewed-by: ohair > > ! make/netbeans/langtools/build.xml > ! make/netbeans/langtools/nbproject/project.xml > ! make/netbeans/langtools/nbproject/standard-context-menu-items.ent > ! make/netbeans/langtools/nbproject/standard-ide-actions.ent > ! make/tools/SelectTool/SelectToolTask.java > ! test/tools/javac/6889255/T6889255.java > ! test/tools/javac/T6595666.java > ! test/tools/javac/policy/test3/Test.java > > Hello. Per the OpenJDK 6 process [1], non-security requests should have on-list approval before being integrated. That doesn't seem to have happened in this case, but I give the request retroactive approval. Cheers, -Joe [1] http://openjdk.java.net/projects/jdk6/ From ahughes at redhat.com Thu Jan 13 06:09:12 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Thu, 13 Jan 2011 14:09:12 +0000 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4D2E4D97.9090101@oracle.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> Message-ID: <20110113140911.GA4081@rivendell.middle-earth.co.uk> On 19:55 Wed 12 Jan , Coleen Phillimore wrote: > > I have to read this bug and reread this thread, but I just backed out > the change for 6938627 which I believe was the cause of this bug too. > Hotspot will not use java.io.tmpdir to get a temporary directory, it > will use the system temporary directory. There was a JDK change in jdk > 7 that also has to be refixed that Alan's going to do (bug 6950927: > Testcase failure > sun/management/jmxremote/bootstrap/JvmstatCountersTest.java) > > See bug 7009828: Fix for 6938627 breaks visualvm monitoring when > -Djava.io.tmpdir is defined > > Now, I've read your bug 7003327 - you can filter hsperfdata but it > won't be there anymore. > Well, it will if: changeset: 1999:34d64ad817f4 tag: tip user: coleenp date: Wed Jan 12 13:59:18 2011 -0800 summary: 7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined is backported to OpenJDK6. Joe, should we do this? It only seems to be in the hotspot-rt tree so far. > Coleen > > On 1/12/2011 7:20 PM, Joe Darcy wrote: > > Joe Darcy wrote: > >> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: > >>> Phil Race wrote: > >>>> Pavel, > >>>> > >>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by > >>>> package names. > >>> Ah sorry, you are right, of course. > >>>> I was a bit curious about the real reason for this failure. > >>>> I wrote this test a couple of years ago and its never failed before. > >>>> I don't see it failing on any 6-open build. > >>>> I see it failing only in JDK 7 from b90. That seems to be due to > >>>> HS18b03 > >>>> fix > >>>> 6938627: Make temporary directory use property java.io.tmpdir when > >>>> specified > >>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses > >>> some backports from OpenJDK 7 (from the log files I can only infer that > >>> this bug first appeared in IcedTea6 when the hs19 were set as default > >>> HotSpot on 2010-10-19). Is it still possible to push the test > >>> correction > >>> to OpenJDK 6 too, or only to OpenJDK 7? > >>> > >>> Also I'll need a bug id please. > >>> > >> > >> Sorry for the belated reply, please use > >> > >> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont > >> > >> Approved for OpenJDK 6. > >> > >> -Joe > > > > Hello. > > > > If this can be pushed in the next day or two, I'm open to having this > > bug fix in b21. > > > > Thanks, > > > > -Joe > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From coleen.phillimore at oracle.com Thu Jan 13 07:10:04 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 13 Jan 2011 10:10:04 -0500 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <20110113140911.GA4081@rivendell.middle-earth.co.uk> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> Message-ID: <4D2F15CC.1030600@oracle.com> On 1/13/2011 9:09 AM, Dr Andrew John Hughes wrote: > On 19:55 Wed 12 Jan , Coleen Phillimore wrote: >> I have to read this bug and reread this thread, but I just backed out >> the change for 6938627 which I believe was the cause of this bug too. >> Hotspot will not use java.io.tmpdir to get a temporary directory, it >> will use the system temporary directory. There was a JDK change in jdk >> 7 that also has to be refixed that Alan's going to do (bug 6950927: >> Testcase failure >> sun/management/jmxremote/bootstrap/JvmstatCountersTest.java) >> >> See bug 7009828: Fix for 6938627 breaks visualvm monitoring when >> -Djava.io.tmpdir is defined >> >> Now, I've read your bug 7003327 - you can filter hsperfdata but it >> won't be there anymore. >> > Well, it will if: > > changeset: 1999:34d64ad817f4 > tag: tip > user: coleenp > date: Wed Jan 12 13:59:18 2011 -0800 > summary: 7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined > > is backported to OpenJDK6. Joe, should we do this? It only seems to be in > the hotspot-rt tree so far. > After a couple rounds of testing, this change should be in hs20 which will be in jdk6u25. I don't know how it gets into openjdk6. I can barely follow our own release model. I don't think you want to port it individually though. Coleen >> Coleen >> >> On 1/12/2011 7:20 PM, Joe Darcy wrote: >>> Joe Darcy wrote: >>>> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: >>>>> Phil Race wrote: >>>>>> Pavel, >>>>>> >>>>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by >>>>>> package names. >>>>> Ah sorry, you are right, of course. >>>>>> I was a bit curious about the real reason for this failure. >>>>>> I wrote this test a couple of years ago and its never failed before. >>>>>> I don't see it failing on any 6-open build. >>>>>> I see it failing only in JDK 7 from b90. That seems to be due to >>>>>> HS18b03 >>>>>> fix >>>>>> 6938627: Make temporary directory use property java.io.tmpdir when >>>>>> specified >>>>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses >>>>> some backports from OpenJDK 7 (from the log files I can only infer that >>>>> this bug first appeared in IcedTea6 when the hs19 were set as default >>>>> HotSpot on 2010-10-19). Is it still possible to push the test >>>>> correction >>>>> to OpenJDK 6 too, or only to OpenJDK 7? >>>>> >>>>> Also I'll need a bug id please. >>>>> >>>> Sorry for the belated reply, please use >>>> >>>> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont >>>> >>>> Approved for OpenJDK 6. >>>> >>>> -Joe >>> Hello. >>> >>> If this can be pushed in the next day or two, I'm open to having this >>> bug fix in b21. >>> >>> Thanks, >>> >>> -Joe From ahughes at redhat.com Thu Jan 13 08:28:18 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Thu, 13 Jan 2011 16:28:18 +0000 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4D2F15CC.1030600@oracle.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> Message-ID: <20110113162818.GC4081@rivendell.middle-earth.co.uk> On 10:10 Thu 13 Jan , Coleen Phillimore wrote: > On 1/13/2011 9:09 AM, Dr Andrew John Hughes wrote: > > On 19:55 Wed 12 Jan , Coleen Phillimore wrote: > >> I have to read this bug and reread this thread, but I just backed out > >> the change for 6938627 which I believe was the cause of this bug too. > >> Hotspot will not use java.io.tmpdir to get a temporary directory, it > >> will use the system temporary directory. There was a JDK change in jdk > >> 7 that also has to be refixed that Alan's going to do (bug 6950927: > >> Testcase failure > >> sun/management/jmxremote/bootstrap/JvmstatCountersTest.java) > >> > >> See bug 7009828: Fix for 6938627 breaks visualvm monitoring when > >> -Djava.io.tmpdir is defined > >> > >> Now, I've read your bug 7003327 - you can filter hsperfdata but it > >> won't be there anymore. > >> > > Well, it will if: > > > > changeset: 1999:34d64ad817f4 > > tag: tip > > user: coleenp > > date: Wed Jan 12 13:59:18 2011 -0800 > > summary: 7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined > > > > is backported to OpenJDK6. Joe, should we do this? It only seems to be in > > the hotspot-rt tree so far. > > > After a couple rounds of testing, this change should be in hs20 which > will be in jdk6u25. I don't know how it gets into openjdk6. I can > barely follow our own release model. 'our'? > I don't think you want to port it > individually though. > OpenJDK6 is currently tracking the hs19 stable branch which has 6938627 and hence this regression (including the broken AWT test). Can you explain why it would not make sense to fix it? There doesn't seem to be a stable branch for hs20 on http://hg.openjdk.java.net yet so it won't be imported into OpenJDK6 any time soon. > Coleen > >> Coleen > >> > >> On 1/12/2011 7:20 PM, Joe Darcy wrote: > >>> Joe Darcy wrote: > >>>> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: > >>>>> Phil Race wrote: > >>>>>> Pavel, > >>>>>> > >>>>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by > >>>>>> package names. > >>>>> Ah sorry, you are right, of course. > >>>>>> I was a bit curious about the real reason for this failure. > >>>>>> I wrote this test a couple of years ago and its never failed before. > >>>>>> I don't see it failing on any 6-open build. > >>>>>> I see it failing only in JDK 7 from b90. That seems to be due to > >>>>>> HS18b03 > >>>>>> fix > >>>>>> 6938627: Make temporary directory use property java.io.tmpdir when > >>>>>> specified > >>>>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses > >>>>> some backports from OpenJDK 7 (from the log files I can only infer that > >>>>> this bug first appeared in IcedTea6 when the hs19 were set as default > >>>>> HotSpot on 2010-10-19). Is it still possible to push the test > >>>>> correction > >>>>> to OpenJDK 6 too, or only to OpenJDK 7? > >>>>> > >>>>> Also I'll need a bug id please. > >>>>> > >>>> Sorry for the belated reply, please use > >>>> > >>>> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont > >>>> > >>>> Approved for OpenJDK 6. > >>>> > >>>> -Joe > >>> Hello. > >>> > >>> If this can be pushed in the next day or two, I'm open to having this > >>> bug fix in b21. > >>> > >>> Thanks, > >>> > >>> -Joe > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From coleen.phillimore at oracle.com Thu Jan 13 08:30:27 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 13 Jan 2011 11:30:27 -0500 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <20110113162818.GC4081@rivendell.middle-earth.co.uk> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> <20110113162818.GC4081@rivendell.middle-earth.co.uk> Message-ID: <4D2F28A3.2010606@oracle.com> >> After a couple rounds of testing, this change should be in hs20 which >> will be in jdk6u25. I don't know how it gets into openjdk6. I can >> barely follow our own release model. > 'our'? > Oracle's. >> I don't think you want to port it >> individually though. >> > OpenJDK6 is currently tracking the hs19 stable branch which has > 6938627 and hence this regression (including the broken AWT test). > Can you explain why it would not make sense to fix it? There doesn't > seem to be a stable branch for hs20 on http://hg.openjdk.java.net yet > so it won't be imported into OpenJDK6 any time soon. > We're getting close to the stable hs20 branch. I don't know how or when it's imported to OpenJDK6 though so I shouldn't have tried to answer the question. Coleen >> Coleen >>>> Coleen >>>> >>>> On 1/12/2011 7:20 PM, Joe Darcy wrote: >>>>> Joe Darcy wrote: >>>>>> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: >>>>>>> Phil Race wrote: >>>>>>>> Pavel, >>>>>>>> >>>>>>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by >>>>>>>> package names. >>>>>>> Ah sorry, you are right, of course. >>>>>>>> I was a bit curious about the real reason for this failure. >>>>>>>> I wrote this test a couple of years ago and its never failed before. >>>>>>>> I don't see it failing on any 6-open build. >>>>>>>> I see it failing only in JDK 7 from b90. That seems to be due to >>>>>>>> HS18b03 >>>>>>>> fix >>>>>>>> 6938627: Make temporary directory use property java.io.tmpdir when >>>>>>>> specified >>>>>>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses >>>>>>> some backports from OpenJDK 7 (from the log files I can only infer that >>>>>>> this bug first appeared in IcedTea6 when the hs19 were set as default >>>>>>> HotSpot on 2010-10-19). Is it still possible to push the test >>>>>>> correction >>>>>>> to OpenJDK 6 too, or only to OpenJDK 7? >>>>>>> >>>>>>> Also I'll need a bug id please. >>>>>>> >>>>>> Sorry for the belated reply, please use >>>>>> >>>>>> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont >>>>>> >>>>>> Approved for OpenJDK 6. >>>>>> >>>>>> -Joe >>>>> Hello. >>>>> >>>>> If this can be pushed in the next day or two, I'm open to having this >>>>> bug fix in b21. >>>>> >>>>> Thanks, >>>>> >>>>> -Joe From ahughes at redhat.com Thu Jan 13 08:42:22 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Thu, 13 Jan 2011 16:42:22 +0000 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4D2F28A3.2010606@oracle.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> <20110113162818.GC4081@rivendell.middle-earth.co.uk> <4D2F28A3.2010606@oracle.com> Message-ID: <20110113164222.GE4081@rivendell.middle-earth.co.uk> On 11:30 Thu 13 Jan , Coleen Phillimore wrote: > > >> After a couple rounds of testing, this change should be in hs20 which > >> will be in jdk6u25. I don't know how it gets into openjdk6. I can > >> barely follow our own release model. > > 'our'? > > > Oracle's. Ah, I thought that's what you meant but was confused because Oracle also do the OpenJDK6 releases as far as I'm aware. > >> I don't think you want to port it > >> individually though. > >> > > OpenJDK6 is currently tracking the hs19 stable branch which has > > 6938627 and hence this regression (including the broken AWT test). > > Can you explain why it would not make sense to fix it? There doesn't > > seem to be a stable branch for hs20 on http://hg.openjdk.java.net yet > > so it won't be imported into OpenJDK6 any time soon. > > > We're getting close to the stable hs20 branch. I don't know how or when > it's imported to OpenJDK6 though so I shouldn't have tried to answer the > question. > I usually do the work to import new versions of HotSpot into OpenJDK6 and Joe approves it, as with all OpenJDK6 patches. I've never really understood why we need to have both a stable branch AND an OpenJDK6 HotSpot tree, given they end up being essentially the same, but that's the way it is. We're about to make a new release of OpenJDK6 (b21) with HotSpot 19. We've obviously don't want to import an entire new HotSpot at this juncture, but will probably do so for b22 once the HotSpot tree becomes available. >From what you say, my understanding is that 6938627 causes a regression from previous HotSpot behaviour and your patch, 7009828, fixes that regression. As OpenJDK6 has 6938627, would it not make sense to backport 7009828 as well to fix the regression? If not, what am I missing here? The patch doesn't seem hugely intrusive, and it reverts back to using the previous expected behaviour of /tmp over java.io.tmpdir. > Coleen > >> Coleen > >>>> Coleen > >>>> > >>>> On 1/12/2011 7:20 PM, Joe Darcy wrote: > >>>>> Joe Darcy wrote: > >>>>>> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: > >>>>>>> Phil Race wrote: > >>>>>>>> Pavel, > >>>>>>>> > >>>>>>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by > >>>>>>>> package names. > >>>>>>> Ah sorry, you are right, of course. > >>>>>>>> I was a bit curious about the real reason for this failure. > >>>>>>>> I wrote this test a couple of years ago and its never failed before. > >>>>>>>> I don't see it failing on any 6-open build. > >>>>>>>> I see it failing only in JDK 7 from b90. That seems to be due to > >>>>>>>> HS18b03 > >>>>>>>> fix > >>>>>>>> 6938627: Make temporary directory use property java.io.tmpdir when > >>>>>>>> specified > >>>>>>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses > >>>>>>> some backports from OpenJDK 7 (from the log files I can only infer that > >>>>>>> this bug first appeared in IcedTea6 when the hs19 were set as default > >>>>>>> HotSpot on 2010-10-19). Is it still possible to push the test > >>>>>>> correction > >>>>>>> to OpenJDK 6 too, or only to OpenJDK 7? > >>>>>>> > >>>>>>> Also I'll need a bug id please. > >>>>>>> > >>>>>> Sorry for the belated reply, please use > >>>>>> > >>>>>> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont > >>>>>> > >>>>>> Approved for OpenJDK 6. > >>>>>> > >>>>>> -Joe > >>>>> Hello. > >>>>> > >>>>> If this can be pushed in the next day or two, I'm open to having this > >>>>> bug fix in b21. > >>>>> > >>>>> Thanks, > >>>>> > >>>>> -Joe > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From coleen.phillimore at oracle.com Thu Jan 13 08:50:58 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 13 Jan 2011 11:50:58 -0500 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <20110113164222.GE4081@rivendell.middle-earth.co.uk> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> <20110113162818.GC4081@rivendell.middle-earth.co.uk> <4D2F28A3.2010606@oracle.com> <20110113164222.GE4081@rivendell.middle-earth.co.uk> Message-ID: <4D2F2D72.3070606@oracle.com> >> We're getting close to the stable hs20 branch. I don't know how or when >> it's imported to OpenJDK6 though so I shouldn't have tried to answer the >> question. >> > I usually do the work to import new versions of HotSpot into OpenJDK6 and Joe > approves it, as with all OpenJDK6 patches. I've never really understood why > we need to have both a stable branch AND an OpenJDK6 HotSpot tree, given they > end up being essentially the same, but that's the way it is. > > We're about to make a new release of OpenJDK6 (b21) with HotSpot 19. We've > obviously don't want to import an entire new HotSpot at this juncture, but will > probably do so for b22 once the HotSpot tree becomes available. > > From what you say, my understanding is that 6938627 causes a regression from previous > HotSpot behaviour and your patch, 7009828, fixes that regression. As OpenJDK6 has > 6938627, would it not make sense to backport 7009828 as well to fix the regression? > If not, what am I missing here? The patch doesn't seem hugely intrusive, and it reverts > back to using the previous expected behaviour of /tmp over java.io.tmpdir. > I didn't know all of this. Yes, I think you want to backport this change. It was pretty small in diffs. You might have some confusion since hs19 has the bug in the Oracle (not open?) releases and you do not. But it only matters for people setting java.io.tmpdir property which isn't as rare as we thought. Coleen >> Coleen >>>> Coleen >>>>>> Coleen >>>>>> >>>>>> On 1/12/2011 7:20 PM, Joe Darcy wrote: >>>>>>> Joe Darcy wrote: >>>>>>>> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: >>>>>>>>> Phil Race wrote: >>>>>>>>>> Pavel, >>>>>>>>>> >>>>>>>>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by >>>>>>>>>> package names. >>>>>>>>> Ah sorry, you are right, of course. >>>>>>>>>> I was a bit curious about the real reason for this failure. >>>>>>>>>> I wrote this test a couple of years ago and its never failed before. >>>>>>>>>> I don't see it failing on any 6-open build. >>>>>>>>>> I see it failing only in JDK 7 from b90. That seems to be due to >>>>>>>>>> HS18b03 >>>>>>>>>> fix >>>>>>>>>> 6938627: Make temporary directory use property java.io.tmpdir when >>>>>>>>>> specified >>>>>>>>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses >>>>>>>>> some backports from OpenJDK 7 (from the log files I can only infer that >>>>>>>>> this bug first appeared in IcedTea6 when the hs19 were set as default >>>>>>>>> HotSpot on 2010-10-19). Is it still possible to push the test >>>>>>>>> correction >>>>>>>>> to OpenJDK 6 too, or only to OpenJDK 7? >>>>>>>>> >>>>>>>>> Also I'll need a bug id please. >>>>>>>>> >>>>>>>> Sorry for the belated reply, please use >>>>>>>> >>>>>>>> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont >>>>>>>> >>>>>>>> Approved for OpenJDK 6. >>>>>>>> >>>>>>>> -Joe >>>>>>> Hello. >>>>>>> >>>>>>> If this can be pushed in the next day or two, I'm open to having this >>>>>>> bug fix in b21. >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> -Joe From ahughes at redhat.com Thu Jan 13 09:12:41 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Thu, 13 Jan 2011 17:12:41 +0000 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4D2F2D72.3070606@oracle.com> References: <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> <20110113162818.GC4081@rivendell.middle-earth.co.uk> <4D2F28A3.2010606@oracle.com> <20110113164222.GE4081@rivendell.middle-earth.co.uk> <4D2F2D72.3070606@oracle.com> Message-ID: <20110113171241.GG4081@rivendell.middle-earth.co.uk> On 11:50 Thu 13 Jan , Coleen Phillimore wrote: > > >> We're getting close to the stable hs20 branch. I don't know how or when > >> it's imported to OpenJDK6 though so I shouldn't have tried to answer the > >> question. > >> > > I usually do the work to import new versions of HotSpot into OpenJDK6 and Joe > > approves it, as with all OpenJDK6 patches. I've never really understood why > > we need to have both a stable branch AND an OpenJDK6 HotSpot tree, given they > > end up being essentially the same, but that's the way it is. > > > > We're about to make a new release of OpenJDK6 (b21) with HotSpot 19. We've > > obviously don't want to import an entire new HotSpot at this juncture, but will > > probably do so for b22 once the HotSpot tree becomes available. > > > > From what you say, my understanding is that 6938627 causes a regression from previous > > HotSpot behaviour and your patch, 7009828, fixes that regression. As OpenJDK6 has > > 6938627, would it not make sense to backport 7009828 as well to fix the regression? > > If not, what am I missing here? The patch doesn't seem hugely intrusive, and it reverts > > back to using the previous expected behaviour of /tmp over java.io.tmpdir. > > > I didn't know all of this. I finally realised this, hence the explanation :-) > Yes, I think you want to backport this > change. Thanks. I now just need the thumbs up from Joe as well. Joe? > It was pretty small in diffs. You might have some confusion > since hs19 has the bug in the Oracle (not open?) releases and you do > not. I'm not sure I follow you. They use the same bug database still, as far as I'm aware. > But it only matters for people setting java.io.tmpdir property > which isn't as rare as we thought. > Yes, the reason I pressed on the issue of the backport was because I could foresee bug reports against the various distro packages (once it gets built and shipped out) due to this change. > Coleen Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Thu Jan 13 09:56:57 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 13 Jan 2011 09:56:57 -0800 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <20110113171241.GG4081@rivendell.middle-earth.co.uk> References: <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> <20110113162818.GC4081@rivendell.middle-earth.co.uk> <4D2F28A3.2010606@oracle.com> <20110113164222.GE4081@rivendell.middle-earth.co.uk> <4D2F2D72.3070606@oracle.com> <20110113171241.GG4081@rivendell.middle-earth.co.uk> Message-ID: <4D2F3CE9.7070900@oracle.com> On 1/13/2011 9:12 AM, Dr Andrew John Hughes wrote: > On 11:50 Thu 13 Jan , Coleen Phillimore wrote: >>>> We're getting close to the stable hs20 branch. I don't know how or when >>>> it's imported to OpenJDK6 though so I shouldn't have tried to answer the >>>> question. >>>> >>> I usually do the work to import new versions of HotSpot into OpenJDK6 and Joe >>> approves it, as with all OpenJDK6 patches. I've never really understood why >>> we need to have both a stable branch AND an OpenJDK6 HotSpot tree, given they >>> end up being essentially the same, but that's the way it is. >>> >>> We're about to make a new release of OpenJDK6 (b21) with HotSpot 19. We've >>> obviously don't want to import an entire new HotSpot at this juncture, but will >>> probably do so for b22 once the HotSpot tree becomes available. >>> >>> From what you say, my understanding is that 6938627 causes a regression from previous >>> HotSpot behaviour and your patch, 7009828, fixes that regression. As OpenJDK6 has >>> 6938627, would it not make sense to backport 7009828 as well to fix the regression? >>> If not, what am I missing here? The patch doesn't seem hugely intrusive, and it reverts >>> back to using the previous expected behaviour of /tmp over java.io.tmpdir. >>> >> I didn't know all of this. > I finally realised this, hence the explanation :-) > >> Yes, I think you want to backport this >> change. > Thanks. I now just need the thumbs up from Joe as well. Joe? I've taken a look at the patch and I approve 7009828 to be backported to OpenJDK 6 b21. Thanks, -Joe From ahughes at redhat.com Thu Jan 13 10:03:39 2011 From: ahughes at redhat.com (ahughes at redhat.com) Date: Thu, 13 Jan 2011 18:03:39 +0000 Subject: hg: jdk6/jdk6/hotspot: 7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined Message-ID: <20110113180342.B7DC047BFD@hg.openjdk.java.net> Changeset: 2c8e1acf0433 Author: coleenp Date: 2011-01-12 13:59 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/2c8e1acf0433 7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined Summary: Change get_temp_directory() back to /tmp and %TEMP% like it always was and where the tools expect it to be. Reviewed-by: phh, dcubed, kamg, alanb ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/utilities/vmError.cpp From ahughes at redhat.com Thu Jan 13 10:05:18 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Thu, 13 Jan 2011 18:05:18 +0000 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4D2F3CE9.7070900@oracle.com> References: <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> <20110113162818.GC4081@rivendell.middle-earth.co.uk> <4D2F28A3.2010606@oracle.com> <20110113164222.GE4081@rivendell.middle-earth.co.uk> <4D2F2D72.3070606@oracle.com> <20110113171241.GG4081@rivendell.middle-earth.co.uk> <4D2F3CE9.7070900@oracle.com> Message-ID: <20110113180518.GL4081@rivendell.middle-earth.co.uk> On 09:56 Thu 13 Jan , Joe Darcy wrote: > On 1/13/2011 9:12 AM, Dr Andrew John Hughes wrote: > > On 11:50 Thu 13 Jan , Coleen Phillimore wrote: > >>>> We're getting close to the stable hs20 branch. I don't know how or when > >>>> it's imported to OpenJDK6 though so I shouldn't have tried to answer the > >>>> question. > >>>> > >>> I usually do the work to import new versions of HotSpot into OpenJDK6 and Joe > >>> approves it, as with all OpenJDK6 patches. I've never really understood why > >>> we need to have both a stable branch AND an OpenJDK6 HotSpot tree, given they > >>> end up being essentially the same, but that's the way it is. > >>> > >>> We're about to make a new release of OpenJDK6 (b21) with HotSpot 19. We've > >>> obviously don't want to import an entire new HotSpot at this juncture, but will > >>> probably do so for b22 once the HotSpot tree becomes available. > >>> > >>> From what you say, my understanding is that 6938627 causes a regression from previous > >>> HotSpot behaviour and your patch, 7009828, fixes that regression. As OpenJDK6 has > >>> 6938627, would it not make sense to backport 7009828 as well to fix the regression? > >>> If not, what am I missing here? The patch doesn't seem hugely intrusive, and it reverts > >>> back to using the previous expected behaviour of /tmp over java.io.tmpdir. > >>> > >> I didn't know all of this. > > I finally realised this, hence the explanation :-) > > > >> Yes, I think you want to backport this > >> change. > > Thanks. I now just need the thumbs up from Joe as well. Joe? > > I've taken a look at the patch and I approve 7009828 to be backported to > OpenJDK 6 b21. > Done: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/2c8e1acf0433 > Thanks, > > -Joe > Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Thu Jan 13 10:11:35 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 13 Jan 2011 10:11:35 -0800 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <20110113164222.GE4081@rivendell.middle-earth.co.uk> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> <4CF47CF9.1020005@oracle.com> <4D2E456B.9080208@oracle.com> <4D2E4D97.9090101@oracle.com> <20110113140911.GA4081@rivendell.middle-earth.co.uk> <4D2F15CC.1030600@oracle.com> <20110113162818.GC4081@rivendell.middle-earth.co.uk> <4D2F28A3.2010606@oracle.com> <20110113164222.GE4081@rivendell.middle-earth.co.uk> Message-ID: <4D2F4057.7090109@oracle.com> On 1/13/2011 8:42 AM, Dr Andrew John Hughes wrote: > On 11:30 Thu 13 Jan , Coleen Phillimore wrote: >>>> After a couple rounds of testing, this change should be in hs20 which >>>> will be in jdk6u25. I don't know how it gets into openjdk6. I can >>>> barely follow our own release model. >>> 'our'? >>> >> Oracle's. > Ah, I thought that's what you meant but was confused because Oracle also > do the OpenJDK6 releases as far as I'm aware. The HotSpot team has a thicket of forests through which their fixes flow. The OpenJDK 6 HotSpot repository is toward the periphery of this system; the vast majority of the HotSpot changes in OpenJDK 6 come from the stabilized HotSpot repo (ported by Andrew) with selected other fixes applied, often from more recent but not yet stabilized HotSpot trains. OpenJDK 6 does use the same bug database as HotSpot; however, not all HotSpot fixes ported to OpenJDK 6 get per-release bug entries created in the database. -Joe From omajid at redhat.com Fri Jan 14 14:35:29 2011 From: omajid at redhat.com (Omair Majid) Date: Fri, 14 Jan 2011 17:35:29 -0500 Subject: Request to backport 6736649 and 6797139 Message-ID: <4D30CFB1.6050705@redhat.com> Hi, I would like to backport the following two changesets to openjdk6: changeset: 624:e78c2f17a606 user: mlapshin date: Tue Aug 26 12:16:23 2008 +0400 summary: 6736649: test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails on Linux changeset: 1637:281fbd82a971 user: alexp date: Wed Sep 02 17:47:19 2009 +0400 summary: 6797139: JButton title is truncating for some strings irrespective of preferred size. Together, these changesets fix a bug where some strings are incorrectly being truncated. Thanks, Omair From omajid at redhat.com Mon Jan 17 10:07:11 2011 From: omajid at redhat.com (Omair Majid) Date: Mon, 17 Jan 2011 13:07:11 -0500 Subject: Backport 6642612 Message-ID: <4D34854F.3080305@redhat.com> Hi, I would like to backport the following changeset to openjdk6: changeset: 14:9a322f3dccd8 user: rupashka date: Wed Apr 30 13:01:01 2008 +0400 summary: 6642612: JFileChooser approve buttons should use Open and Save text (GTK) The summary is a little misleading; the changeset makes the "OK" and "Cancel" buttons have the same size. Cheers, Omair From joe.darcy at oracle.com Tue Jan 18 10:56:30 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 18 Jan 2011 10:56:30 -0800 Subject: Request to backport 6736649 and 6797139 In-Reply-To: <4D30CFB1.6050705@redhat.com> References: <4D30CFB1.6050705@redhat.com> Message-ID: <4D35E25E.20105@oracle.com> Omair Majid wrote: > Hi, > > I would like to backport the following two changesets to openjdk6: > > changeset: 624:e78c2f17a606 > user: mlapshin > date: Tue Aug 26 12:16:23 2008 +0400 > summary: 6736649: > test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails > on Linux > > changeset: 1637:281fbd82a971 > user: alexp > date: Wed Sep 02 17:47:19 2009 +0400 > summary: 6797139: JButton title is truncating for some strings > irrespective of preferred size. > > Together, these changesets fix a bug where some strings are > incorrectly being truncated. > > Thanks, > Omair Hello. I started taking a look at these patches, but ran into some of the API issues discussed on the IcedTea alias: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-January/011741.html I'll defer making a decision on these patches until the results of that investigation are in. Thanks, -Joe From joe.darcy at oracle.com Tue Jan 18 12:27:37 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 18 Jan 2011 12:27:37 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <20110111210337.GR28602@rivendell.middle-earth.co.uk> References: <20101123133146.GM19794@rivendell.middle-earth.co.uk> <20101203135943.GE24477@rivendell.middle-earth.co.uk> <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> Message-ID: <4D35F7B9.3010102@oracle.com> On 1/11/2011 1:03 PM, Dr Andrew John Hughes wrote: > On 11:36 Tue 11 Jan , Joe Darcy wrote: >> On 1/11/2011 10:19 AM, Dr Andrew John Hughes wrote: >>> On 09:43 Tue 11 Jan , Joe Darcy wrote: >>>> Joe Darcy wrote: >>>>> On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: >>>>>> On 11:26 Mon 10 Jan , Joe Darcy wrote: >>>>>> >>>>>> snip... >>>>>> >>>>>>> Hello. >>>>>>> >>>>>>> Since you haven't run into any issues with having 7002666 in IcedTea6 >>>>>>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should >>>>>>> bring b21 to a close! >>>>>>> >>>>>>> -Joe >>>>>> I've pushed 7002666: >>>>>> >>>>>> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee >>>>>> >>>>>> along with two PNG backports that were approved for Deepak Bhole some >>>>>> time >>>>>> ago but were never done: >>>>>> >>>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d >>>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 >>>>>> >>>>>> (copyright headers updated appropriately). >>>>>> >>>>>> Let's get b21 out the door! :-) >>>>> Agreed! Later this week, I'll go through my pre-promotion build and >>>>> test cycle. >>>>> >>>>> -Joe >>>> When running the HotSpot regression tests, I see two failures: >>>> >>>> Compilation failed: Compilation failed >>>> >>>> * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is >>>> zero after GC which is incorrect >>>> >>>> Execution failed: exit code 127 >>>> >>>> * runtime/6929067/Test6929067.sh : Stack guard pages should be >>>> removed when thread is detached >>>> >>>> The first is due to a typo in the test case; I approve the backport of >>>> 6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo" >>>> http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 >>>> to fix this. >>>> >>>> The second test seems to make platform assumptions that aren't always >>>> true, but after some looking around I don't see an existing fix in the >>>> HotSpot repos. >>>> >>>> At least the first should be fixed before b21 promotes. >>>> >>> Yes, both of these issues are fixed in IcedTea6, the first with the 6980392 >>> that I've now pushed to OpenJDK6. >> Thanks for doing the push. >> >>> I recall there was some discussion of a fix for the second with upstream, but >>> I can't find it right now and Pavel (who found the bug and fixed it) is on >>> vacation. >>> >> One Oracle bug for this test failure seems to be, >> >> 6945460 TEST_BUG: runtime/6929067/Test6929067.sh >> >> but it is not marked as fixed in any release. >> >> There was some discussion on IcedTea: >> >> >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/011057.html >> >> and at least some on HotSpot: >> >> >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010959.html >> >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-December/011329.html >> >> but I don't see a resolution. >> > Yes, these are all on the IcedTea mailing list. I recall some discussion > on the HotSpot mailing lists but I can't find any. > > The patch is in IcedTea6 as patches/jtreg-6929067-fix.patch. As I said, Pavel will > know more but isn't around to comment at the moment. > I'll take a took at the patch; I'd prefer b21 to have a clean HotSpot regression test run and a fix for that issue will be necessary for that to happen (I'll other HotSpot regression tests pass). -joe From ahughes at redhat.com Tue Jan 18 15:26:38 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Tue, 18 Jan 2011 23:26:38 +0000 Subject: [PING] Re: About time for b21? In-Reply-To: <4D35F7B9.3010102@oracle.com> References: <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> Message-ID: <20110118232638.GH14019@rivendell.middle-earth.co.uk> On 12:27 Tue 18 Jan , Joe Darcy wrote: > On 1/11/2011 1:03 PM, Dr Andrew John Hughes wrote: > > On 11:36 Tue 11 Jan , Joe Darcy wrote: > >> On 1/11/2011 10:19 AM, Dr Andrew John Hughes wrote: > >>> On 09:43 Tue 11 Jan , Joe Darcy wrote: > >>>> Joe Darcy wrote: > >>>>> On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: > >>>>>> On 11:26 Mon 10 Jan , Joe Darcy wrote: > >>>>>> > >>>>>> snip... > >>>>>> > >>>>>>> Hello. > >>>>>>> > >>>>>>> Since you haven't run into any issues with having 7002666 in IcedTea6 > >>>>>>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should > >>>>>>> bring b21 to a close! > >>>>>>> > >>>>>>> -Joe > >>>>>> I've pushed 7002666: > >>>>>> > >>>>>> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee > >>>>>> > >>>>>> along with two PNG backports that were approved for Deepak Bhole some > >>>>>> time > >>>>>> ago but were never done: > >>>>>> > >>>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d > >>>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 > >>>>>> > >>>>>> (copyright headers updated appropriately). > >>>>>> > >>>>>> Let's get b21 out the door! :-) > >>>>> Agreed! Later this week, I'll go through my pre-promotion build and > >>>>> test cycle. > >>>>> > >>>>> -Joe > >>>> When running the HotSpot regression tests, I see two failures: > >>>> > >>>> Compilation failed: Compilation failed > >>>> > >>>> * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is > >>>> zero after GC which is incorrect > >>>> > >>>> Execution failed: exit code 127 > >>>> > >>>> * runtime/6929067/Test6929067.sh : Stack guard pages should be > >>>> removed when thread is detached > >>>> > >>>> The first is due to a typo in the test case; I approve the backport of > >>>> 6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo" > >>>> http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 > >>>> to fix this. > >>>> > >>>> The second test seems to make platform assumptions that aren't always > >>>> true, but after some looking around I don't see an existing fix in the > >>>> HotSpot repos. > >>>> > >>>> At least the first should be fixed before b21 promotes. > >>>> > >>> Yes, both of these issues are fixed in IcedTea6, the first with the 6980392 > >>> that I've now pushed to OpenJDK6. > >> Thanks for doing the push. > >> > >>> I recall there was some discussion of a fix for the second with upstream, but > >>> I can't find it right now and Pavel (who found the bug and fixed it) is on > >>> vacation. > >>> > >> One Oracle bug for this test failure seems to be, > >> > >> 6945460 TEST_BUG: runtime/6929067/Test6929067.sh > >> > >> but it is not marked as fixed in any release. > >> > >> There was some discussion on IcedTea: > >> > >> > >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/011057.html > >> > >> and at least some on HotSpot: > >> > >> > >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010959.html > >> > >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-December/011329.html > >> > >> but I don't see a resolution. > >> > > Yes, these are all on the IcedTea mailing list. I recall some discussion > > on the HotSpot mailing lists but I can't find any. > > > > The patch is in IcedTea6 as patches/jtreg-6929067-fix.patch. As I said, Pavel will > > know more but isn't around to comment at the moment. > > > > I'll take a took at the patch; I'd prefer b21 to have a clean HotSpot > regression test run and a fix for that issue will be necessary for that > to happen (I'll other HotSpot regression tests pass). > > -joe > Ok I'll ping Pavel directly tomorrow. Let's not delay b21 much longer, it's already over six months since a release. There are unreleased javac fixes dating back to last June. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Wed Jan 19 11:00:25 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 19 Jan 2011 11:00:25 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <20110118232638.GH14019@rivendell.middle-earth.co.uk> References: <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> Message-ID: <4D3734C9.5010003@oracle.com> Dr Andrew John Hughes wrote: > On 12:27 Tue 18 Jan , Joe Darcy wrote: > >> On 1/11/2011 1:03 PM, Dr Andrew John Hughes wrote: >> >>> On 11:36 Tue 11 Jan , Joe Darcy wrote: >>> >>>> On 1/11/2011 10:19 AM, Dr Andrew John Hughes wrote: >>>> >>>>> On 09:43 Tue 11 Jan , Joe Darcy wrote: >>>>> >>>>>> Joe Darcy wrote: >>>>>> >>>>>>> On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote: >>>>>>> >>>>>>>> On 11:26 Mon 10 Jan , Joe Darcy wrote: >>>>>>>> >>>>>>>> snip... >>>>>>>> >>>>>>>> >>>>>>>>> Hello. >>>>>>>>> >>>>>>>>> Since you haven't run into any issues with having 7002666 in IcedTea6 >>>>>>>>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should >>>>>>>>> bring b21 to a close! >>>>>>>>> >>>>>>>>> -Joe >>>>>>>>> >>>>>>>> I've pushed 7002666: >>>>>>>> >>>>>>>> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee >>>>>>>> >>>>>>>> along with two PNG backports that were approved for Deepak Bhole some >>>>>>>> time >>>>>>>> ago but were never done: >>>>>>>> >>>>>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d >>>>>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0 >>>>>>>> >>>>>>>> (copyright headers updated appropriately). >>>>>>>> >>>>>>>> Let's get b21 out the door! :-) >>>>>>>> >>>>>>> Agreed! Later this week, I'll go through my pre-promotion build and >>>>>>> test cycle. >>>>>>> >>>>>>> -Joe >>>>>>> >>>>>> When running the HotSpot regression tests, I see two failures: >>>>>> >>>>>> Compilation failed: Compilation failed >>>>>> >>>>>> * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is >>>>>> zero after GC which is incorrect >>>>>> >>>>>> Execution failed: exit code 127 >>>>>> >>>>>> * runtime/6929067/Test6929067.sh : Stack guard pages should be >>>>>> removed when thread is detached >>>>>> >>>>>> The first is due to a typo in the test case; I approve the backport of >>>>>> 6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo" >>>>>> http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 >>>>>> to fix this. >>>>>> >>>>>> The second test seems to make platform assumptions that aren't always >>>>>> true, but after some looking around I don't see an existing fix in the >>>>>> HotSpot repos. >>>>>> >>>>>> At least the first should be fixed before b21 promotes. >>>>>> >>>>>> >>>>> Yes, both of these issues are fixed in IcedTea6, the first with the 6980392 >>>>> that I've now pushed to OpenJDK6. >>>>> >>>> Thanks for doing the push. >>>> >>>> >>>>> I recall there was some discussion of a fix for the second with upstream, but >>>>> I can't find it right now and Pavel (who found the bug and fixed it) is on >>>>> vacation. >>>>> >>>>> >>>> One Oracle bug for this test failure seems to be, >>>> >>>> 6945460 TEST_BUG: runtime/6929067/Test6929067.sh >>>> >>>> but it is not marked as fixed in any release. >>>> >>>> There was some discussion on IcedTea: >>>> >>>> >>>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/011057.html >>>> >>>> and at least some on HotSpot: >>>> >>>> >>>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010959.html >>>> >>>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-December/011329.html >>>> >>>> but I don't see a resolution. >>>> >>>> >>> Yes, these are all on the IcedTea mailing list. I recall some discussion >>> on the HotSpot mailing lists but I can't find any. >>> >>> The patch is in IcedTea6 as patches/jtreg-6929067-fix.patch. As I said, Pavel will >>> know more but isn't around to comment at the moment. >>> >>> >> I'll take a took at the patch; I'd prefer b21 to have a clean HotSpot >> regression test run and a fix for that issue will be necessary for that >> to happen (I'll other HotSpot regression tests pass). >> >> -joe >> >> > > Ok I'll ping Pavel directly tomorrow. > > Let's not delay b21 much longer, it's already over six months since a release. > There are unreleased javac fixes dating back to last June. > Agreed. Here are my test results from tip compared to b20: 0: b20-hotspot/summary.txt pass: 85 1: b21-hotspot/summary.txt pass: 97; fail: 1 0 1 Test --- pass compiler/6431242/Test.java --- pass compiler/6894807/IsInstanceTest.java --- pass compiler/6932496/Test6932496.java --- pass compiler/6946040/TestCharShortByteSwap.java --- pass compiler/6958485/Test.java --- pass compiler/6973329/Test.java --- pass compiler/6982370/Test6982370.java --- pass compiler/7002666/Test7002666.java --- pass gc/6581734/Test6581734.java --- pass runtime/6626217/Test6626217.sh --- pass runtime/6888954/vmerrors.sh --- pass runtime/6925573/SortMethodsTest.java --- fail runtime/6929067/Test6929067.sh 13 differences 0: b20-langtools/summary.txt pass: 1,365 1: b21-langtools/summary.txt pass: 1,391 0 1 Test --- pass tools/javac/6508981/TestInferBinaryName.java --- pass tools/javac/6734819/T6734819a.java --- pass tools/javac/6734819/T6734819b.java --- pass tools/javac/6734819/T6734819c.java --- pass tools/javac/6889255/T6889255.java --- pass tools/javac/T6595666.java --- pass tools/javac/T6625520.java --- pass tools/javac/T6705935.java --- pass tools/javac/T6956638.java --- pass tools/javac/api/6411310/Test.java --- pass tools/javac/api/6440333/T6440333.java --- pass tools/javac/api/6733837/T6733837.java --- pass tools/javac/api/Sibling.java --- pass tools/javac/api/T6483788.java --- pass tools/javac/api/T6501502.java --- pass tools/javac/api/T6838467.java --- pass tools/javac/api/T6877206.java pass --- tools/javac/policy/Test.java pass --- tools/javac/policy/Test.java#id1 pass --- tools/javac/policy/Test.java#id2 pass --- tools/javac/policy/Test.java#id3 pass --- tools/javac/policy/Test.java#id4 pass --- tools/javac/policy/Test.java#id5 pass --- tools/javac/policy/Test.java#id6 pass --- tools/javac/policy/Test.java#id7 --- pass tools/javac/policy/test1/Test1a.java --- pass tools/javac/policy/test1/Test1a.java#id1 --- pass tools/javac/policy/test1/Test1a.java#id2 --- pass tools/javac/policy/test1/Test1a.java#id3 --- pass tools/javac/policy/test1/Test1a.java#id4 --- pass tools/javac/policy/test1/Test1a.java#id5 --- pass tools/javac/policy/test1/Test1a.java#id6 --- pass tools/javac/policy/test1/Test1a.java#id7 --- pass tools/javac/policy/test1/Test1b.java --- pass tools/javac/policy/test1/Test1b.java#id1 --- pass tools/javac/policy/test1/Test1b.java#id2 --- pass tools/javac/policy/test1/Test1b.java#id3 --- pass tools/javac/policy/test2/Test.java --- pass tools/javac/policy/test2/Test.java#id1 --- pass tools/javac/policy/test2/Test.java#id2 --- pass tools/javac/policy/test2/Test.java#id3 --- pass tools/javac/policy/test3/Test.java 42 differences 0: b20-jdk/summary.txt pass: 3,273; fail: 33; error: 2 1: b21-jdk/summary.txt pass: 3,300; fail: 29; error: 3 0 1 Test --- pass com/sun/java/swing/plaf/gtk/Test6963870.java fail pass java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java --- pass java/awt/Frame/FrameSize/TestFrameSize.java fail pass java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java fail pass java/awt/Multiscreen/LocationRelativeToTest/LocationRelativeToTest.java fail pass java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.html --- pass java/awt/font/TextLayout/TestSinhalaChar.java pass error java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh --- pass java/math/BigDecimal/MultiplyTests.java pass fail java/net/InetAddress/IPv4Formats.java pass fail java/net/URL/OpenStream.java pass fail java/net/URLClassLoader/ClassLoad.java pass fail java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java --- pass java/util/logging/AnonLoggerWeakRefLeak.sh --- pass java/util/logging/LoggerWeakRefLeak.sh --- pass javax/imageio/plugins/png/ITXtTest.java --- pass javax/imageio/plugins/png/ItxtUtf8Test.java --- pass javax/swing/JPopupMenu/6675802/bug6675802.java --- pass javax/swing/JPopupMenu/6691503/bug6691503.java --- pass javax/swing/Security/6938813/bug6938813.java --- pass javax/swing/UIDefaults/6622002/bug6622002.java --- pass javax/swing/UIDefaults/6795356/SwingLazyValueTest.java --- pass javax/swing/UIDefaults/6795356/TableTest.java --- pass javax/swing/UIDefaults/6795356/bug6795356.java fail pass javax/swing/plaf/synth/Test6933784.java fail pass sun/nio/cs/Test4200310.sh --- pass sun/security/pkcs11/SecureRandom/TestDeserialization.java --- pass sun/security/pkcs11/Signature/TestRSAKeyLength.java --- pass sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/InvalidateServerSessionRenegotiate.java --- fail sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java --- pass sun/security/ssl/javax/net/ssl/NewAPIs/JSSERenegotiate.java --- pass sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java --- pass sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/ConnectionTest.java --- pass sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/NoAuthClientAuth.java fail pass sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail pass sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java fail pass sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java fail pass sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Identities.java pass fail sun/security/validator/CertReplace.java --- pass sun/tools/common/CommonTests.sh 40 differences This looks sufficiently good to me for b21, regardless of the new (spurious) test failure in HotSpot. I'll start the internal procedures to generate the b21 source bundle. -Joe From ahughes at redhat.com Wed Jan 19 11:11:13 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Wed, 19 Jan 2011 19:11:13 +0000 Subject: [PING] Re: About time for b21? In-Reply-To: <4D3734C9.5010003@oracle.com> References: <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> Message-ID: <20110119191113.GA16826@rivendell.middle-earth.co.uk> On 11:00 Wed 19 Jan , Joe Darcy wrote: > Dr Andrew John Hughes wrote: snip... > > Let's not delay b21 much longer, it's already over six months since a release. > > There are unreleased javac fixes dating back to last June. > > > > Agreed. > > Here are my test results from tip compared to b20: > > 0: b20-hotspot/summary.txt pass: 85 > 1: b21-hotspot/summary.txt pass: 97; fail: 1 > > 0 1 Test > --- pass compiler/6431242/Test.java > --- pass compiler/6894807/IsInstanceTest.java > --- pass compiler/6932496/Test6932496.java > --- pass compiler/6946040/TestCharShortByteSwap.java > --- pass compiler/6958485/Test.java > --- pass compiler/6973329/Test.java > --- pass compiler/6982370/Test6982370.java > --- pass compiler/7002666/Test7002666.java > --- pass gc/6581734/Test6581734.java > --- pass runtime/6626217/Test6626217.sh > --- pass runtime/6888954/vmerrors.sh > --- pass runtime/6925573/SortMethodsTest.java > --- fail runtime/6929067/Test6929067.sh > > 13 differences > > 0: b20-langtools/summary.txt pass: 1,365 > 1: b21-langtools/summary.txt pass: 1,391 > > 0 1 Test > --- pass tools/javac/6508981/TestInferBinaryName.java > --- pass tools/javac/6734819/T6734819a.java > --- pass tools/javac/6734819/T6734819b.java > --- pass tools/javac/6734819/T6734819c.java > --- pass tools/javac/6889255/T6889255.java > --- pass tools/javac/T6595666.java > --- pass tools/javac/T6625520.java > --- pass tools/javac/T6705935.java > --- pass tools/javac/T6956638.java > --- pass tools/javac/api/6411310/Test.java > --- pass tools/javac/api/6440333/T6440333.java > --- pass tools/javac/api/6733837/T6733837.java > --- pass tools/javac/api/Sibling.java > --- pass tools/javac/api/T6483788.java > --- pass tools/javac/api/T6501502.java > --- pass tools/javac/api/T6838467.java > --- pass tools/javac/api/T6877206.java > pass --- tools/javac/policy/Test.java > pass --- tools/javac/policy/Test.java#id1 > pass --- tools/javac/policy/Test.java#id2 > pass --- tools/javac/policy/Test.java#id3 > pass --- tools/javac/policy/Test.java#id4 > pass --- tools/javac/policy/Test.java#id5 > pass --- tools/javac/policy/Test.java#id6 > pass --- tools/javac/policy/Test.java#id7 > --- pass tools/javac/policy/test1/Test1a.java > --- pass tools/javac/policy/test1/Test1a.java#id1 > --- pass tools/javac/policy/test1/Test1a.java#id2 > --- pass tools/javac/policy/test1/Test1a.java#id3 > --- pass tools/javac/policy/test1/Test1a.java#id4 > --- pass tools/javac/policy/test1/Test1a.java#id5 > --- pass tools/javac/policy/test1/Test1a.java#id6 > --- pass tools/javac/policy/test1/Test1a.java#id7 > --- pass tools/javac/policy/test1/Test1b.java > --- pass tools/javac/policy/test1/Test1b.java#id1 > --- pass tools/javac/policy/test1/Test1b.java#id2 > --- pass tools/javac/policy/test1/Test1b.java#id3 > --- pass tools/javac/policy/test2/Test.java > --- pass tools/javac/policy/test2/Test.java#id1 > --- pass tools/javac/policy/test2/Test.java#id2 > --- pass tools/javac/policy/test2/Test.java#id3 > --- pass tools/javac/policy/test3/Test.java > > 42 differences > > 0: b20-jdk/summary.txt pass: 3,273; fail: 33; error: 2 > 1: b21-jdk/summary.txt pass: 3,300; fail: 29; error: 3 > > 0 1 Test > --- pass com/sun/java/swing/plaf/gtk/Test6963870.java > fail pass > java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java > --- pass java/awt/Frame/FrameSize/TestFrameSize.java > fail pass java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java > fail pass > java/awt/Multiscreen/LocationRelativeToTest/LocationRelativeToTest.java > fail pass java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.html > --- pass java/awt/font/TextLayout/TestSinhalaChar.java > pass error > java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh > --- pass java/math/BigDecimal/MultiplyTests.java > pass fail java/net/InetAddress/IPv4Formats.java > pass fail java/net/URL/OpenStream.java > pass fail java/net/URLClassLoader/ClassLoad.java > pass fail > java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java > --- pass java/util/logging/AnonLoggerWeakRefLeak.sh > --- pass java/util/logging/LoggerWeakRefLeak.sh > --- pass javax/imageio/plugins/png/ITXtTest.java > --- pass javax/imageio/plugins/png/ItxtUtf8Test.java > --- pass javax/swing/JPopupMenu/6675802/bug6675802.java > --- pass javax/swing/JPopupMenu/6691503/bug6691503.java > --- pass javax/swing/Security/6938813/bug6938813.java > --- pass javax/swing/UIDefaults/6622002/bug6622002.java > --- pass javax/swing/UIDefaults/6795356/SwingLazyValueTest.java > --- pass javax/swing/UIDefaults/6795356/TableTest.java > --- pass javax/swing/UIDefaults/6795356/bug6795356.java > fail pass javax/swing/plaf/synth/Test6933784.java > fail pass sun/nio/cs/Test4200310.sh > --- pass sun/security/pkcs11/SecureRandom/TestDeserialization.java > --- pass sun/security/pkcs11/Signature/TestRSAKeyLength.java > --- pass > sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/InvalidateServerSessionRenegotiate.java > --- fail > sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java > --- pass sun/security/ssl/javax/net/ssl/NewAPIs/JSSERenegotiate.java > --- pass > sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java > --- pass > sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/ConnectionTest.java > --- pass > sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/NoAuthClientAuth.java > fail pass > sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java > fail pass > sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java > fail pass > sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java > fail pass > sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Identities.java > pass fail sun/security/validator/CertReplace.java > --- pass sun/tools/common/CommonTests.sh > > 40 differences > > This looks sufficiently good to me for b21, regardless of the new > (spurious) test failure in HotSpot. > Thanks Joe. Pavel pointed me to the discussion on the bug on the HotSpot lists. It was on hotspot-runtime-dev which is why I missed it: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2010-November/001477.html As you can see from the discussion, the test is at fault. It only works on 32-bit platforms and needs to be more generic to handle all situations. Pavel's fix in IcedTea works for GNU/Linux platforms, but AIUI will still run into difficulties on Solaris x86_64 where the compiler produces 32-bit binaries by default. > I'll start the internal procedures to generate the b21 source bundle. > Much appreciated! > -Joe Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Wed Jan 19 11:17:31 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 19 Jan 2011 11:17:31 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <20110119191113.GA16826@rivendell.middle-earth.co.uk> References: <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> <20110119191113.GA16826@rivendell.middle-earth.co.uk> Message-ID: <4D3738CB.8090404@oracle.com> Dr Andrew John Hughes wrote: > On 11:00 Wed 19 Jan , Joe Darcy wrote: > >> Dr Andrew John Hughes wrote: >> > > snip... > > [snip] > > Thanks Joe. Pavel pointed me to the discussion on the bug on the HotSpot lists. > It was on hotspot-runtime-dev which is why I missed it: > > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2010-November/001477.html > > As you can see from the discussion, the test is at fault. It only > works on 32-bit platforms and needs to be more generic to handle all > situations. Pavel's fix in IcedTea works for GNU/Linux platforms, but > AIUI will still run into difficulties on Solaris x86_64 where the > compiler produces 32-bit binaries by default. > > Just a quick comment on the test, the original test was clearly faulty was not running properly on all supported platforms. In particular, when I have to write a shell test like this, if it doesn't make sense to the run the test on, say, Windows, I'll have the test check for that platform (Windows or Cygwin) and vacuously pass in that case. -Joe From joe.darcy at oracle.com Wed Jan 19 13:32:40 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 19 Jan 2011 13:32:40 -0800 Subject: Backport 6642612 In-Reply-To: <4D34854F.3080305@redhat.com> References: <4D34854F.3080305@redhat.com> Message-ID: <4D375878.4070603@oracle.com> On 1/17/2011 10:07 AM, Omair Majid wrote: > Hi, > > I would like to backport the following changeset to openjdk6: > > changeset: 14:9a322f3dccd8 > user: rupashka > date: Wed Apr 30 13:01:01 2008 +0400 > summary: 6642612: JFileChooser approve buttons should use Open and > Save text (GTK) > > The summary is a little misleading; the changeset makes the "OK" and > "Cancel" buttons have the same size. > > Cheers, > Omair Hello. The change looks fine, but please went until b21 promotes before this gets pushed. Thanks, -Joe From joe.darcy at oracle.com Fri Jan 21 11:16:29 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 21 Jan 2011 11:16:29 -0800 Subject: [PING] Re: About time for b21? In-Reply-To: <4D3734C9.5010003@oracle.com> References: <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> Message-ID: <4D39DB8D.8010102@oracle.com> Joe Darcy wrote: [snip] > > > I'll start the internal procedures to generate the b21 source bundle. > > -Joe We've run into a problem with one of the internal build machines used by the promotion; we should have this problem resolved, and the source bundles posted, early next week. -Joe From denisl at openscg.com Fri Jan 21 12:07:15 2011 From: denisl at openscg.com (Lussier, Denis) Date: Fri, 21 Jan 2011 15:07:15 -0500 Subject: About time for b21? In-Reply-To: <4D39DB8D.8010102@oracle.com> References: <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> <4D39DB8D.8010102@oracle.com> Message-ID: Can I possibly get at the source bundles sooner so the OpenSCG one-click installers can be available at the same time as when the source bundles are officially on the website. On 1/21/11, Joe Darcy wrote: > Joe Darcy wrote: > > [snip] >> >> >> I'll start the internal procedures to generate the b21 source bundle. >> >> -Joe > > We've run into a problem with one of the internal build machines used by > the promotion; we should have this problem resolved, and the source > bundles posted, early next week. > > -Joe > From joe.darcy at oracle.com Fri Jan 21 12:19:20 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 21 Jan 2011 12:19:20 -0800 Subject: About time for b21? In-Reply-To: References: <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> <4D39DB8D.8010102@oracle.com> Message-ID: <4D39EA48.6020201@oracle.com> On 1/21/2011 12:07 PM, Lussier, Denis wrote: > Can I possibly get at the source bundles sooner so the OpenSCG > one-click installers can be available at the same time as when the > source bundles are officially on the website. No; the source bundles are generated as part of the promotion process. The sources in the bundles are planned to be equal to the current tip of the repositories; I will tag the repositories accordingly once the promotion occurs. -Joe From joe.darcy at oracle.com Fri Jan 21 16:10:21 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 21 Jan 2011 16:10:21 -0800 Subject: [PING] Re: About time for b21? -- b21 source bundle posted! In-Reply-To: <4D39DB8D.8010102@oracle.com> References: <4D192CF4.8020002@oracle.com> <20110107204648.GC17639@rivendell.middle-earth.co.uk> <4D2B5D76.70604@oracle.com> <20110110202427.GJ13053@rivendell.middle-earth.co.uk> <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> <4D39DB8D.8010102@oracle.com> Message-ID: <4D3A206D.405@oracle.com> Joe Darcy wrote: > Joe Darcy wrote: > > [snip] >> >> >> I'll start the internal procedures to generate the b21 source bundle. >> >> -Joe > > We've run into a problem with one of the internal build machines used > by the promotion; we should have this problem resolved, and the source > bundles posted, early next week. > > -Joe The build machine problem was resolved sooner than expected; the b21 bundle is now posted: http://download.java.net/openjdk/jdk6/promoted/b21/openjdk-6-src-b21-20_jan_2011.tar.gz On to b22! -Joe From joe.darcy at oracle.com Fri Jan 21 16:19:25 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 22 Jan 2011 00:19:25 +0000 Subject: hg: jdk6/jdk6/corba: Added tag jdk6-b21 for changeset 0d7037ddb07c Message-ID: <20110122001925.D195F47046@hg.openjdk.java.net> Changeset: c0574fd2e597 Author: darcy Date: 2011-01-21 16:18 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/corba/rev/c0574fd2e597 Added tag jdk6-b21 for changeset 0d7037ddb07c ! .hgtags From joe.darcy at oracle.com Fri Jan 21 16:20:13 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 22 Jan 2011 00:20:13 +0000 Subject: hg: jdk6/jdk6/hotspot: Added tag jdk6-b21 for changeset 2c8e1acf0433 Message-ID: <20110122002015.5F69247048@hg.openjdk.java.net> Changeset: 9797bcda6c12 Author: darcy Date: 2011-01-21 16:20 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/9797bcda6c12 Added tag jdk6-b21 for changeset 2c8e1acf0433 ! .hgtags From joe.darcy at oracle.com Fri Jan 21 16:20:44 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 22 Jan 2011 00:20:44 +0000 Subject: hg: jdk6/jdk6/jaxp: Added tag jdk6-b21 for changeset f87399eb1a3c Message-ID: <20110122002044.2446F4704A@hg.openjdk.java.net> Changeset: 954daf5cf0c2 Author: darcy Date: 2011-01-21 16:20 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxp/rev/954daf5cf0c2 Added tag jdk6-b21 for changeset f87399eb1a3c ! .hgtags From joe.darcy at oracle.com Fri Jan 21 16:21:16 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 22 Jan 2011 00:21:16 +0000 Subject: hg: jdk6/jdk6/jaxws: Added tag jdk6-b21 for changeset 66a6e7d96577 Message-ID: <20110122002116.09D174704C@hg.openjdk.java.net> Changeset: 24d2eaf5d3f1 Author: darcy Date: 2011-01-21 16:21 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxws/rev/24d2eaf5d3f1 Added tag jdk6-b21 for changeset 66a6e7d96577 ! .hgtags From joe.darcy at oracle.com Fri Jan 21 16:21:40 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 22 Jan 2011 00:21:40 +0000 Subject: hg: jdk6/jdk6/jdk: Added tag jdk6-b21 for changeset c267a33e76b0 Message-ID: <20110122002148.0FA1E4704F@hg.openjdk.java.net> Changeset: f7afe7a5e086 Author: darcy Date: 2011-01-21 16:21 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/f7afe7a5e086 Added tag jdk6-b21 for changeset c267a33e76b0 ! .hgtags From joe.darcy at oracle.com Fri Jan 21 16:23:36 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 22 Jan 2011 00:23:36 +0000 Subject: hg: jdk6/jdk6/langtools: Added tag jdk6-b21 for changeset a9479f61cd7e Message-ID: <20110122002338.29A2747051@hg.openjdk.java.net> Changeset: 0a1d1e4cca18 Author: darcy Date: 2011-01-21 16:23 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/0a1d1e4cca18 Added tag jdk6-b21 for changeset a9479f61cd7e ! .hgtags From joe.darcy at oracle.com Fri Jan 21 16:25:04 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 22 Jan 2011 00:25:04 +0000 Subject: hg: jdk6/jdk6: Added tag jdk6-b21 for changeset a38eed744370 Message-ID: <20110122002504.E903147053@hg.openjdk.java.net> Changeset: f05d53c4a6fb Author: darcy Date: 2011-01-21 16:24 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/f05d53c4a6fb Added tag jdk6-b21 for changeset a38eed744370 ! .hgtags From ahughes at redhat.com Fri Jan 21 17:08:59 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Sat, 22 Jan 2011 01:08:59 +0000 Subject: [PING] Re: About time for b21? -- b21 source bundle posted! In-Reply-To: <4D3A206D.405@oracle.com> References: <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> <4D39DB8D.8010102@oracle.com> <4D3A206D.405@oracle.com> Message-ID: <20110122010859.GF21893@rivendell.middle-earth.co.uk> On 16:10 Fri 21 Jan , Joe Darcy wrote: > Joe Darcy wrote: > > Joe Darcy wrote: > > > > [snip] > >> > >> > >> I'll start the internal procedures to generate the b21 source bundle. > >> > >> -Joe > > > > We've run into a problem with one of the internal build machines used > > by the promotion; we should have this problem resolved, and the source > > bundles posted, early next week. > > > > -Joe > > The build machine problem was resolved sooner than expected; the b21 > bundle is now posted: > http://download.java.net/openjdk/jdk6/promoted/b21/openjdk-6-src-b21-20_jan_2011.tar.gz > And clearly it entered a time machine too if it was released on the 20th -- in the UK, we've just entered the 22nd ;-) > On to b22! > Hurrah! > -Joe Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Fri Jan 21 17:12:48 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 21 Jan 2011 17:12:48 -0800 Subject: [PING] Re: About time for b21? -- b21 source bundle posted! In-Reply-To: <20110122010859.GF21893@rivendell.middle-earth.co.uk> References: <4D2B6BED.3080505@oracle.com> <4D2C96A7.4090209@oracle.com> <20110111181900.GK28602@rivendell.middle-earth.co.uk> <4D2CB121.7030407@oracle.com> <20110111210337.GR28602@rivendell.middle-earth.co.uk> <4D35F7B9.3010102@oracle.com> <20110118232638.GH14019@rivendell.middle-earth.co.uk> <4D3734C9.5010003@oracle.com> <4D39DB8D.8010102@oracle.com> <4D3A206D.405@oracle.com> <20110122010859.GF21893@rivendell.middle-earth.co.uk> Message-ID: <4D3A2F10.60608@oracle.com> On 1/21/2011 5:08 PM, Dr Andrew John Hughes wrote: > On 16:10 Fri 21 Jan , Joe Darcy wrote: >> Joe Darcy wrote: >>> Joe Darcy wrote: >>> >>> [snip] >>>> >>>> >>>> I'll start the internal procedures to generate the b21 source bundle. >>>> >>>> -Joe >>> We've run into a problem with one of the internal build machines used >>> by the promotion; we should have this problem resolved, and the source >>> bundles posted, early next week. >>> >>> -Joe >> The build machine problem was resolved sooner than expected; the b21 >> bundle is now posted: >> http://download.java.net/openjdk/jdk6/promoted/b21/openjdk-6-src-b21-20_jan_2011.tar.gz >> > And clearly it entered a time machine too if it was released on the 20th -- in the UK, we've just entered the 22nd ;-) > Yes, I considered commenting about that -- the build process was started on the 20th but only completed on the 21st given the machine failure. -Joe