[PING] Re: About time for b21?

[Joe Darcy]

Joe Darcy wrote:
> On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote:
>> On 11:26 Mon 10 Jan     , Joe Darcy wrote:
>>
>> snip...
>>
>>> Hello.
>>>
>>> Since you haven't run into any issues with having 7002666 in IcedTea6
>>> 1.9, I'm satisfied to have it this build of OpenJDK 6, which should
>>> bring b21 to a close!
>>>
>>> -Joe
>> I've pushed 7002666:
>>
>> http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee
>>
>> along with two PNG backports that were approved for Deepak Bhole some 
>> time
>> ago but were never done:
>>
>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d
>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0
>>
>> (copyright headers updated appropriately).
>>
>> Let's get b21 out the door! :-)
>
> Agreed!  Later this week, I'll go through my pre-promotion build and 
> test cycle.
>
> -Joe

When running the HotSpot regression tests, I see two failures:

Compilation failed: Compilation failed

    * gc/6581734/Test6581734.java : CMS Old Gen's collection usage is 
zero after GC which is incorrect

Execution failed: exit code 127

    * runtime/6929067/Test6929067.sh : Stack guard pages should be 
removed when thread is detached

The first is due to a typo in the test case; I approve the backport of 
6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo"
    http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334
to fix this.

The second test seems to make platform assumptions that aren't always 
true, but after some looking around I don't see an existing fix in the 
HotSpot repos.

At least the first should be fixed before b21 promotes.

-Joe