<AWT Dev> Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction

[Dr Andrew John Hughes]

On 10:10 Thu 13 Jan     , Coleen Phillimore wrote:
> On 1/13/2011 9:09 AM, Dr Andrew John Hughes wrote:
> > On 19:55 Wed 12 Jan     , Coleen Phillimore wrote:
> >> I have to read this bug and reread this thread, but I just backed out
> >> the change for 6938627 which I believe was the cause of this bug too.
> >> Hotspot will not use java.io.tmpdir to get a temporary directory, it
> >> will use the system temporary directory.  There was a JDK change in jdk
> >> 7 that also has to be refixed that Alan's going to do (bug 6950927:
> >> Testcase failure
> >> sun/management/jmxremote/bootstrap/JvmstatCountersTest.java)
> >>
> >> See bug 7009828: Fix for 6938627 breaks visualvm monitoring when
> >> -Djava.io.tmpdir is defined
> >>
> >> Now, I've read your bug 7003327  - you can filter hsperfdata but it
> >> won't be there anymore.
> >>
> > Well, it will if:
> >
> > changeset:   1999:34d64ad817f4
> > tag:         tip
> > user:        coleenp
> > date:        Wed Jan 12 13:59:18 2011 -0800
> > summary:     7009828: Fix for 6938627 breaks visualvm monitoring when -Djava.io.tmpdir is defined
> >
> > is backported to OpenJDK6.  Joe, should we do this?  It only seems to be in
> > the hotspot-rt tree so far.
> >
> After a couple rounds of testing, this change should be in hs20 which 
> will be in jdk6u25.  I don't know how it gets into openjdk6.  I can 
> barely follow our own release model.  

'our'?

> I don't think you want to port it 
> individually though.
> 

OpenJDK6 is currently tracking the hs19 stable branch which has
6938627 and hence this regression (including the broken AWT test).
Can you explain why it would not make sense to fix it?  There doesn't
seem to be a stable branch for hs20 on http://hg.openjdk.java.net yet
so it won't be imported into OpenJDK6 any time soon.

> Coleen
> >> Coleen
> >>
> >> On 1/12/2011 7:20 PM, Joe Darcy wrote:
> >>> Joe Darcy wrote:
> >>>> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote:
> >>>>> Phil Race wrote:
> >>>>>> Pavel,
> >>>>>>
> >>>>>> The font implementation and tests are 2D. Not AWT. Don't get thrown by
> >>>>>> package names.
> >>>>> Ah sorry, you are right, of course.
> >>>>>> I was a bit curious about the real reason for this failure.
> >>>>>> I wrote this test a couple of years ago and its never failed before.
> >>>>>> I don't see it failing on any 6-open build.
> >>>>>> I see it failing only in JDK 7 from b90. That seems to be due to
> >>>>>> HS18b03
> >>>>>> fix
> >>>>>> 6938627: Make temporary directory use property java.io.tmpdir when
> >>>>>> specified
> >>>>> It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses
> >>>>> some backports from OpenJDK 7 (from the log files I can only infer that
> >>>>> this bug first appeared in IcedTea6 when the hs19 were set as default
> >>>>> HotSpot on 2010-10-19). Is it still possible to push the test
> >>>>> correction
> >>>>> to OpenJDK 6 too, or only to OpenJDK 7?
> >>>>>
> >>>>> Also I'll need a bug id please.
> >>>>>
> >>>> Sorry for the belated reply, please use
> >>>>
> >>>> 7003327 Correct test awt/FontClass/CreateFont/DeleteFont
> >>>>
> >>>> Approved for OpenJDK 6.
> >>>>
> >>>> -Joe
> >>> Hello.
> >>>
> >>> If this can be pushed in the next day or two, I'm open to having this
> >>> bug fix in b21.
> >>>
> >>> Thanks,
> >>>
> >>> -Joe
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8