Reviewer needed - deletion of regression tests compiler/6987555/Test6987555.java and compiler/6991596/Test6991596.java

Pavel Tisnovsky ptisnovs at redhat.com
Mon May 9 09:48:42 PDT 2011


Kelly O'Hair wrote:
> Assuming that the -XX options used to start up the test don't cause issues, that might work.
> 
> I assume you are suggesting adding something like this to the main() method:
>   if ( System.getProperty("java.version").startsWith("1.6") ) return;
> 
> ??? Someone would need to experiment and see if that works.

Hi Kelly and Joe,

I'll try it and if it will work, I'll send another webrev, ok?

Pavel

> 
> -kto
> 
> On May 9, 2011, at 9:28 AM, Joe Darcy wrote:
> 
>> The tests could be guarded by a wrapper program that tested the platform version and just vacuously passed on a JDK 6.
>>
>> -Joe
>>
>> Kelly O'Hair wrote:
>>> I'm not sure what to say here. It's part of hotspot, and will likely always be part of hotspot going forward.
>>> I understand the need to not have them, but I'm concerned that the files will just keep coming back each time
>>> the openjdk6 hotspot sources get upgraded.
>>>
>>> Marking the tests @ignore might be better, unless someone else has a better idea?
>>>
>>> -kto
>>>
>>> On May 5, 2011, at 8:50 AM, Pavel Tisnovsky wrote:
>>>
>>>  
>>>> Hi all,
>>>>
>>>> I think that two regression tests, namely
>>>> compiler/6987555/Test6987555.java and compiler/6991596/Test6991596.java
>>>> should be removed from OpenJDK6 because these tests checks JSR-292
>>>> functionality and IMHO this functionality is not part of JDK6.
>>>>
>>>> I prepared webrev containing changes (test deletion) which is available at:
>>>> http://cr.openjdk.java.net/~ptisnovs/jtreg-remove-tests-6987555-6991596/
>>>>
>>>> Can anybody please review these changes?
>>>>
>>>> Thank you in advance,
>>>> Pavel Tisnovsky
>>>>    
>>>  
> 



More information about the jdk6-dev mailing list