code review request: 7110373: krb5 test in openjdk6 without test infrastructure (was Re: test failure security/krb5/auto/SpnegoReqFlags.java [was - Re: OpenJDK6 B24])

[Sean Mullan]

Looks fine to me.

--Sean

On 11/10/2011 02:34 AM, Weijun Wang wrote:
> Please take a review.
>
> http://cr.openjdk.java.net/~weijun/7110373/webrev.00/
>
> It's just removing the test file.
>
> BTW, I've added subCR of 6-open for 6815182 and 6979329 in our bug
> database and marked them Fix Available. Seems they were never created.
>
> Thanks
> Weijun
>
> On 11/10/2011 11:18 AM, Lana Steuck wrote:
>> Below is an update about OpenJdk6 b24 release.
>>
>> There were a number of minor issues with the build (infrastructure, not
>> related to jdk6 code) which got resolved.
>> I had built openjdk6 on all 8 platforms. There is a new test failure on
>> linux_i586 (and all other platforms).
>>
>> TEST: sun/security/krb5/auto/SpnegoReqFlags.java
>> TEST RESULT: Failed. Compilation failed: Compilation failed
>> (detailed error message is below).
>>
>> By looking at the openjdk archive, it seemed that the test was
>> backported from 7 on Sep 6, 2011.
>> Email Request:
>> http://mail.openjdk.java.net/pipermail/jdk6-dev/2011-September/002506.html
>>
>> Hg notification:
>> http://mail.openjdk.java.net/pipermail/jdk6-dev/2011-September/002511.html
>>
>>
>> Weijun Wang from JDK Security team looked at the failure (thank you,
>> Weijun!), below is his explanation:
>>
>> > If you look at the same directory in JDK 7
>> (http://hg.openjdk.java.net/jdk7/tl/jdk/file/tip/test/sun/security/krb5/auto/),
>>
>>
>> > it's a big test infrastructure and each @test needs at least 4 other
>> files to compile.
>>
>> The test infrastructure was not pushed when this test was backported to
>> 6. Weijun suggested to remove the test for the time being and continue
>> with the release (again, thank you, Weijun, for doing this!)
>>
>> Once this is done, I'll restart the release process.
>>
>> Thanks,
>> Lana
>>
>> ----
>> TEST: sun/security/krb5/auto/SpnegoReqFlags.java
>> JDK under test:
>> (/tmp/jprt/P1/213343.jcg-integrator/testproduct/linux_i586_2.6-product)
>> openjdk version "1.6.0-internal"
>> OpenJDK Runtime Environment (build
>> 1.6.0-internal-jprtadm_09_nov_2011_13_38-b00)
>> OpenJDK Server VM (build 20.0-b12, mixed mode)
>>
>> ACTION: build -- Failed. Compilation failed: Compilation failed
>> REASON: Named class compiled on demand
>> TIME: 0.75 seconds
>> messages:
>> command: build SpnegoReqFlags
>> reason: Named class compiled on demand
>> elapsed time (seconds): 0.75
>>
>> ACTION: compile -- Failed. Compilation failed: Compilation failed
>> REASON: .class file out of date or does not exist
>> TIME: 0.749 seconds
>> messages:
>> command: compile
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java
>>
>>
>> reason: .class file out of date or does not exist
>> elapsed time (seconds): 0.749
>> STDOUT:
>> STDERR:
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:30:
>>
>> warning: sun.security.jgss.GSSUtil is internal proprietary API and may
>> be removed in a future release
>> import sun.security.jgss.GSSUtil;
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:31:
>>
>> warning: sun.security.util.BitArray is internal proprietary API and may
>> be removed in a future release
>> import sun.security.util.BitArray;
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:32:
>>
>> warning: sun.security.util.DerInputStream is internal proprietary API
>> and may be removed in a future release
>> import sun.security.util.DerInputStream;
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:33:
>>
>> warning: sun.security.util.DerValue is internal proprietary API and may
>> be removed in a future release
>> import sun.security.util.DerValue;
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:41:
>>
>> cannot find symbol
>> symbol : class OneKDC
>> location: class SpnegoReqFlags
>> new OneKDC(null).writeJAASConf();
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:46:
>>
>> cannot find symbol
>> symbol : class Context
>> location: class SpnegoReqFlags
>> Context c = Context.fromJAAS("client");
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:46:
>>
>> cannot find symbol
>> symbol : variable Context
>> location: class SpnegoReqFlags
>> Context c = Context.fromJAAS("client");
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:47:
>>
>> cannot find symbol
>> symbol : variable OneKDC
>> location: class SpnegoReqFlags
>> c.startAsClient(OneKDC.SERVER, GSSUtil.GSS_SPNEGO_MECH_OID);
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:47:
>>
>> warning: sun.security.jgss.GSSUtil is internal proprietary API and may
>> be removed in a future release
>> c.startAsClient(OneKDC.SERVER, GSSUtil.GSS_SPNEGO_MECH_OID);
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:49:
>>
>> cannot find symbol
>> symbol : class Action
>> location: class SpnegoReqFlags
>> byte[] token = c.doAs(new Action() {
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:59:
>>
>> warning: sun.security.util.DerValue is internal proprietary API and may
>> be removed in a future release
>> DerValue d = new DerValue(token); // GSSToken
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:59:
>>
>> warning: sun.security.util.DerValue is internal proprietary API and may
>> be removed in a future release
>> DerValue d = new DerValue(token); // GSSToken
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:60:
>>
>> warning: sun.security.util.DerInputStream is internal proprietary API
>> and may be removed in a future release
>> DerInputStream ins = d.data; // OID + mech token
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:70:
>>
>> warning: sun.security.util.DerValue is internal proprietary API and may
>> be removed in a future release
>> DerValue d2 = d.data.getDerValue();
>> ^
>> /tmp/jprt/P1/213343.jcg-integrator/source/jdk/test/sun/security/krb5/auto/SpnegoReqFlags.java:74:
>>
>> warning: sun.security.util.BitArray is internal proprietary API and may
>> be removed in a future release
>> BitArray ba = d2.data.getUnalignedBitString();
>> ^
>> 5 errors
>> 10 warnings
>>
>> TEST RESULT: Failed. Compilation failed: Compilation failed
>>
>>
>> On 11/03/2011 12:01 PM, Kelly O'Hair wrote:
>>> FYI...
>>>
>>> All security changes have been verified and are in the OpenJDK6 repos.
>>>
>>> We are starting the release process for OpenJDK6 B24.
>>>
>>> -kto
>>>