Need reviewer: fix to prtconf on solaris builds

Kelly O'Hair kelly.ohair at oracle.com
Wed Jan 4 13:51:30 PST 2012


You are right.

I will submit another change (to 8, 7, and 6-open) that will deal with both these issues

7127104: Build issue with prtconf and zones, also using := to avoid extra execs

-kto

On Jan 4, 2012, at 12:03 PM, David Katleman wrote:

> On 1/4/2012 11:27 AM, Kelly O'Hair wrote:
>> Openjdk6 change... creates annoying error messages during builds on solaris without it.
>> 
>> Don't really need a reviewer since the same exact change was pushed into jdk7 a while back by Katleman.
>> 
>> 7022473: JDK7 still runs /etc/prtconf to find memory size
>> http://cr.openjdk.java.net/~ohair/openjdk6/openjdk6-prtconf/webrev/
>> 
>> 
>> David? This look ok?
> 
> It looks identical to the original fix, which I am just now noticing that while it works, it should use ":=" rather than "=".
> 
> Unless we really need to keep looking up the memory every time $(MB_OF_MEMORY) is referenced, which isn't a trival number.
> 
> Side note, I know it's just a port, but I've noticed of late that prtconf doesn't function in Solaris zones, returning "prtconf: devinfo facility not available"
> 
>            Dave



More information about the jdk6-dev mailing list