Request for approval of 7162476 sync/merge into OpenJDK6

[Andrew Hughes]

----- Original Message -----
> > http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/78e01a6ca8d3
>  >
>  > is a completely different changeset (but with the same bug ID)
>  > which
> reverts changes in
>  > S7162476.  The bug&  original change explain why the empty
>  > BoolEditor
>  > and IntEditor classes were added, but not why all these classes
>  > were
> moved
>  > back to sun.beans.editors.  Can you explain this please?
> 
> This fix does not revert changes from the 7162476 fix.  It introduces
> temporary classes in the sun.beans.editors package which extend
> classes
> from the com.sun.beans.editors package. The reason is the same: the
> customer uses JavaBeans editors directly and he have no time to
> update
> its application before Java release.
> 

Ah ok.  Can you point me to where that recent change was reviewed?

> Thanks,
> SAM
> 
> On 03.09.2012 16:29, Andrew Hughes wrote:
> > ----- Original Message -----
> >>>> Presumably we also want the consequent regression fix:
> >>   >>  http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/78e01a6ca8d3
> >>
> >>   >  As per Eng, this fix is only for 7ux and
> >>   >  do we see the same issue with 6-open ?
> >>   >  Sergei, please comment.
> >>
> >> The 7182135 issue is a temporary fix for the customer who can't
> >> update
> >> its application in time.  We will not include this fix into JDK 8
> >> and,
> >> probably, will remove it from JDK 7 later.  The 7182135 issue is
> >> not
> >> the
> >> regression fix because of the following warning:
> >> http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
> >>
> >
> > This was mentioned on this review:
> >
> > http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-July/003715.html
> >
> > but:
> >
> > http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/78e01a6ca8d3
> >
> > is a completely different changeset (but with the same bug ID)
> > which reverts changes in
> > S7162476.  The bug&  original change explain why the empty
> > BoolEditor
> > and IntEditor classes were added, but not why all these classes
> > were moved
> > back to sun.beans.editors.  Can you explain this please?
> >
> >> Thanks,
> >> SAM
> >>
> >> On 01.09.2012 1:00, Abhijit Saha wrote:
> >>> On 8/31/2012 1:41 PM, Andrew Hughes wrote:
> >>>> ----- Original Message -----
> >>>>> Approved.
> >>>>>
> >>>>> -kto
> >>>>>
> >>>>> On Aug 31, 2012, at 11:04 AM, Abhijit Saha wrote:
> >>>>>
> >>>>>> With Oracle security alert [1] went live yesterday, we've to
> >>>>>> sync
> >>>>>> one fix # 7162476 in OpenJDK6.
> >>>>>>
> >>>>>>
> >>>>>> Here's the webrev/changes for this merge/sync.
> >>>>>> http://cr.openjdk.java.net/~asaha/6u35-ER-openJDK6/webrev.1/
> >>>>>>
> >>>>>>
> >>>>>> Please review&  approve for this push also comment if any
> >>>>>> concern.
> >>>>>>
> >>>>>>
> >>>>>> Thanks
> >>>>>> Abhijit
> >>>>>>
> >>>>>>
> >>>>>> [1]
> >>>>>> http://www.oracle.com/technetwork/topics/security/alerts-086861.html
> >>>>>>
> >>>>>> --
> >>>>>> Release Lead, Java SE Updates
> >>>>>> Java Platform Group
> >>>>>> Oracle Corporation.
> >>>>>> (408)276-7564
> >>>>>>
> >>>>>
> >>>> Presumably we also want the consequent regression fix:
> >>>>
> >>>> http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/78e01a6ca8d3
> >>> As per Eng, this fix is only for 7ux and do we see the same issue
> >>> with
> >>> 6-open ?
> >>>
> >>> Sergei, developer of this fix, has been included here.
> >>>
> >>> Sergei,
> >>> Please comment.
> >>>
> >>> Thanks
> >>> Abhijit
> >>>
> >>
> >
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07