From gnu.andrew at redhat.com Mon Dec 2 07:08:09 2013 From: gnu.andrew at redhat.com (Andrew) Date: Mon, 2 Dec 2013 10:08:09 -0500 (EST) Subject: [PATCH] Resolve Windows build issues In-Reply-To: <5297A22C.6080806@alexkasko.com> References: <1238132046.2499982.1385579355037.JavaMail.root@redhat.com> <781587320.2500980.1385579641628.JavaMail.root@redhat.com> <20131127205841.GA8303@redhat.com> <2055188899.2583058.1385597251179.JavaMail.root@redhat.com> <5297A22C.6080806@alexkasko.com> Message-ID: <328517854.4159127.1385996889567.JavaMail.root@redhat.com> ----- Original Message ----- > Hi, > > On 11/28/2013 04:07 AM, Andrew wrote: > > > > > > ----- Original Message ----- > >> * Andrew [2013-11-27 14:17]: > >>> Webrev: http://cr.openjdk.java.net/~andrew/openjdk6/20131015/winmerge/ > >>> > >>> This contains Alex's fix for the SA along with a fix for the merge issues > >>> in compile.make. The latter is different to both previous versions > >>> published > >>> by Alex and, I believe, the correct version, which I obtained by diffing > >>> against > >>> the version in 7 and checking all if blocks were matched. > >>> > >>> The new patch: > >>> > >>> 1. Moves the /SAFESEH flag into the correct section (out of the > >>> COMPILER_NAME block and > >>> into the compiler settings for VS2008, like the other instances in that > >>> file). > >>> 2. Removes the broken if block in the VS2010 settings. > >>> 3. Places the full if block with other linker settings further down. > >> > >> I am not familiar with windows build systems at all, but the approach > >> certainly looks correct to me. If this makes more things match upstream > >> 7u, then this is definitely a step in the right direction. > >> > >> Thanks, > >> Omair > >> > >> -- > >> PGP Key: 66484681 (http://pgp.mit.edu/) > >> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > >> > > > > I'll wait for Alex to test before pushing. > > amd64 windows build works fine. And I realised that my jdk6-windows-i586 > build stand is broken badly - some kind of virus that rewrites > executables. So please disregard my notes about SAFESEH. I won't be able > to test i586 build for some time (until I recreate the stand) so I think > it is better to push compile.make changes and leave sa.make intact (with > SAFESEH flag enabled). Sorry for the noise. > Well, the flag is x86 only so you wouldn't see anything on x86_64 (it's effectively always on, as far as I can tell). I'll drop the SA changes and push, if that's ok with Omair. > > > > The only remaining differences with 7 are some checks from another patch > > and the kernel section which is only present in 6. The above fixes what > > were clearly issues from a bad merge (lines added in the wrong places). > > > > > -- > Regards, > Alex Kasko > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From omajid at redhat.com Mon Dec 2 07:33:37 2013 From: omajid at redhat.com (Omair Majid) Date: Mon, 2 Dec 2013 10:33:37 -0500 Subject: [PATCH] Resolve Windows build issues In-Reply-To: <328517854.4159127.1385996889567.JavaMail.root@redhat.com> References: <1238132046.2499982.1385579355037.JavaMail.root@redhat.com> <781587320.2500980.1385579641628.JavaMail.root@redhat.com> <20131127205841.GA8303@redhat.com> <2055188899.2583058.1385597251179.JavaMail.root@redhat.com> <5297A22C.6080806@alexkasko.com> <328517854.4159127.1385996889567.JavaMail.root@redhat.com> Message-ID: <20131202153336.GB3235@redhat.com> * Andrew [2013-12-02 10:11]: > I'll drop the SA changes and push, if that's ok with Omair. This works for me. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From gnu.andrew at redhat.com Mon Dec 2 23:59:55 2013 From: gnu.andrew at redhat.com (gnu.andrew at redhat.com) Date: Tue, 03 Dec 2013 07:59:55 +0000 Subject: hg: jdk6/jdk6/hotspot: OPENJDK6-23: Resolve merge issues in 8015614. Message-ID: <20131203080000.318D3629B1@hg.openjdk.java.net> Changeset: c2e524f26e19 Author: andrew Date: 2013-12-03 07:15 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/c2e524f26e19 OPENJDK6-23: Resolve merge issues in 8015614. Reviewed-by: omajid ! make/windows/makefiles/compile.make From roberto.gomez at ext.produban.com Thu Dec 5 01:19:28 2013 From: roberto.gomez at ext.produban.com (Gomez Ballesteros Roberto) Date: Thu, 5 Dec 2013 09:19:28 +0000 Subject: OpenJDK version Message-ID: <6FCB747EE14875458B2A59E946F2B6B7166332F1@VMESCL100XCMP10.cloud.corp> Hello. I'm looking for the latest stable version of the OpenJDK 1.6 and can not find it. From where I can download it? I want a compressed file if possible. Regards . Roberto G?mez. ________________________________ Antes de imprimir este mensaje o sus documentos anexos, aseg?rese de que es necesario. Proteger el medio ambiente est? en nuestras manos. Before printing this e-mail or attachments, be sure it is necessary. It is in our hands to protect the environment. ******************AVISO LEGAL********************** Este mensaje es privado y confidencial y solamente para la persona a la que va dirigido. Si usted ha recibido este mensaje por error, no debe revelar, copiar, distribuir o usarlo en ning?n sentido. Le rogamos lo comunique al remitente y borre dicho mensaje y cualquier documento adjunto que pudiera contener. No hay renuncia a la confidencialidad ni a ning?n privilegio por causa de transmisi?n err?nea o mal funcionamiento. Cualquier opini?n expresada en este mensaje pertenece ?nicamente al autor remitente, y no representa necesariamente la opini?n de Grupo Santander, a no ser que expresamente se diga y el remitente est? autorizado para hacerlo. Los correos electr?nicos no son seguros, no garantizan la confidencialidad ni la correcta recepci?n de los mismos, dado que pueden ser interceptados, manipulados, destruidos, llegar con demora, incompletos, o con virus. Grupo Santander no se hace responsable de las alteraciones que pudieran hacerse al mensaje una vez enviado. Este mensaje s?lo tiene una finalidad de informaci?n, y no debe interpretarse como una oferta de venta o de compra de valores ni de instrumentos financieros relacionados. En el caso de que el destinatario de este mensaje no consintiera la utilizaci?n del correo electr?nico v?a Internet, rogamos lo ponga en nuestro conocimiento. **********************DISCLAIMER***************** This message is private and confidential and it is intended exclusively for the addressee. If you receive this message by mistake, you should not disseminate, distribute or copy this e-mail. Please inform the sender and delete the message and attachments from your system. No confidentiality nor any privilege regarding the information is waived or lost by any mistransmission or malfunction. Any views or opinions contained in this message are solely those of the author, and do not necessarily represent those of Grupo Santander, unless otherwise specifically stated and the sender is authorized to do so. E-mail transmission cannot be guaranteed to be secure, confidential, or error-free, as information could be intercepted, corrupted, lost, destroyed, arrive late, incomplete, or contain viruses. Grupo Santander does not accept responsibility for any changes in the contents of this message after it has been sent. This message is provided for informational purposes and should not be construed as a solicitation or offer to buy or sell any securities or related financial instruments. If the addressee of this message does not consent to the use of internet e-mail, please communicate it to us. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20131205/b87b2018/attachment.html From mail at alexkasko.com Thu Dec 5 02:04:54 2013 From: mail at alexkasko.com (Alex Kasko) Date: Thu, 05 Dec 2013 14:04:54 +0400 Subject: OpenJDK version In-Reply-To: <6FCB747EE14875458B2A59E946F2B6B7166332F1@VMESCL100XCMP10.cloud.corp> References: <6FCB747EE14875458B2A59E946F2B6B7166332F1@VMESCL100XCMP10.cloud.corp> Message-ID: <52A04FC6.2070804@alexkasko.com> Hi, On 12/05/2013 01:19 PM, Gomez Ballesteros Roberto wrote: > Hello. > > I'm looking for the latest stable version of the OpenJDK 1.6 and can not find it. From where I can download it? > I want a compressed file if possible. Information about b28 source release is here - http://mail.openjdk.java.net/pipermail/jdk6-dev/2013-October/003084.html > > Regards . > Roberto G?mez. > > > ________________________________ > Antes de imprimir este mensaje o sus documentos anexos, aseg?rese de que es necesario. > Proteger el medio ambiente est? en nuestras manos. > > Before printing this e-mail or attachments, be sure it is necessary. > It is in our hands to protect the environment. > > ******************AVISO LEGAL********************** > Este mensaje es privado y confidencial y solamente para la persona a la que va dirigido. Si usted ha recibido este mensaje por error, no debe revelar, copiar, distribuir o usarlo en ning?n sentido. Le rogamos lo comunique al remitente y borre dicho mensaje y cualquier documento adjunto que pudiera contener. No hay renuncia a la confidencialidad ni a ning?n privilegio por causa de transmisi?n err?nea o mal funcionamiento. > Cualquier opini?n expresada en este mensaje pertenece ?nicamente al autor remitente, y no representa necesariamente la opini?n de Grupo Santander, a no ser que expresamente se diga y el remitente est? autorizado para hacerlo. Los correos electr?nicos no son seguros, no garantizan la confidencialidad ni la correcta recepci?n de los mismos, dado que pueden ser interceptados, manipulados, destruidos, llegar con demora, incompletos, o con virus. Grupo Santander no se hace responsable de las alteraciones que pudieran hacerse al mensaje una vez enviado. > Este mensaje s?lo tiene una finalidad de informaci?n, y no debe interpretarse como una oferta de venta o de compra de valores ni de instrumentos financieros relacionados. En el caso de que el destinatario de este mensaje no consintiera la utilizaci?n del correo electr?nico v?a Internet, rogamos lo ponga en nuestro conocimiento. > > > **********************DISCLAIMER***************** > This message is private and confidential and it is intended exclusively for the addressee. If you receive this message by mistake, you should not disseminate, distribute or copy this e-mail. Please inform the sender and delete the message and attachments from your system. No confidentiality nor any privilege regarding the information is waived or lost by any mistransmission or malfunction. > Any views or opinions contained in this message are solely those of the author, and do not necessarily represent those of Grupo Santander, unless otherwise specifically stated and the sender is authorized to do so. E-mail transmission cannot be guaranteed to be secure, confidential, or error-free, as information could be intercepted, corrupted, lost, destroyed, arrive late, incomplete, or contain viruses. Grupo Santander does not accept responsibility for any changes in the contents of this message after it has been sent. > This message is provided for informational purposes and should not be construed as a solicitation or offer to buy or sell any securities or related financial instruments. If the addressee of this message does not consent to the use of internet e-mail, please communicate it to us. > > > -- Regards, Alex Kasko -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3742 bytes Desc: S/MIME Cryptographic Signature Url : http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20131205/714d5e57/smime.p7s From aph at redhat.com Thu Dec 5 02:08:22 2013 From: aph at redhat.com (Andrew Haley) Date: Thu, 05 Dec 2013 10:08:22 +0000 Subject: OpenJDK version In-Reply-To: <6FCB747EE14875458B2A59E946F2B6B7166332F1@VMESCL100XCMP10.cloud.corp> References: <6FCB747EE14875458B2A59E946F2B6B7166332F1@VMESCL100XCMP10.cloud.corp> Message-ID: <52A05096.5010008@redhat.com> On 12/05/2013 09:19 AM, Gomez Ballesteros Roberto wrote: > This message is private and confidential and it is intended > exclusively for the addressee. I'm sorry, we cannot accept emails with such disclaimers. Such disclaimers are inappropriate for mail sent to public lists. If your company automatically adds something like this to outgoing mail, and you can't convince them to stop, you might consider using a free web-based e-mail account. Andrew. From omajid at redhat.com Thu Dec 5 08:19:13 2013 From: omajid at redhat.com (Omair Majid) Date: Thu, 5 Dec 2013 11:19:13 -0500 Subject: Starting OpenJDK6 B29 promotion process Message-ID: <20131205161913.GA19634@redhat.com> Hi, I will be starting the OpenJDK6 B29 promotion (will be tagged with jdk6-b29). This is meant to be a security-only update. Please hold off any non-security related changes. Let me know ASAP if there are any remaining changes to consider for this OpenJDK6 release, otherwise I will proceed with the process. The general release process is documented [1], but I will be deviating from it slightly since Oracle Release Engineering is not involved. Thanks, Omair [1] http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/ReleaseProcess.html -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From omajid at redhat.com Thu Dec 5 15:56:53 2013 From: omajid at redhat.com (Omair Majid) Date: Thu, 5 Dec 2013 18:56:53 -0500 Subject: Starting OpenJDK6 B29 promotion process In-Reply-To: <20131205161913.GA19634@redhat.com> References: <20131205161913.GA19634@redhat.com> Message-ID: <20131205235653.GH19634@redhat.com> * Omair Majid [2013-12-05 11:22]: > I will be starting the OpenJDK6 B29 promotion (will be tagged with > jdk6-b29). I am starting the process, please defer all changes until the release is complete. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From omajid at redhat.com Thu Dec 5 17:46:08 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 01:46:08 +0000 Subject: hg: jdk6/jdk6/corba: Added tag jdk6-b29 for changeset 4a15d8b1c94a Message-ID: <20131206014609.F033E62B05@hg.openjdk.java.net> Changeset: 47195b885932 Author: omajid Date: 2013-12-05 20:12 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/corba/rev/47195b885932 Added tag jdk6-b29 for changeset 4a15d8b1c94a ! .hgtags From omajid at redhat.com Thu Dec 5 17:45:59 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 01:45:59 +0000 Subject: hg: jdk6/jdk6: Added tag jdk6-b29 for changeset 40fdf5625e54 Message-ID: <20131206014559.674B062B04@hg.openjdk.java.net> Changeset: ab23d2131658 Author: omajid Date: 2013-12-05 20:12 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/ab23d2131658 Added tag jdk6-b29 for changeset 40fdf5625e54 ! .hgtags From omajid at redhat.com Thu Dec 5 17:46:53 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 01:46:53 +0000 Subject: hg: jdk6/jdk6/jaxws: Added tag jdk6-b29 for changeset 4ea4a060f374 Message-ID: <20131206014657.6F86B62B08@hg.openjdk.java.net> Changeset: c74cb93ad96e Author: omajid Date: 2013-12-05 20:12 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxws/rev/c74cb93ad96e Added tag jdk6-b29 for changeset 4ea4a060f374 ! .hgtags From omajid at redhat.com Thu Dec 5 17:46:21 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 01:46:21 +0000 Subject: hg: jdk6/jdk6/hotspot: Added tag jdk6-b29 for changeset c2e524f26e19 Message-ID: <20131206014625.ADA4362B06@hg.openjdk.java.net> Changeset: d835d67bfb88 Author: omajid Date: 2013-12-05 20:12 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/d835d67bfb88 Added tag jdk6-b29 for changeset c2e524f26e19 ! .hgtags From omajid at redhat.com Thu Dec 5 17:47:13 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 01:47:13 +0000 Subject: hg: jdk6/jdk6/jdk: Added tag jdk6-b29 for changeset 008e31b76d41 Message-ID: <20131206014731.2A8F962B09@hg.openjdk.java.net> Changeset: 956e1047786a Author: omajid Date: 2013-12-05 20:12 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/956e1047786a Added tag jdk6-b29 for changeset 008e31b76d41 ! .hgtags From omajid at redhat.com Thu Dec 5 17:47:45 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 01:47:45 +0000 Subject: hg: jdk6/jdk6/langtools: Added tag jdk6-b29 for changeset e6d4480e2b11 Message-ID: <20131206014749.268B162B0A@hg.openjdk.java.net> Changeset: 926d58109647 Author: omajid Date: 2013-12-05 20:12 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/926d58109647 Added tag jdk6-b29 for changeset e6d4480e2b11 ! .hgtags From omajid at redhat.com Thu Dec 5 17:46:35 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 01:46:35 +0000 Subject: hg: jdk6/jdk6/jaxp: Added tag jdk6-b29 for changeset 05c35de6d704 Message-ID: <20131206014638.0C5DB62B07@hg.openjdk.java.net> Changeset: f7f424a94764 Author: omajid Date: 2013-12-05 20:12 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxp/rev/f7f424a94764 Added tag jdk6-b29 for changeset 05c35de6d704 ! .hgtags From omajid at redhat.com Thu Dec 5 18:42:49 2013 From: omajid at redhat.com (Omair Majid) Date: Thu, 5 Dec 2013 21:42:49 -0500 Subject: OpenJDK6 B29 Available Message-ID: <20131206024249.GA28710@redhat.com> Hi, The OpenJDK6 b29 source release is now available for download: https://java.net/projects/openjdk6/downloads/download/openjdk-6-src-b29-05_dec_2013.tar.gz This release contains a number of security fixes. Anyone using OpenJDK6 b28 is strongly encouraged to update. A list of all changes is available here: https://openjdk6.java.net/OpenJDK6-B29-Changes.html Please note that builds based on this do not pass the TCK. All the failures were caused by limited crypto. Patches are available to address this [1]. This is not a regression as far as I know. A special thanks to Andrew Hughes for backporting all the security fixes. Onwards to b30! Cheers, Omair [1] https://bugs.openjdk.java.net/browse/JDK-7188845 -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From omajid at redhat.com Thu Dec 5 18:43:57 2013 From: omajid at redhat.com (Omair Majid) Date: Thu, 5 Dec 2013 21:43:57 -0500 Subject: Starting OpenJDK6 B29 promotion process In-Reply-To: <20131205235653.GH19634@redhat.com> References: <20131205161913.GA19634@redhat.com> <20131205235653.GH19634@redhat.com> Message-ID: <20131206024357.GB28710@redhat.com> * Omair Majid [2013-12-05 19:07]: > * Omair Majid [2013-12-05 11:22]: > > I will be starting the OpenJDK6 B29 promotion (will be tagged with > > jdk6-b29). > > I am starting the process, please defer all changes until the release is > complete. B29 has been released. The forest is now open for commits. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From omajid at redhat.com Thu Dec 5 19:01:23 2013 From: omajid at redhat.com (Omair Majid) Date: Thu, 5 Dec 2013 22:01:23 -0500 Subject: RFR: Fix Change Summary generator In-Reply-To: <20131113234711.GF1648@redhat.com> References: <20131113234711.GF1648@redhat.com> Message-ID: <20131206030123.GD28710@redhat.com> * Omair Majid [2013-11-13 19:06]: > The attached patch fixes the Change Summary generator included in > openjdk6. OPENDJDK6-* bugs are now generated too. I have included the > update summary page that is generated with this patch (for b27 to b28 > jump, compare with [1]). > > I will wait for all the security patches to be added before pushing > this, assuming this patch looks okay. Ping. Could someone please review this? It missed b29, and I hate to carry it around locally. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From jvanek at redhat.com Fri Dec 6 01:19:42 2013 From: jvanek at redhat.com (Jiri Vanek) Date: Fri, 06 Dec 2013 10:19:42 +0100 Subject: RFR: Fix Change Summary generator In-Reply-To: <20131113234711.GF1648@redhat.com> References: <20131113234711.GF1648@redhat.com> Message-ID: <52A196AE.7080807@redhat.com> On 11/14/2013 12:47 AM, Omair Majid wrote: > Hi, > > The attached patch fixes the Change Summary generator included in > openjdk6. OPENDJDK6-* bugs are now generated too. I have included the > update summary page that is generated with this patch (for b27 to b28 > jump, compare with [1]). > > I will wait for all the security patches to be added before pushing > this, assuming this patch looks okay. > > Thanks, > Omair > > [1]https://openjdk6.java.net/OpenJDK6-B28-Changes.html > > > fix-report-generator.patch > > > diff --git a/make/scripts/jdkreport.pl b/make/scripts/jdkreport.pl > --- a/make/scripts/jdkreport.pl > +++ b/make/scripts/jdkreport.pl > @@ -70,7 +70,12 @@ > foreach(@bugs) { > ($bugid, $desc) = split ':',$_, 2; # limit the number of splits to 2 > $bugid =~ s/^\s+//; #remove leading white spaces > - $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid"; > + > + if ($bugid =~ /^OPENJDK6-/) { # use different urls for different bugs > + $url ="http:/java.net/jira/browse/$bugid"; > + } else { > + $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid"; > + } > > if($firstbug) { > $firstbug = 0; > @@ -108,7 +113,7 @@ > chomp($changeset); #remove end of line > } > > - if(/^\d+:/) { #match lines that start with numbers (bugids) > + if(/^(OPENJDK6-)?\d+:/) { #match lines that start with numbers (bugids) > push(@bugs, $_); > } > } > > > changelog.html > > > I'm not full time reviewer, but except one nit the changes looks ok. In second hunk, the comment is no longer valid, it ssould be: + if(/^(OPENJDK6-)?\d+:/) { #match lines that start with OPENJDK5- or with numbers (both bugids) So from my "watcher's" position ok to go after fixed comment. Thankx for keeping jdk6 alive! J. From gnu.andrew at redhat.com Fri Dec 6 06:30:29 2013 From: gnu.andrew at redhat.com (Andrew) Date: Fri, 6 Dec 2013 09:30:29 -0500 (EST) Subject: RFR: Fix Change Summary generator In-Reply-To: <52A196AE.7080807@redhat.com> References: <20131113234711.GF1648@redhat.com> <52A196AE.7080807@redhat.com> Message-ID: <1077717866.1325243.1386340229064.JavaMail.root@redhat.com> ----- Original Message ----- > On 11/14/2013 12:47 AM, Omair Majid wrote: > > Hi, > > > > The attached patch fixes the Change Summary generator included in > > openjdk6. OPENDJDK6-* bugs are now generated too. I have included the > > update summary page that is generated with this patch (for b27 to b28 > > jump, compare with [1]). > > > > I will wait for all the security patches to be added before pushing > > this, assuming this patch looks okay. > > > > Thanks, > > Omair > > > > [1]https://openjdk6.java.net/OpenJDK6-B28-Changes.html > > > > > > fix-report-generator.patch > > > > > > diff --git a/make/scripts/jdkreport.pl b/make/scripts/jdkreport.pl > > --- a/make/scripts/jdkreport.pl > > +++ b/make/scripts/jdkreport.pl > > @@ -70,7 +70,12 @@ > > foreach(@bugs) { > > ($bugid, $desc) = split ':',$_, 2; # limit the number of splits to 2 > > $bugid =~ s/^\s+//; #remove leading white spaces > > - $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid"; > > + > > + if ($bugid =~ /^OPENJDK6-/) { # use different urls for different bugs > > + $url ="http:/java.net/jira/browse/$bugid"; > > + } else { > > + $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid"; > > + } > > > > if($firstbug) { > > $firstbug = 0; > > @@ -108,7 +113,7 @@ > > chomp($changeset); #remove end of line > > } > > > > - if(/^\d+:/) { #match lines that start with numbers (bugids) > > + if(/^(OPENJDK6-)?\d+:/) { #match lines that start with numbers (bugids) > > push(@bugs, $_); > > } > > } > > > > > > changelog.html > > > > > > > I'm not full time reviewer, but except one nit the changes looks ok. > You're not a reviewer at all, in the OpenJDK sense. Sorry. > In second hunk, the comment is no longer valid, it ssould be: > + if(/^(OPENJDK6-)?\d+:/) { #match lines that start with OPENJDK5- or with > numbers (both bugids) > > > So from my "watcher's" position ok to go after fixed comment. > > Thankx for keeping jdk6 alive! > > J. > I didn't realise you'd posted this or that the script was part of OpenJDK itself. I did ok it informally before and do so now formally. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From omajid at redhat.com Fri Dec 6 10:06:33 2013 From: omajid at redhat.com (omajid at redhat.com) Date: Fri, 06 Dec 2013 18:06:33 +0000 Subject: hg: jdk6/jdk6: OPENJDK6-24: Fix change summary generator Message-ID: <20131206180633.9568362B44@hg.openjdk.java.net> Changeset: 0ee0e8c81e3d Author: omajid Date: 2013-12-06 13:03 -0500 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/0ee0e8c81e3d OPENJDK6-24: Fix change summary generator Reviewed-by: andrew ! make/scripts/jdkreport.pl From mail at alexkasko.com Mon Dec 9 07:49:47 2013 From: mail at alexkasko.com (Alex Kasko) Date: Mon, 09 Dec 2013 19:49:47 +0400 Subject: [PATCH] compilation flag fix for safeseh support on windows Message-ID: <52A5E69B.6090303@alexkasko.com> Hi, Currently jdk6 build is broken on windows-i586 after this patch [1]. Service agent linking error message - [2]. I found that this is caused by ZI (reference [3]) compilation flag that probably conflicts with SAFESEH linking flag in VS2003 toolchain. I propose to change ZI flag to Zi, I think this is better than disabling SAFESEH. I asked about implications of this change on serviceability list [4] but haven't receive a reply yet. Webrev - http://cr.openjdk.java.net/~akasko/jdk6/webrev_remove_sa_edit_and_continue.00/ [1] http://cr.openjdk.java.net/~andrew/openjdk6/20131015/hotspot/make/windows/makefiles/sa.make.udiff.html [2] http://cr.openjdk.java.net/~akasko/jdk6/hotspot_sawindbg_safeseh_error.txt [3] http://msdn.microsoft.com/en-us/library/958x11bc%28v=vs.71%29.aspx [4] http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-December/013553.html -- Regards, Alex Kasko -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3742 bytes Desc: S/MIME Cryptographic Signature Url : http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20131209/71e682fa/smime.p7s From mail at alexkasko.com Mon Dec 9 08:03:41 2013 From: mail at alexkasko.com (Alex Kasko) Date: Mon, 09 Dec 2013 20:03:41 +0400 Subject: [PATCH] unlimited crypto support - OPENJDK6-14 Message-ID: <52A5E9DD.4040601@alexkasko.com> Hi, Out of the box unlimited crypto support out have been implemented for a long time in icedtea6. This bug is quite recent - https://java.net/jira/browse/OPENJDK6-14 and maybe it is better to integrate the icedtea patch into jdk6. I am using this patch - http://icedtea.classpath.org/hg/icedtea6/file/73058db81e91/patches/clean-crypto.patch , it applies cleanly on current jdk6 (with patch -p1). I created webrev from it - http://cr.openjdk.java.net/~akasko/jdk6/webrev_clean_crypto.00/ -- Regards, Alex Kasko -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3742 bytes Desc: S/MIME Cryptographic Signature Url : http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20131209/0b6ef55c/smime.p7s From aph at redhat.com Mon Dec 9 08:52:26 2013 From: aph at redhat.com (Andrew Haley) Date: Mon, 09 Dec 2013 16:52:26 +0000 Subject: [PATCH] compilation flag fix for safeseh support on windows In-Reply-To: <52A5E69B.6090303@alexkasko.com> References: <52A5E69B.6090303@alexkasko.com> Message-ID: <52A5F54A.1080503@redhat.com> On 12/09/2013 03:49 PM, Alex Kasko wrote: > Currently jdk6 build is broken on windows-i586 after this patch [1]. > Service agent linking error message - [2]. > > I found that this is caused by ZI (reference [3]) compilation flag that > probably conflicts with SAFESEH linking flag in VS2003 toolchain. I > propose to change ZI flag to Zi, I think this is better than disabling > SAFESEH. I asked about implications of this change on serviceability > list [4] but haven't receive a reply yet. > > Webrev - > http://cr.openjdk.java.net/~akasko/jdk6/webrev_remove_sa_edit_and_continue.00/ OK, thanks. Andrew. From aph at redhat.com Mon Dec 9 09:05:26 2013 From: aph at redhat.com (Andrew Haley) Date: Mon, 09 Dec 2013 17:05:26 +0000 Subject: [PATCH] unlimited crypto support - OPENJDK6-14 In-Reply-To: <52A5E9DD.4040601@alexkasko.com> References: <52A5E9DD.4040601@alexkasko.com> Message-ID: <52A5F856.1040505@redhat.com> On 12/09/2013 04:03 PM, Alex Kasko wrote: > Out of the box unlimited crypto support out have been implemented for a > long time in icedtea6. This bug is quite recent - > https://java.net/jira/browse/OPENJDK6-14 and maybe it is better to > integrate the icedtea patch into jdk6. > > I am using this patch - > http://icedtea.classpath.org/hg/icedtea6/file/73058db81e91/patches/clean-crypto.patch > , it applies cleanly on current jdk6 (with patch -p1). > > I created webrev from it - > http://cr.openjdk.java.net/~akasko/jdk6/webrev_clean_crypto.00/ I think this is right, but I'm going to wait for input from the Icedtea6 people, since it affects them. Andrew. From gnu.andrew at redhat.com Mon Dec 9 10:31:07 2013 From: gnu.andrew at redhat.com (Andrew) Date: Mon, 9 Dec 2013 13:31:07 -0500 (EST) Subject: [PATCH] unlimited crypto support - OPENJDK6-14 In-Reply-To: <52A5F856.1040505@redhat.com> References: <52A5E9DD.4040601@alexkasko.com> <52A5F856.1040505@redhat.com> Message-ID: <704572449.2176820.1386613867477.JavaMail.root@redhat.com> ----- Original Message ----- > On 12/09/2013 04:03 PM, Alex Kasko wrote: > > > Out of the box unlimited crypto support out have been implemented for a > > long time in icedtea6. This bug is quite recent - > > https://java.net/jira/browse/OPENJDK6-14 and maybe it is better to > > integrate the icedtea patch into jdk6. > > > > I am using this patch - > > http://icedtea.classpath.org/hg/icedtea6/file/73058db81e91/patches/clean-crypto.patch > > , it applies cleanly on current jdk6 (with patch -p1). > > > > I created webrev from it - > > http://cr.openjdk.java.net/~akasko/jdk6/webrev_clean_crypto.00/ > > I think this is right, but I'm going to wait for input from the Icedtea6 > people, since it affects them. > > Andrew. > > > I think it better to backport: 7201205: Add Makefile configuration option to build with unlimited crypto in OpenJDK. and build with UNLIMITED_CRYPTO=true. This has already been well-tested on 7 & 8 and is less destructive. I'll do some testing on 6 and then post a webrev. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From jvanek at redhat.com Tue Dec 10 01:39:05 2013 From: jvanek at redhat.com (Jiri Vanek) Date: Tue, 10 Dec 2013 10:39:05 +0100 Subject: RFR: Fix Change Summary generator In-Reply-To: <1077717866.1325243.1386340229064.JavaMail.root@redhat.com> References: <20131113234711.GF1648@redhat.com> <52A196AE.7080807@redhat.com> <1077717866.1325243.1386340229064.JavaMail.root@redhat.com> Message-ID: <52A6E139.9030807@redhat.com> On 12/06/2013 03:30 PM, Andrew wrote: > ----- Original Message ----- >> On 11/14/2013 12:47 AM, Omair Majid wrote: >>> Hi, >>> >>> The attached patch fixes the Change Summary generator included in >>> openjdk6. OPENDJDK6-* bugs are now generated too. I have included the >>> update summary page that is generated with this patch (for b27 to b28 >>> jump, compare with [1]). >>> >>> I will wait for all the security patches to be added before pushing >>> this, assuming this patch looks okay. >>> >>> Thanks, >>> Omair >>> >>> [1]https://openjdk6.java.net/OpenJDK6-B28-Changes.html >>> >>> >>> fix-report-generator.patch >>> >>> >>> diff --git a/make/scripts/jdkreport.pl b/make/scripts/jdkreport.pl >>> --- a/make/scripts/jdkreport.pl >>> +++ b/make/scripts/jdkreport.pl >>> @@ -70,7 +70,12 @@ >>> foreach(@bugs) { >>> ($bugid, $desc) = split ':',$_, 2; # limit the number of splits to 2 >>> $bugid =~ s/^\s+//; #remove leading white spaces >>> - $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid"; >>> + >>> + if ($bugid =~ /^OPENJDK6-/) { # use different urls for different bugs >>> + $url ="http:/java.net/jira/browse/$bugid"; >>> + } else { >>> + $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid"; >>> + } >>> >>> if($firstbug) { >>> $firstbug = 0; >>> @@ -108,7 +113,7 @@ >>> chomp($changeset); #remove end of line >>> } >>> >>> - if(/^\d+:/) { #match lines that start with numbers (bugids) >>> + if(/^(OPENJDK6-)?\d+:/) { #match lines that start with numbers (bugids) >>> push(@bugs, $_); >>> } >>> } >>> >>> >>> changelog.html >>> >>> >>> >> I'm not full time reviewer, but except one nit the changes looks ok. >> > > You're not a reviewer at all, in the OpenJDK sense. Sorry. Yes... I voted especially because Omair will be off to the end of the December. You can not speed up the change here, can you? Sorry for disturbing, J. > >> In second hunk, the comment is no longer valid, it ssould be: >> + if(/^(OPENJDK6-)?\d+:/) { #match lines that start with OPENJDK5- or with >> numbers (both bugids) >> >> >> So from my "watcher's" position ok to go after fixed comment. >> >> Thankx for keeping jdk6 alive! >> >> J. >> > > I didn't realise you'd posted this or that the script was part of OpenJDK itself. > I did ok it informally before and do so now formally. > From omajid at redhat.com Fri Dec 13 09:43:03 2013 From: omajid at redhat.com (Omair Majid) Date: Fri, 13 Dec 2013 12:43:03 -0500 Subject: RFR: Fix Change Summary generator In-Reply-To: <52A6E139.9030807@redhat.com> References: <20131113234711.GF1648@redhat.com> <52A196AE.7080807@redhat.com> <1077717866.1325243.1386340229064.JavaMail.root@redhat.com> <52A6E139.9030807@redhat.com> Message-ID: <20131213174302.GA10980@redhat.com> * Jiri Vanek [2013-12-10 04:39]: > You can not speed up the change here, can you? I pushed this change last week: http://hg.openjdk.java.net/jdk6/jdk6/rev/0ee0e8c81e3d Thanks, Omair From mail at alexkasko.com Fri Dec 27 07:01:48 2013 From: mail at alexkasko.com (Alex Kasko) Date: Fri, 27 Dec 2013 19:01:48 +0400 Subject: [PATCH] Timezone data update Message-ID: <52BD965C.5010800@alexkasko.com> Timezone data (jre/lib/zi) in jdk6 is outdated. I updated it from jdk7u, webrev: http://cr.openjdk.java.net/~akasko/jdk6/webrev_tzdata.00/ -- Regards, Alex Kasko -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3742 bytes Desc: S/MIME Cryptographic Signature Url : http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20131227/684e52a5/smime.p7s From aph at redhat.com Fri Dec 27 07:09:05 2013 From: aph at redhat.com (Andrew Haley) Date: Fri, 27 Dec 2013 15:09:05 +0000 Subject: [PATCH] Timezone data update In-Reply-To: <52BD965C.5010800@alexkasko.com> References: <52BD965C.5010800@alexkasko.com> Message-ID: <52BD9811.6050500@redhat.com> On 12/27/2013 03:01 PM, Alex Kasko wrote: > Timezone data (jre/lib/zi) in jdk6 is outdated. I updated it from jdk7u, > webrev: > > http://cr.openjdk.java.net/~akasko/jdk6/webrev_tzdata.00/ Great, thanks. Andrew.