[PATCH FOR REVIEW] OPENJDK6-3: Fix small memory leak in get_stack_bounds

Andrew Hughes gnu.andrew at redhat.com
Thu Mar 21 06:49:12 PDT 2013



----- Original Message -----
> On 03/20/2013 10:45 PM, Andrew Hughes wrote:
> > A small memory leak was found in get_stack_bounds when getline
> > returned with an error code,
> > but it was fixed in OpenJDK 7 & 8 in a way that introduced worse
> > issues:
> > 
> > http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-February/008695.html
> > 
> > This webrev adds a simpler fix, just adding the necessary free
> > call:
> > 
> > http://cr.openjdk.java.net/~andrew/jdk6/03/webrev.01/
> > 
> > I filed a bug for this here: http://java.net/jira/browse/OPENJDK6-3
> > 
> > Ok for OpenJDK 6?
> 
> Yes, thanks.  I don't know why I missed this one.
> 
> Andrew.
> 
> 
> 

Thanks.

remote: > OPENJDK6-3: Fix memory leak in get_stack_bounds
remote: > Summary: Memory is allocated by getline but not freed if it fails
remote: > Reviewed-by: aph
remote: 
remote: Incomplete comment: Missing bugid line
remote: Incomplete comment: Missing reviewer attribution
remote: Extraneous text in comment

Omair?  I thought we disabled this?
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07



More information about the jdk6-dev mailing list