[PATCH FOR REVIEW] OPENJDK6-18: HotSpot 23's Java code won't build with a 1.5 compiler due to @Override on interfaces.

[Andrew Hughes]

----- Original Message -----
> On 09/20/2013 10:17 AM, Andrew Hughes wrote:
> >> On 09/19/2013 01:06 PM, Andrew Hughes wrote:
> >>>>
> >>>> The build README points out that a 6 JDK is required to build OpenJDK6
> >>>> [1] and @Override for interface methods are supported by a 6 compiler.
> >>>
> >>> Then the README is wrong.
> >>
> >> Oh, what is the boot JDK requirement, then?
> > 
> > 1.5:
> > http://mail.openjdk.java.net/pipermail/jdk6-dev/2013-September/003039.html
> > 
> > This is a regression from before the HotSpot update so needs to be fixed.
> 
> Okay. Given that @Override on interface is not quite part of java 5
> (different compilers implemented it differently), the change looks okay
> to me.
> 

It wasn't specified, so the OpenJDK javac is at fault in not failing IMHO.

> Thanks,
> Omair
> --
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
> 

http://mail.openjdk.java.net/pipermail/jdk6-dev/2013-September/003071.html

Will you release b28 now?
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07