Review request for OPENJDK6-32: OpenJDK6-b31 isn't compatible with Windows platform

Omair Majid omajid at redhat.com
Thu Aug 21 20:04:40 UTC 2014


Hi Alex,

* Alex Kasko <mail at alexkasko.com> [2014-05-24 13:20]:
> I've built 32-bit and 64-bit versions successfully using Windows SDK 7.1
> (without Visual Studio) with the following patch:
> 
> $ diff jdk6_vs2010/jdk/src/windows/resource/version.rc version.rc
> 26c26
> < #include "afxres.h"
> ---
> > #include "windows.h"
> 
> $ diff jdk6_vs2010/jdk/src/windows/native/sun/windows/awt.rc awt.rc
> 26c26
> < #include "afxres.h"
> ---
> > #include "windows.h"
> 40,42c40,42
> < SECURITY_WARNING_0  ICON    DISCARDABLE "security_warning_bw.ico"
> < SECURITY_WARNING_1  ICON    DISCARDABLE "security_warning_int.ico"
> < SECURITY_WARNING_2  ICON    DISCARDABLE "security_warning.ico"
> ---
> > SECURITY_WARNING_0  ICON    DISCARDABLE "awt.ico"
> > SECURITY_WARNING_1  ICON    DISCARDABLE "awt.ico"
> > SECURITY_WARNING_2  ICON    DISCARDABLE "awt.ico"

I have been told that this patch is still needed on Windows. Do you have
commit access to OpenJDK6? If so, please file a bug, count this as a
"review" and push the change. If not, can you create a changeset? I can
push it for you.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the jdk6-dev mailing list