Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

[Andrew Hughes]

----- Original Message -----
> On 06/23/2014 02:30 PM, Ivan Krylov wrote:
> > Andrew, thank you.
> > Just pushed the changes.
> > BTW, icedtea patches 6650759-missing_inference.patch and
> > 6638712-wildcard_types.patch are now redundant.
> > 
> > Also, the following bugs may be closed OPENJDK6-32,33,34,35. I would
> > close those myself but I do not have the required permissions.
> 
> Deepak Bhole has been doing some digging, and he found this:
> 
> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-December/002195.html
> 
> "For the javac changes, backporting 6638712 in and of itself would be
> fine; however, backporting 6650759 would be problematic since it
> implements a type-inference specification change in JDK 7.  There are
> differences between the type inference behavior of javac in OpenJDK 6
> and the propriety JDK this issue is one of them.  The inference
> algorithm in OpenJDK 6 could be reworked a bit, but I don't expect the
> javac team to have cycles for that task in the near future."
> 
> For that reason, I should not have approved this patch; it has
> already been rejected.  I intend to back it out.
> 
> Andrew.
> 
> 

Is this still the intention? Our live IcedTea builds, which build
against the upstream OpenJDK 6 Mercurial tree, are currently failing
and I don't want to waste time fixing that if the patch is going to
be reverted again.

There's a security update coming up, and thus a b32 release, so we need
to make a decision ASAP.

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07