Changeset comment format (was Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6)

[Nikolay Gorshkov]

Hello Mario, Andrew,

I'd like to propose the following changeset comment format for situations
when the creator and the backporter of the fix are two different persons:

1234567: NPE thrown on FileInputStream("")
Summary: Rewrite precondition-checking code in io.c
Reviewed-by: mr
Contributed-by: Ben Bitdiddle <ben at bits.org>
Authored-by: Joe Bloggs <joe.bloggs at example.com>

"Authored-by" field points to the original author of the fix. It may be
just an OpenJDK username or a combination of a full name and an email
address like it appears currently in "Contributed-by" field. Please,
let me know if you are OK with this format for further backports.

Thanks,
Nikolay

On 25.06.2014 20:18, Mario Torre wrote:
> On Wed, 2014-06-25 at 16:07 +0000, Ivan Krylov wrote:
>> but, as you say, that doesn't give credit for the backporting work. On the other hand, if I'd
>> gone to the other extreme, over 90% of the OpenJDK 6 changesets would be credited to me which
>> would look very odd!
>>
>>
>> In the dev cycle part of the development job is do all proper testing and verification and this is done by the same developer that writes code.
>> For backports - the verification is being done by the person who does the backport and this is often a different person than the author in the upstream, right?
>> Within Oracle folks have an advantage of running almost every backport by the original author as part of review - helps a lot to gain understanding and see the pitfalls.
>> Unfortunately we don’t have such an opportunity, therefore we rely on all available tests and workloads to be the arbiters whether a given fix is valid or not.
>>
>> You and the entire IcedTea team do get a huge credit for keeping openjdk6 vibrant, secure and robust and the community appreciates that!
>
> Yeah, I agree one should not underestimate such work.
>
> I guess the solution to the original question maybe on adding an extra
> field for backport work where the original author is mentioned?
>
> As you say, for versions directly maintained by Oracle this is usually
> not a big problem, since the same person is usually the one that does
> also the backport, but for the other Community maintained versions it's
> more common to have such situation, it would make sense to state it
> explicitly.
>
> Cheers,
> Mario
>
>
>