Changeset comment format (was Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6)
Mario Torre
neugens at redhat.com
Wed Jul 16 09:09:59 UTC 2014
On Tue, 2014-07-15 at 10:51 -0400, Andrew Hughes wrote:
>
> ----- Original Message -----
> > On 14/07/14 21:17, Nikolay Gorshkov wrote:
> > > Hello Mario, Andrew,
> > >
> > > I'd like to propose the following changeset comment format for situations
> > > when the creator and the backporter of the fix are two different persons:
> > >
> > > 1234567: NPE thrown on FileInputStream("")
> > > Summary: Rewrite precondition-checking code in io.c
> > > Reviewed-by: mr
> > > Contributed-by: Ben Bitdiddle <ben at bits.org>
> > > Authored-by: Joe Bloggs <joe.bloggs at example.com>
> > >
> > > "Authored-by" field points to the original author of the fix. It may be
> > > just an OpenJDK username or a combination of a full name and an email
> > > address like it appears currently in "Contributed-by" field. Please,
> > > let me know if you are OK with this format for further backports.
> >
> > I'm happy with that.
> >
> > Andrew.
> >
> >
> >
>
> +1
Hi Nikolay,
I'm also happy with it, and thanks for taking care of this!
I agree with Omair that this should be discussed on a more general
mailing list. I guess discuss at openjdk.java.net is the place?
Can you please send there a mail there with this proposal? Once the mail
is there, I'll ping the Adoption group to be sure you get enough
attention and then we can try to speed up fixes to jcheck.
Thanks again!
Cheers,
Mario
More information about the jdk6-dev
mailing list