Review request for OPENJDK6-37: OpenJDK6-b32 cannot be built on Windows

Omair Majid omajid at redhat.com
Thu Jul 17 14:53:46 UTC 2014


Hi,

* Vladislav Karnaukhov <vladislav at azulsystems.com> [2014-07-17 10:03]:
> please review the fix for OPENJDK6-37: OpenJDK6-b32 cannot be built on Windows

Sorry for the breakage.

> The fix is really simple this time and only affects two files in JDK workspace.
> 
> webrev: http://cr.openjdk.java.net/~vkarnauk/OPENJDK6-37/webrev.00/
> bug: https://java.net/jira/browse/OPENJDK6-37

For java_md.c, wouldn't it make sense to use `ReportErrorMessage` rather
than `printf`? The JDK7 fix calls JLI_ReportErrorMessage, which shows a
message box and the JDK6 ReportErrorMessage function looks like it does
the same thing.

Looks good to me otherwise. Thanks for fixing this!

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the jdk6-dev mailing list