Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

[Ivan Krylov]

Andrew,

The main motivation for this fix was exactly to fix building JBoss EAP 
certification bundle (for 6.2.0).
This fix exists in IcedTea (6650759-missing_inference.patch) but for 
whatever reason was never promoted to openjdk6.

Thanks,

Ivan

On 23/06/2014 16:37, Andrew Haley wrote:
> On 06/23/2014 12:17 PM, Ivan Krylov wrote:
>
>> please review the fix for OPENJDK6-35: backport of JDK-6650759 to openjdk6
>> Inference of formal type parameter (unused in formal parameters) is not
>> performed
>>
>> The changes are the same as for OpenJDK7 however hg import failed due to
>> differences in the context of code being changed.
>>
>> bug https://java.net/jira/browse/OPENJDK6-35
>> JDK bug : https://bugs.openjdk.java.net/browse/JDK-8047379
>> webrev http://cr.openjdk.java.net/~ikrylov/openjdk6-bug35.langtools/
>>
>> Testing: build on Windows (cross-platform code, should be ok for linux
>> too), all regression tests for javac - generics.
>
> ISTR that we decided not to import that because it was too risky -
> it broke some existing code (JBoss? Eclipse?) I can't remember.
>
> Given that all JDK6 code has had to put up with this bug for so
> long, unless you have a compelling argument, this should not go in.
>
> Andrew.
>
>