Review request for OPENJDK6-32: OpenJDK6-b31 isn't compatible with Windows platform

Andrew Haley aph at redhat.com
Fri May 23 15:07:54 UTC 2014


Hi,

On 05/23/2014 11:36 AM, karnaukhovv at gmail.com wrote:
> 
> please review the fix for OPENJDK6-32: OpenJDK6-b31 isn't compatible
> with Windows platform
> 
> webrev: http://cr.openjdk.java.net/~vkarnauk/OPENJDK6-32/webrev.00/
> 
> This fix is a follow-up to threads [1], [2], and [3]. It contains
> changes necessary to upgrade compilers to VisualStudio 2010, as well
> as changes that fix current issues in Windows part of OpenJDK6-b31.

Thank you.  This all looks reasonable enough, but it is a huge patch
and rather a lot to take in one bite.  I have studied it, and it all
looks reasonable enough.  I am minded to commit these patches as they
are, since that moves us much closer to proper Windows support.

I'm not working on Windows, so I can't much comment on the finer
technical details.  I'm going to leave it up for people to comment for
a couple of days and then check it in.

Thanks,
Andrew.


More information about the jdk6-dev mailing list