PING: [PATCH] 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations

[Andrew Dinn]

On 12/11/14 16:41, Andrew Hughes wrote:
> ----- Original Message -----
>> Webrev: http://cr.openjdk.java.net/~andrew/openjdk6/7122142/webrev.01/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-7122142
>>
>> This is the same patch as is present in IcedTea 1.x HEAD and the
>> 1.13 release branch. It is mostly a clean backport of the OpenJDK 7
>> version, with the addition of the need to synchronise
>> a number of type parameters with the versions in the OpenJDK 7 classes,
>> so the result will compile successfully (mostly Class -> Class<?>)
>>
>> Ok to push?

caveat: I am posting here as a "reviewer" not a "Reviewer" since I have
no official status as an OpenJDK project member on anything except the
AArch64 port.

This fix did not backport to 6 because of of a separate issue

  https://bugs.openjdk.java.net/browse/JDK-7122142

which caused the test case to break. Fixing the other issue enabled the
test case to complete successfully.

I am not familiar enough with the patch (or, indeed, the test case) to
be certain that this is all that is needed to fix the annotation race
problem. However, given that the patch applies to what is essentially
the same code as upstream jdk7 and that the upstream reviewers accepted
it I think it is ok to push.

regards,


Andrew Dinn
-----------