From mail at alexkasko.com Sat Sep 6 18:18:47 2014 From: mail at alexkasko.com (Alex Kasko) Date: Sat, 06 Sep 2014 19:18:47 +0100 Subject: Review request for OPENJDK6-32: OpenJDK6-b31 isn't compatible with Windows platform In-Reply-To: <53FBB404.4020802@alexkasko.com> References: <537f3737.6524980a.466c.2d1c@mx.google.com> <537F644A.5050901@redhat.com> <5380D4BD.3010509@alexkasko.com> <20140821200440.GB20963@redhat.com> <7a703307-4eeb-437d-98df-8dc1637b703f@email.android.com> <53FBB404.4020802@alexkasko.com> Message-ID: <540B5007.4090900@alexkasko.com> Hi Omair, On 08/25/2014 11:09 PM, Alex Kasko wrote: > Hi, > > On 08/22/2014 09:01 AM, Alex Kasko wrote: >> Hi Omair, >> >> Omair Majid wrote: >> >>> Hi Alex, >>> >>> * Alex Kasko [2014-05-24 13:20]: >>>> I've built 32-bit and 64-bit versions successfully using Windows SDK >>> 7.1 >>>> (without Visual Studio) with the following patch: >>>> >>>> $ diff jdk6_vs2010/jdk/src/windows/resource/version.rc version.rc >>>> 26c26 >>>> < #include "afxres.h" >>>> --- >>>>> #include "windows.h" >>>> >>>> $ diff jdk6_vs2010/jdk/src/windows/native/sun/windows/awt.rc awt.rc >>>> 26c26 >>>> < #include "afxres.h" >>>> --- >>>>> #include "windows.h" >>>> 40,42c40,42 >>>> < SECURITY_WARNING_0 ICON DISCARDABLE "security_warning_bw.ico" >>>> < SECURITY_WARNING_1 ICON DISCARDABLE "security_warning_int.ico" >>>> < SECURITY_WARNING_2 ICON DISCARDABLE "security_warning.ico" >>>> --- >>>>> SECURITY_WARNING_0 ICON DISCARDABLE "awt.ico" >>>>> SECURITY_WARNING_1 ICON DISCARDABLE "awt.ico" >>>>> SECURITY_WARNING_2 ICON DISCARDABLE "awt.ico" >>> >>> I have been told that this patch is still needed on Windows. Do you >>> have >>> commit access to OpenJDK6? If so, please file a bug, count this as a >>> "review" and push the change. If not, can you create a changeset? I can >>> push it for you. >>> >>> Thanks, >>> Omair >>> >>> -- >>> PGP Key: 66484681 (http://pgp.mit.edu/) >>> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 >> >> >> I do not have commit access. I am not sure about bugtracker (I have >> access to JBS, but never tried JDK6 tracker), I'll try it. >> >> I'll create the changeset, need some days though to test patch against >> current tip and to check why the icons change is required - windows.h >> header change is straightforward, but I do not understand the reason >> of missing icons. >> > > Can confirm, that this patch works with current tip and WinSDK 7.1, > still need to check the problem with icons though - will report in some > days. I tested the patch (without icons part) on x86 and x86_64 builds and created a bug https://java.net/jira/browse/OPENJDK6-41 and a changeset http://cr.openjdk.java.net/~akasko/jdk6/OPENJDK6-41.export . Please let me know if more changes are required here. -- -Alex -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3742 bytes Desc: S/MIME Cryptographic Signature URL: From omajid at redhat.com Sat Sep 6 19:22:27 2014 From: omajid at redhat.com (Omair Majid) Date: Sat, 6 Sep 2014 15:22:27 -0400 Subject: Review request for OPENJDK6-32: OpenJDK6-b31 isn't compatible with Windows platform In-Reply-To: <540B5007.4090900@alexkasko.com> References: <537f3737.6524980a.466c.2d1c@mx.google.com> <537F644A.5050901@redhat.com> <5380D4BD.3010509@alexkasko.com> <20140821200440.GB20963@redhat.com> <7a703307-4eeb-437d-98df-8dc1637b703f@email.android.com> <53FBB404.4020802@alexkasko.com> <540B5007.4090900@alexkasko.com> Message-ID: <20140906192227.GB2175@redhat.com> * Alex Kasko [2014-09-06 14:18]: > I tested the patch (without icons part) on x86 and x86_64 builds and created > a bug https://java.net/jira/browse/OPENJDK6-41 and a changeset > http://cr.openjdk.java.net/~akasko/jdk6/OPENJDK6-41.export . Please let me > know if more changes are required here. Assuming this builds, thumbs up from me. If you have push access, please go ahead and push this. Thanks! Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From mail at alexkasko.com Sat Sep 6 20:32:54 2014 From: mail at alexkasko.com (Alex Kasko) Date: Sat, 06 Sep 2014 21:32:54 +0100 Subject: Review request for OPENJDK6-32: OpenJDK6-b31 isn't compatible with Windows platform In-Reply-To: <20140906192227.GB2175@redhat.com> References: <537f3737.6524980a.466c.2d1c@mx.google.com> <537F644A.5050901@redhat.com> <5380D4BD.3010509@alexkasko.com> <20140821200440.GB20963@redhat.com> <7a703307-4eeb-437d-98df-8dc1637b703f@email.android.com> <53FBB404.4020802@alexkasko.com> <540B5007.4090900@alexkasko.com> <20140906192227.GB2175@redhat.com> Message-ID: <540B6F76.7070603@alexkasko.com> Hi Omair, On 09/06/2014 08:22 PM, Omair Majid wrote: > * Alex Kasko [2014-09-06 14:18]: >> I tested the patch (without icons part) on x86 and x86_64 builds and created >> a bug https://java.net/jira/browse/OPENJDK6-41 and a changeset >> http://cr.openjdk.java.net/~akasko/jdk6/OPENJDK6-41.export . Please let me >> know if more changes are required here. > > Assuming this builds, thumbs up from me. If you have push access, please > go ahead and push this. I do not have push access. I would appreciate if you'll push it for me. > > Thanks! > > Omair > -- -Alex -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3742 bytes Desc: S/MIME Cryptographic Signature URL: From omajid at redhat.com Mon Sep 8 17:45:24 2014 From: omajid at redhat.com (omajid at redhat.com) Date: Mon, 08 Sep 2014 17:45:24 +0000 Subject: hg: jdk6/jdk6/jdk: OPENJDK6-41: OpenJDK6 should be compatible with Windows SDK 7.1 Message-ID: <201409081745.s88HjORp015887@aojmv0008> Changeset: 105a18752c76 Author: akasko Date: 2014-09-06 19:01 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/105a18752c76 OPENJDK6-41: OpenJDK6 should be compatible with Windows SDK 7.1 Summary: replace afxres.h with windows.h in two windows specific resource files Reviewed-by: omajid ! src/windows/native/sun/windows/awt.rc ! src/windows/resource/version.rc From gnu.andrew at redhat.com Wed Sep 10 14:07:58 2014 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 10 Sep 2014 10:07:58 -0400 (EDT) Subject: [PATCH] 7183251: Netbeans editor renders text wrong on JDK 7u6 build In-Reply-To: <1498633279.11026392.1408689940507.JavaMail.zimbra@redhat.com> References: <1124780775.6662117.1407945859544.JavaMail.zimbra@redhat.com> <1498633279.11026392.1408689940507.JavaMail.zimbra@redhat.com> Message-ID: <2055071046.20678698.1410358078225.JavaMail.zimbra@redhat.com> ----- Original Message ----- > > > ----- Original Message ----- > > This is a followup to the previous patch. It fixes the code so the > > cache actually contains the right key. > > > > Webrev: http://cr.openjdk.java.net/~andrew/openjdk6/7183251/ > > > > Ok to push? > > -- > > Andrew :) > > > > Free Java Software Engineer > > Red Hat, Inc. (http://www.redhat.com) > > > > PGP Key: 248BDC07 (https://keys.indymedia.org/) > > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 > > > > > > Ping. > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: 248BDC07 (https://keys.indymedia.org/) > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 > > Ping #2. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From omajid at redhat.com Wed Sep 10 15:00:28 2014 From: omajid at redhat.com (Omair Majid) Date: Wed, 10 Sep 2014 11:00:28 -0400 Subject: [PATCH] 7183251: Netbeans editor renders text wrong on JDK 7u6 build In-Reply-To: <1124780775.6662117.1407945859544.JavaMail.zimbra@redhat.com> References: <368207347.6661970.1407945818656.JavaMail.zimbra@redhat.com> <1124780775.6662117.1407945859544.JavaMail.zimbra@redhat.com> Message-ID: <20140910150027.GB2263@redhat.com> * Andrew Hughes [2014-08-13 12:04]: > This is a followup to the previous patch. It fixes the code so the > cache actually contains the right key. > > Webrev: http://cr.openjdk.java.net/~andrew/openjdk6/7183251/ > > Ok to push? This matches what's in 7, so okay from me. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From gnu.andrew at redhat.com Fri Sep 12 21:39:59 2014 From: gnu.andrew at redhat.com (gnu.andrew at redhat.com) Date: Fri, 12 Sep 2014 21:39:59 +0000 Subject: hg: jdk6/jdk6/jdk: 2 new changesets Message-ID: <201409122139.s8CLdxJ0013243@aojmv0008> Changeset: 417811659257 Author: prr Date: 2012-07-20 10:17 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/417811659257 7183251: Netbeans editor renders text wrong on JDK 7u6 build Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/SunLayoutEngine.java Changeset: d1f592073a0e Author: andrew Date: 2014-09-12 22:39 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/d1f592073a0e Merge