Review request for OPENJDK6-32: OpenJDK6-b31 isn't compatible with Windows platform

[Alex Kasko]

Hi Omair,

On 08/25/2014 11:09 PM, Alex Kasko wrote:
> Hi,
>
> On 08/22/2014 09:01 AM, Alex Kasko wrote:
>> Hi Omair,
>>
>> Omair Majid <omajid at redhat.com> wrote:
>>
>>> Hi Alex,
>>>
>>> * Alex Kasko <mail at alexkasko.com> [2014-05-24 13:20]:
>>>> I've built 32-bit and 64-bit versions successfully using Windows SDK
>>> 7.1
>>>> (without Visual Studio) with the following patch:
>>>>
>>>> $ diff jdk6_vs2010/jdk/src/windows/resource/version.rc version.rc
>>>> 26c26
>>>> < #include "afxres.h"
>>>> ---
>>>>> #include "windows.h"
>>>>
>>>> $ diff jdk6_vs2010/jdk/src/windows/native/sun/windows/awt.rc awt.rc
>>>> 26c26
>>>> < #include "afxres.h"
>>>> ---
>>>>> #include "windows.h"
>>>> 40,42c40,42
>>>> < SECURITY_WARNING_0  ICON    DISCARDABLE "security_warning_bw.ico"
>>>> < SECURITY_WARNING_1  ICON    DISCARDABLE "security_warning_int.ico"
>>>> < SECURITY_WARNING_2  ICON    DISCARDABLE "security_warning.ico"
>>>> ---
>>>>> SECURITY_WARNING_0  ICON    DISCARDABLE "awt.ico"
>>>>> SECURITY_WARNING_1  ICON    DISCARDABLE "awt.ico"
>>>>> SECURITY_WARNING_2  ICON    DISCARDABLE "awt.ico"
>>>
>>> I have been told that this patch is still needed on Windows. Do you
>>> have
>>> commit access to OpenJDK6? If so, please file a bug, count this as a
>>> "review" and push the change. If not, can you create a changeset? I can
>>> push it for you.
>>>
>>> Thanks,
>>> Omair
>>>
>>> --
>>> PGP Key: 66484681 (http://pgp.mit.edu/)
>>> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
>>
>>
>> I do not have commit access. I am not sure about bugtracker (I have
>> access to JBS, but never tried JDK6 tracker), I'll try it.
>>
>> I'll create the changeset, need some days though to test patch against
>> current tip and to check why the icons change is required - windows.h
>> header change is straightforward, but I do not understand the reason
>> of missing icons.
>>
>
> Can confirm, that this patch works with current tip and WinSDK 7.1,
> still need to check the problem with icons though - will report in some
> days.

I tested the patch (without icons part) on x86 and x86_64 builds and 
created a bug https://java.net/jira/browse/OPENJDK6-41 and a changeset 
http://cr.openjdk.java.net/~akasko/jdk6/OPENJDK6-41.export . Please let 
me know if more changes are required here.


-- 
-Alex

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3742 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20140906/4965d112/smime.p7s>