[PATCH] b34 Release and retro-active security patch review

[Andrew Hughes]

----- Original Message -----
> * Andrew Hughes <gnu.andrew at redhat.com> [2015-01-20 23:06]:
> > Webrevs for the new changes:
> > 
> > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/root/
> > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/corba/
> > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/jaxp/
> > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/jaxws/
> > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/hotspot/
> > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/jdk/
> > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/langtools/
> 
> I looked over the changes and compared them to the jdk7u changesets that
> were pushed. The changes for TLS support look very invasive, but look
> correct to me - I am not familiar with the technical details at all,
> however. I noticed a few minor issues but I see that there are already
> bugs filed to fix those.
> 
> Just one nit:
> 
> This hunk appears in the fix for 4873188 in jdk7u's
> test/sun/security/pkcs11/sslecc/CipherTest.java but is missing here:
> 
> -        if ((args.length > 0) && args[0].equals("sh")) {
> +        if ((args != null) && (args.length > 0) && args[0].equals("sh")) {
> 
> Feel free to fix this in a later changeset.
> 

No, this isn't in 4873188 in 7 either, as I think they missed that one.

$ hg annotate -R ../upstream/icedtea7-2.5/jdk ../upstream/icedtea7-2.5/jdk/test/sun/security/pkcs11/sslecc/CipherTest.java|grep args

1742:         if ((args != null) && (args.length > 0) && args[0].equals("sh")) {

$ hg log -R ../upstream/icedtea7-2.5/jdk -r 1742
changeset:   1742:845fefff00a4
user:        vinnie
date:        Mon Sep 21 23:01:42 2009 +0100
summary:     6884175: CR cleanup for 6840752: Provide out-of-the-box support for ECC algorithms

The same change IS made for the same named test but in the fips directory.
Confused me too :)

> Thanks,
> Omair
> 
> --
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07