RFR (XXS): 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6

[James Melvin]

Hi Stephen,

The scope of the work for 7130404 is to...

1) Convert os.arch callsites to use 'x86_64' instead of 'amd64'
2) Add *missing* os.name callsites for Mac OS X

I did not originally plan to fixup *existing* os.name callsites.
However, your review has inspired me to expand the scope of 7130404 to
do just that. I walked the ~300 os.name/os.arch callsites and it turns
out that only a couple dozen need fixing up to use .contains() instead
of .startsWith(). I've updated the webrevs to reflect this additional
work. Might as well get it over now and get on to bigger and better
things. :)

WEBREV:
   http://cr.openjdk.java.net/~jmelvin/7130404/hotspot/webrev.03
   http://cr.openjdk.java.net/~jmelvin/7130404/jdk/webrev.04
   http://cr.openjdk.java.net/~jmelvin/7130404/corba/webrev.02

TESTING:
   JPRT hotspot and jdk builds and smoke tests on all platforms
   Notepad, SwingSet2, SPECjbb2005 on Mac OS X

Any final comments would be appreciated.

- Jim




On 2/22/12 7:39 PM, Stephen Bannasch wrote:
> At 6:10 PM -0500 2/22/12, James Melvin wrote:
>> Updated to include latest comments...
>>
>> http://cr.openjdk.java.net/~jmelvin/7130404/hotspot/webrev.02
>
> line 46 still uses: os.startsWith("Mac OS X") instead of os.contains("OS X")
>
> http://cr.openjdk.java.net/~jmelvin/7130404/hotspot/webrev.02/agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java.html