M3 stabilization requests for 2009/4/30

[Anthony Petrov]

On 5/1/2009 2:35 AM Phil Race wrote:
>> ->  6812298  anthony.petrov   Dynamic GraphicsConfig changes don't 
>> work on
>> ->                            X11 platforms
>>
>> Phil, if you consider this one super safe and unlikely to cause 
>> regressions I'd take it in, Marina is the Linux/OpenSolaris release 
>> and these bugs seem to significantly impact these platforms.
> I don't know if I go so far as to call it super-safe.
>> If we could get it in b58 it would be better.
> Too late for b58. I guess this is a no unless there's a better
> justification for the risk and more explanation of the impact.
The new API for the shaped/transparent windows introduced in b57 claims 
it automatically adjusts the graphics configuration for a window when 
the window is turned transparent via its setBackground() method. This 
works pretty fine on Windows but not on X11. W/o this fix on 
Linux/Solaris one should pick up a correct GC *before* they create the 
window, which: a) isn't handy; b) somewhat does not conform to the spec 
of the setBackground(). The FX team is way concerned about this 
particular case - it's not convenient for them to specify the gc before 
they create the window.

Risk: I would rate it low. The fix indeed is quite simple: the only 
significant change is that on X11 if the visual of the GC gets changed, 
we just call the removeNotify()/addNotify() pair on the window 
immediately after updating the GC, which seems pretty safe.

--
best regards,
Anthony