Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)

[David Buck]

Hi

The technical issues will need to be looked at tomorrow as I need sleep, but just one thing:

> > A minor nit is that you've changed the copyright date on the file from 
>> 1998 to 1997.
>
> Don't know how I missed that with the earlier reviews, but the
> Teamware history shows that the earliest date for this file
> is indeed in 1998 and not 1997:
>
> $ sccs prs -r1.1 src/solaris/transport/socket/socket_md.c
> src/solaris/transport/socket/SCCS/s.socket_md.c:
>
> D 1.1 98/11/21 21:20:56 gordonh 1 0     00149/00000/00000
> MRs:
> COMMENTS:

Not sure where I got the 1997 from, it's been a while since I did this change in 1.4.2/5/6.
But I probably tried to find the earliest version of the file on Sean Coffey's opengrok server.
Unfortunately, I think they are moving the lab today and the server looks like it is down,
so I can't try to retrace my steps.

I just tried to manually find the oldest version of this file on Kevin Walls LXR server, and I came
up with an even older date!

http://cheesypoof.uk.oracle.com/lxr2/source/j2sdk1.3.1/ext/jpda/src/solaris/transport/socket/socket_md.c?v=Java_1.3.1

===
002  * @(#)socket_md.c      1.6 00/02/02
003  *
004  * Copyright 1995-2000 Sun Microsystems, Inc. All Rights Reserved.
005  * 
006  * This software is the proprietary information of Sun Microsystems, Inc.  
007  * Use is subject to license terms.
008  * 
009  */
===

This really begs the question: what standard (if any) do we use to try to determine the
beginning copyright date for a given file?

Regards,
-Buck

-----Original Message-----
From: Daniel D. Daugherty 
Sent: Friday, August 05, 2011 1:19 AM
Cc: David Buck; serviceability-dev at openjdk.java.net; jdk7u-dev at openjdk.java.net; java_sustaining; core-libs-dev at openjdk.java.net
Subject: Re: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)

On 8/4/11 9:50 AM, Alan Bateman wrote:
> David Buck wrote:
>> Hi!
>>
>> I would like to request that my fix for 7011591 be reviewed for push 
>> into JDK8 (and JDK7u if possible).
>>
>> CR: 7011591 JDWP socket transport should restart interrupted system 
>> calls (EINTR)
>> :
>>
>> Webrev: http://cr.openjdk.java.net/~dbuck/7011591/webrev.00/
> I've added serviceability-dev to the CC list as that is where the 
> debugger code is.

Alan, thanks for adding in serviceability-dev...

Thumbs up from me since this matches my earlier reviews.


> I looked at the webrev and it mostly looks okay to me. One issue is 
> that dbgsysPoll probably should adjust the timeout when interrupted.

Adjust it how? (Just curious)


> A minor nit is that you've changed the copyright date on the file from 
> 1998 to 1997.

Don't know how I missed that with the earlier reviews, but the
Teamware history shows that the earliest date for this file
is indeed in 1998 and not 1997:

$ sccs prs -r1.1 src/solaris/transport/socket/socket_md.c
src/solaris/transport/socket/SCCS/s.socket_md.c:

D 1.1 98/11/21 21:20:56 gordonh 1 0     00149/00000/00000
MRs:
COMMENTS:

Dan