Resent: Push request: 7043847...: NTLM API compliances issues

Weijun Wang weijun.wang at oracle.com
Thu Aug 18 23:09:44 PDT 2011


Sorry, forget to update the subject line in my template. Sent again.

-------- Original Message --------
Subject: Push request: nnnnnnn: so so
Date: Fri, 19 Aug 2011 14:00:32 +0800
From: Weijun Wang <weijun.wang at oracle.com>
To: jdk7u-dev at openjdk.java.net

Hi All

This is a request to backport several jdk8 fix into jdk7u2 b03:

CR:

7043847: NTML impl of SaslServer throws UnsupportedOperationException
from (un)wrap method
7043860: NTML impl of SaslServer doesn't throw ISE from
getAuthorizationID() method
7043882: NTML impl of SaslServer doesn't throw ISE from
getNegotiatedProperty() method
7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException
7043959: NTML impl of SaslClientFactory throws NPE for null
CallBackHandler instance

Weblink:

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7043847
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7043860
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7043882
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7043938
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7043959

Description:

The NTLM mechanism for SASL has several API compliance issues when an
error occurs during the communication, say, throwing an
UnsupportedOperationException when an IllegalStateException is expected,
or, throwing a NullPointerException when a SaslException is expected.

The fix is already included in jdk8 as:

     Changeset: 55952703809f
     Author:    weijun
     Date:      2011-08-19 13:42 +0800
     URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55952703809f

     7043847: NTML impl of SaslServer throws
UnsupportedOperationException from (un)wrap method
     7043860: NTML impl of SaslServer doesn't throw ISE from
getAuthorizationID() method
     7043882: NTML impl of SaslServer doesn't throw ISE from
getNegotiatedProperty() method
     7043938: NTML impl of SaslClientFactory throws NPE instead of
SaslException
     7043959: NTML impl of SaslClientFactory throws NPE for null
CallBackHandler instance
     Reviewed-by: vinnie

The patch for jdk7u2 is almost identical to the one in jdk8. There are
only 2 places where the context differs a little.

I intend to push it to

    ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk

Thanks
Weijun



More information about the jdk7u-dev mailing list