Request for review: Bug 7067811

[Dalibor Topic]

On 8/24/11 3:04 PM, Nils Loodin wrote:
> webrev here: http://cr.openjdk.java.net/~nloodin/7067811/webrev.03/
> 
> Bug states that we need a block of comments in each demo source file as well as top level read-me:s in the demo and samples dir stating that the code is unfit for production. From description:

Hi Nisse,

if I'm reading this right, this is the same patch as the one you're proposing for jdk8 over here:
http://mail.openjdk.java.net/pipermail/serviceability-dev/2011-August/004450.html - correct?

In that case, you don't need to request an additional review here - instead you will need
to request approval (in a separate mail to this list) to push the change into jdk7u-dev 
once you have pushed it into jdk8. A template for that mail is here:

Subject: Request for approval for CR $NR

With the body containing 

a) a link to the publicly visible bug on the bugs.sun.com site (or its equivalent), or a description of the change in case no publicly visible bug is here
b) a link to the publicly visible webrev or changeset (in case it's in JDK 8 already)
c) if the review is taking place somewhere else, a link to the public review thread
d) if the fix has already been reviewed for inclusion into jdk7u-dev, the list of reviewers
e) once we branch off 7u2, you'll also need to add the forest the fix is targeted for

I'd suggest waiting for the reviews for jdk8 to complete before you ask for approval, 
though, in case that the proposed changeset turns out to need to be modified before the 
actual push into jdk8.

cheers,
dalibor topic

-- 
Oracle <http://www.oracle.com>
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192>
Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment