Need reviewer- for jdk7u-osx

[Kelly O'Hair]

On Dec 5, 2011, at 8:46 PM, David Holmes wrote:

> Hi Kelly,
> 
> On 6/12/2011 1:19 PM, Kelly O'Hair wrote:
>> 
>> For the jdk7u-osx forest (Mac port):
>> 
>> 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac
>> 7118095: Add macosx targets to make/jprt.properties file
>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-make/webrev/
>> 
>> The make/jprt.properties file changes only impact JPRT.
> 
> Looks okay to me.
> 
> I really like the new(?) TESTNAME substitution mechanism!
> 
> I'm wondering though why the full list of build targets had to be set in each of the jprt.properties file? Isn't it sufficient for the JPRT system itself to define the base set of targets?

That's an option, but so far experience has demonstrated that it's better to keep this list close to the test target
list, and the test target list is more associated with the repository or forest than anything else.
And some of these repositories might want to shorten their default build lists and expand their testing, like
langtools, which is pure java. By having the list explicit, the teams can play with it more.

-kto

> 
> David
> 
>> -kto
>>