Need reviewer on small test/Makefile change for jdk7u-osx

Kelly O'Hair kelly.ohair at oracle.com
Wed Dec 7 08:27:47 PST 2011


On Dec 6, 2011, at 9:37 PM, David Holmes wrote:

> +1
> 
> Well it looks correct. The 64-bit detection is way too ugly to ever look "good" ;-)

Yeah, it's amazing how many different ways there are to spell x86 or x64. :^(

I've just gotten used to mapping all possibilities. Normally this would have been buried
in some kind of define macro, but the test/Makefile currently does not use the shared
Defs*.gmk makefiles of the build. :^(

-kto

> 
> David
> 
> PS. I got a 404 trying to use the frames view of the webrev.
> 
> On 7/12/2011 12:45 PM, James Melvin wrote:
>> Looks good!
>> 
>> - Jim
>> 
>> 
>> On 12/6/11 9:30 PM, Kelly O'Hair wrote:
>>> 
>>> For the jdk7u-osx forest (Mac port):
>>> 
>>> 7118773: Fix jdk/test/makefile so it works on the mac
>>> 
>>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-test/webrev
>>> 
>>> The test/Makefile changes so it works for Mac.
>>> It thinks it's windows right now. :^(
>>> 
>>> -kto




More information about the jdk7u-dev mailing list