[7u4] Request for approval for CR 7121600 - Instrumentation.redefineClasses() leaks class bytes

[Daniel D. Daugherty]

Thanks!  And I hope that you feel better soon.

I hope you have a Merry Christmas and a Happy New Year!

Dan


On 12/23/11 10:30 AM, Edvard Wendelin wrote:
> Approved! Sorry for the delay. I've been home sick today!
>
> Merry Christmas!
>
> /Edvard
>
> Sent from my iPhone
>
> On 23 dec 2011, at 05:08, "Daniel D. Daugherty"<daniel.daugherty at oracle.com>  wrote:
>
>> Greetings,
>>
>> I'd like to push the following changeset from JDK8 to JDK7u4.
>> The changes in JDK7u4 are identical to the changes in JDK8.
>>
>> Here is the bug link:
>>
>>     7121600 2/3 Instrumentation.redefineClasses() leaks class bytes
>>     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7121600
>>
>> Changeset: 3c1ab134db71
>> Author:    dcubed
>> Date:      2011-12-22 18:35 -0800
>> URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1ab134db71
>>
>> 7121600: Instrumentation.redefineClasses() leaks class bytes
>> Summary: Call JNI ReleaseByteArrayElements() on memory returned by JNI GetByteArrayElements(). Also push test for 7122253.
>> Reviewed-by: acorn, poonam
>>
>> ! src/share/instrument/JPLISAgent.c
>> + test/java/lang/instrument/BigClass.java
>> + test/java/lang/instrument/MakeJAR4.sh
>> + test/java/lang/instrument/RedefineBigClass.sh
>> + test/java/lang/instrument/RedefineBigClassAgent.java
>> + test/java/lang/instrument/RedefineBigClassApp.java
>> + test/java/lang/instrument/RetransformBigClass.sh
>> + test/java/lang/instrument/RetransformBigClassAgent.java
>> + test/java/lang/instrument/RetransformBigClassApp.java
>>
>> The code review was conducted on the
>> serviceability-dev at openjdk.java.net and
>> the hotspot-runtime-dev at openjdk.java.net aliases.
>>
>> Thanks!
>>
>> Dan
>>
>>