[7u4] Request for approval for 7124627 - Please sync up changes from workspace macosx-port into the jdk7u-osx

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Dec 23 09:49:39 PST 2011


Launcher changes:

I am not very happy about using #ifdef's in java.c
we had taken steps to ensure that all platform dependent 
code, be removed from src/share/bin/java.c
but it is unfortunate to see conditionals have crept in.

My recommendation is to have SplashScreen as it is,
but for Macos have an empty implementation, add a new
function SpashScreenMacOS or something in java_md.c which
will do all the necessary Mac specific items, and try to
move much as possible the MacOS dependent code into java_md.c

The current state of java_md.c is unmaintainable, I am
planning on  refactoring this code, as a separate effort,
I will send a webrev once I am done.

Kumar

----- alexander.zuev at oracle.com wrote:

> From: alexander.zuev at oracle.com
> To: jdk7u-dev at openjdk.java.net, macosx-port-dev at openjdk.java.net
> Sent: Friday, December 23, 2011 6:55:42 AM GMT -08:00 US/Canada Pacific
> Subject: [7u4] Request for approval for 7124627 - Please sync up changes from workspace macosx-port into the jdk7u-osx
>
> Hi,
> 
>    this is a request to sync up all the work done in the macosx-port 
> workspace since last merge into
> the jdk7u-osx one. There were external review done by contributors of
> 
> the project on public alias and all the
> found glitches were resolved so i assume that external review is 
> finished positively.
> 
>    Webrevs can be found at:
> 
> http://cr.openjdk.java.net/~kizune/merge_jdku7/webrev.01/
> 
> Thanks,
> Alexander Zuev.



More information about the jdk7u-dev mailing list