Request for phase 2 approval for CR 7068451 - Regression: javac compiles fixed sources against previous, not current, version of generated sources

[Edvard Wendelin]

Approved!

Cheers,
Edvard

On 17 okt 2011, at 08.53, Jim Holmlund wrote:

> The bug:
> 	http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7068451
>
> The changeset is the same as in JDK 8:
> 	http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/edd7d9bd32dd
>
> The target repo:
> 	http://hg.openjdk.java.net/jdk7u/jdk7u2-dev-gate/langtools/
>
> This is a regression from JDK 6 that can occur when an annotation  
> processor modifies a .java file that is to be used in a compilation.
> The bug is that the previous version of the file is used instead of  
> the new version.
>
> This creates unfathomable problems for users of the tools that use  
> the javac annotation processing API, such as NetBeans, and I suppose  
> other IDEs.
>
> Risks:
> 	No special risks, other than the usual risks associated with a  
> change.
> 	Given the nature of the change and the amount of testing shown below,
>        the risk seems minimal.
>
> Testing:
> - langtools regression tests pass as expected
> - JCK-Compiler-7 tests pass as expected
> - This change was pushed to jdk8/tl/langtools on Sept 12 - it is in  
> JDK8 B07.
>  It has been thru many nightly tests since then, and three promotion  
> testings.
> - Netbeans has verified that this fix in JDK 8 fixes their problem.
>
> Author:  Jon Gibbons
> Reviewed by:  Maurizio Cimadamore , Jim Holmlund
>