Request for approval for CR 6476261 - (reflect) GenericSignatureFormatError When signature includes nested inner classes
Joe Darcy
joe.darcy at oracle.com
Thu Sep 1 13:11:19 PDT 2011
Hello.
I hereby request approval to backport a trio of signature parsing fixes
from JDK 8 to 7 update:
6476261: (reflect) GenericSignatureFormatError When signature
includes nested inner classes
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6476261
6832374: (reflect) malformed signature can cause parser to go into
infinite loop
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6832374
7052898: (reflect) SignatureParser will accept strings outside of
the grammar
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7052898
Webrev:
http://cr.openjdk.java.net/~darcy/6476261.0/
The code for 7 update is trivially different than the code for JDK 8
since the JDK 8 code takes advantage of a new constructor added to
GenericSignatureFormatError; here is the diff to SignatureParser.java:
123,126c123,124
< if (DEBUG)
< System.out.println("Signature Parse error: " + errorMsg +
< "\n\tRemaining input: " + remainder());
< return new GenericSignatureFormatError();
---
> return new GenericSignatureFormatError("Signature Parse
error: " + errorMsg +
> "\n\tRemaining input:
" + remainder());
Thanks,
-Joe
More information about the jdk7u-dev
mailing list