URGENT: Request for approval for CR #7049963 - DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6(NOT COMPATIBLE WITH JROC

[Dalibor Topic]

On 9/15/11 10:23 AM, Dalibor Topic wrote:
> On 9/15/11 10:08 AM, Mala Bankal wrote:
>> Thanks. Should i add the link to the jdk7u2 webrev ?
>>
>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52bc200b14e5
> 
> a) I can't see the bug on bugs.sun.com - please describe what this
> change is supposed to fix.
> 
> b) Is the changeset at http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52bc200b14e5 the same patch as 
> in http://cr.openjdk.java.net/~mbankal/7049963/webrev.00/?

Since you said that this was urgent, I took a look at the patches rather then waiting for a 
reply. Unfortunately, the patches are not the same, so we'll have to put the approval on
hold until the difference is reviewed -

---- a/src/share/classes/sun/security/x509/AVA.java	Wed Sep 14 08:33:34 2011 -0700
-+++ b/src/share/classes/sun/security/x509/AVA.java	Wed Sep 14 21:43:42 2011 -0700
-@@ -1071,8 +1071,17 @@ public class AVA implements DerEncoder {
+--- old/src/share/classes/sun/security/x509/AVA.java	Tue Sep 13 03:32:51 2011
++++ new/src/share/classes/sun/security/x509/AVA.java	Tue Sep 13 03:32:47 2011
+@@ -1,5 +1,5 @@
+ /*
+- * Copyright (c) 1996, 2010, Oracle and/or its affiliates. All rights reserved.
++ * Copyright (c) 1996, 2011, Oracle and/or its affiliates. All rights reserved.
+  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+  *
+  * This code is free software; you can redistribute it and/or modify it
+@@ -1080,8 +1080,17 @@
                   * to need quoting, or at least escaping.  So do leading or
                   * trailing spaces, and multiple internal spaces.
                   */
@@ -28,7 +26,7 @@
                      if (DerValue.isPrintableStringChar(c) ||
                          escapees.indexOf(c) >= 0) {
  
-@@ -1136,7 +1145,8 @@ public class AVA implements DerEncoder {
+@@ -1145,7 +1154,8 @@
                  }
  
                  // Emit the string ... quote it if needed
@@ -38,4 +36,3 @@
                      retval.append("\"" + sbuffer.toString() + "\"");
                  } else {
                      retval.append(sbuffer.toString());
-

I can live with the trivial whitespace change between 7u and 8 - though I would prefer not 
to see them as they introduce spurious diffs requiring us to spend time reviewing followup 
changes. I am a but surprised to see you change the copyright block between 7 and 8, though,
and for this change I'd like to ask Sean Mullan, who reviewed the original change in jdk8,
to take a look at the webrev and let us know if that's OK for JDK 7 Updates.

Sean, your turn. ;)

cheers,
dalibor topic

-- 
Oracle <http://www.oracle.com>
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192>
Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment