contingent review request for 7071904 HotSpot: Full Debug Symbols

[Daniel D. Daugherty]

On 9/16/11 7:25 AM, Dalibor Topic wrote:
> On 9/16/11 1:53 PM, Daniel D. Daugherty wrote:
>> On 9/16/11 3:08 AM, Dalibor Topic wrote:
>>> On 9/15/11 11:28 PM, Daniel D. Daugherty wrote:
>>>> Dalibor and Edvard,
>>>>
>>>> Here is the contingent review request for the hotspot repo part
>>>> of Full Debug Symbols Phase 1.
>>>>
>>>> Again, the reason that I'm considering this to be a contingent
>>>> request is that I don't have "go" from the VM/SQE team nor from
>>>> the Program Management folks.
>>> I'm not familiar with the concept of contingent approval requests.
>>>
>>> Could you elaborate on why this change can't go in via the the next
>>> HS22 bulk integration?
>> If the fix gets approved, it will go in via the next HSX22 bulk
>> integration request. I've attached two more messages that will
>> hopefully fill in the blanks.
> OK. I'm still not clear on what the consequence is of me or Edvard approving
> or not approving this request, as the code would be in the next HSX22 bulk
> integration request. Right?

I definitely need to back up and try again on this set of
contingent review requests for OpenJDK7Update.

The Full Debug Symbols project will need to push changes to
three repos:

hotspot          - using 7071904
install (closed) - using 7071908
jdk              - using 7085944

The install stuff is closed so that can be ignored for the purposes
of the OpenJDK7Update request and approval stuff. However, my assumption
is that Dalibor and Edvard also have control into what gets pushed into
the closed repos for the JDK7Update (notice no "Open" in the previous
word :-)). If I'm wrong, then I need to be pointed at the right folks.

The jdk stuff is just to enable importing the .debuginfo files from
hotspot repo. There's a little bit of extra makefile stuff in there
for Phase 2 of Full Debug Symbols, but the primary focus of the JDK
changes is to import the .debuginfo files from hotspot. The jdk changes
can only be pushed after the hotspot changes.

The hotspot request is advisory in nature. I made a "contingent review
request" and not a push permission request. Yes, the changes will be
coming via an HSX bulk update, but I wanted you folks to be aware of
these changes. Particular because the hotspot changes are related to
other changes in the jdk and install repos.

I'm hoping that this is all much clearer now.

Dan