[7u4] RFR: 7134701 [macosx] Support legacy native library names

Scott Kovatch scott.kovatch at oracle.com
Mon Apr 2 09:33:06 PDT 2012


HTML-based mail is sneaky. You changed the text but not the actual link.

http://cr.openjdk.java.net/~michaelm/7134701/webrev.7u4.2/

should work better.

Everything still looks okay.

-- Scott

On Apr 2, 2012, at 10:23 AM, Michael McMahon wrote:

> Sorry Scott, that was the wrong link. I mistakenly forwarded the original
> email instead of the updated one..
> 
> This is the correct webrev:
> 
> 
> 
> Thanks, 
> Michael. 
> 
> 
> On 02/04/12 17:20, Scott Kovatch wrote:
>> 
>> On Apr 2, 2012, at 9:35 AM, Michael McMahon wrote:
>> 
>>> This should have been reviewed on this list. So, I am forwarding the
>>> request again. It hasn't changed since the original webrev was reviewed
>>> on core-libs and the macos lists.
>>> 
>>> It is the same code change as for jdk 8
>>> 
>>> http://cr.openjdk.java.net/~michaelm/7134701/webrev.7u4.1/
>> 
>> So in the end it looks like we will only support checking both .jnilib and .dylib on Mac:
>> 
>> 1. When using System.loadLibrary()
>> 2. The class calling System.loadLibrary() was NOT loaded from a custom class loader
>> 3. isAbsolute is false, which implies System.load() was called.
>> 
>> I saw the macosx discussion, and I think this is fine. If you're calling System.load() you know what file you want to load, and the extension shouldn't be inferred. Likewise, we shouldn't override the policy of a non-system class loader.
>> 
>> I enthusiastically approve this change. :-)
>> 
>> -- Scott K.
>> 
>> ----------------------------------------
>> Scott Kovatch
>> scott.kovatch at oracle.com
>> Santa Clara/Pleasanton, CA
>> 
> 




More information about the jdk7u-dev mailing list