[7u8] Request for approval: 7113017: Use POSIX compliant include file headers in sun/awt/medialib/mlib_types.h

[Seán Coffey]

Phil,

Edvard is OOTO at the moment.

A new bug ID is required since 7113017 changes are already in 7u. Is 
there a bug ID following this issue ? If so, can you give it to the 
original engineer who requested this backport - Charles Lee : 
littlee at linux.vnet.ibm.com

Charles - will you be able to work this one through with 2d team ?

regards,
Sean.

On 02/08/2012 17:49, Phil Race wrote:
> Edvard,
>
> This change to 7u8 needs to be reverted.
> We have a probable fix to this bad fix for JDK 8, but
> we can't afford to be debugging unnecessary changes in the 7ux train.
>
> -phil.
>
> On 7/31/2012 12:52 PM, Phil Race wrote:
>> I didn't notice this request before due to being extremely busy,
>> but it should have started on the 2D list.
>> The whole email review system is an unscalable mess.
>> I am nervous because I have not yet had time to investigate why SQE 
>> and others started
>> seeing imaging crashes in 64 bit JDK 8 on Linux with the earliest on 
>> the very build (b15) this fix went in
>> when it was the *only* 2D related change , but it seems it likely was 
>> not a 64 bit clean change
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159382
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150594
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7167785
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7179434
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183039
>>
>> So I would have said no to this back port until we'd figured this out.
>>
>> -phil.
>>
>> On 7/11/2012 5:08 AM, Neil Richards wrote:
>>> Now pushed to jdk7u-dev [1].
>>>
>>> Regards,
>>> Neil
>>>
>>> [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/45ef4cd48167
>>>
>>> On Tue, 2012-07-10 at 09:44 +0200, Edvard Wendelin wrote:
>>>> Approved.
>>>>
>>>> On Jul 10, 2012, at 8:11 AM, Charles Lee wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> Requesting for approval to push the changes to use Posix compliant 
>>>>> include file headers in mlib-types.h
>>>>>
>>>>> Chaneset in jdk8 @ 
>>>>> http://hg.openjdk.java.net/jdk8/2d/jdk/rev/89952dc5be8e
>>>>> Webrev for jdk7u @ 
>>>>> http://cr.openjdk.java.net/~littlee/jdk7u/252/webrev.00/<http://cr.openjdk.java.net/%7Elittlee/jdk7u/252/webrev.00/>
>>>>>
>>>>> Reviewed by:
>>>>> Phil Race
>>>>> Andrew Brygin
>>>>>
>>>>> Please notice that:
>>>>> The patch in the jdk8 does not contain the mac porting things. But 
>>>>> I believe it should also work on the Mac.
>>>>>
>>>>> -- 
>>>>> Yours Charles
>>>>>
>>>
>>
>