[7u6] Request for phase 2 approval for CR 7188168: 7071904 broke the DEBUG_BINARIES option on Linux

[Seán Coffey]

Andrew,

Unfortunately this request comes very late in the 7u6 stabilization 
phase. Thorough testing & analysis is almost complete and we're 
preparing for release. As previously communicated, only critical bug 
fixes are being considered. With this issue not affecting the product 
JDK bits, can I ask that you push this fix to the jdk7u-dev repo instead.

I'll create a 7u8 bug report for tracking purposes.

Regards,
Sean.

On 10/08/12 13:47, Andrew Hughes wrote:
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188168
> JDK8: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/282abd0fd878
>
> Applies cleanly to 7u6.
>
> Original discussion: http://mail.openjdk.java.net/pipermail/hotspot-dev/2012-July/006247.html
> Original review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-August/004184.html
>
> Reasoning:
>
> This is a regression caused by the application of 7071904 to jdk7u.  Prior to 7071904, a
> build with DEBUG_BINARIES=true would result in binaries with DWARF debug output, built using "-g".
> After this change, bianries on platforms other than x86_64, ia64, arm and ppc (such as x86 and
> SPARC) are built using the STABS debug format.  This causes issues with using the GNU/Linux
> toolchain to debug/trace the JDK binaries e.g.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=841057
>
> DWARF is the standard format used on GNU/Linux distributions, so support for STABS is either
> not as well tested or, in the case of newer tools, non-existent.
>
> Applying this fix shouldn't have any effect on builds which don't use DEBUG_BINARIES (the change
> just moves the existing code into the else block of a DEBUG_BINARIES=true check), but will
> allow us to build the JDK with the same debug information as we did prior to 7071904.
>
> Thanks,